[v2,00/17] target/arm: vfp feature and decodetree cleanup

Message ID 20200224222232.13807-1-richard.henderson@linaro.org
Headers show
Series
  • target/arm: vfp feature and decodetree cleanup
Related show

Message

Richard Henderson Feb. 24, 2020, 10:22 p.m.
The main goal of the patchset is to move the ARM_FEATURE_VFP test from
outside of the disas_vfp_insn() to inside each of the trans_* functions,
so that we get the proper ISA check for each case.  At the end of that,
it is easy to eliminate all of the remaining tests vs ARM_FEATURE_VFP*
in favor of the preferred ISAR tests.  Finally, there are a couple of
cleanups to vfp.decode to make things a bit more legible.

Changes for v2:
  * Replace aa32_simd_r16 by aa32_vfp_simd.
  * Add aa64_fp_simd, aa32_vfp.
  * Improve aa64 has_vfp/has_neon check.
  * Fix some "any" tests.


r~


Richard Henderson (17):
  target/arm: Add isar_feature_aa32_vfp_simd
  target/arm: Rename isar_feature_aa32_fpdp_v2
  target/arm: Add isar_feature_aa32_{fpsp_v2,fpsp_v3,fpdp_v3}
  target/arm: Add isar_feature_aa64_fp_simd, isar_feature_aa32_vfp
  target/arm: Improve ID_AA64PFR0 FP/SIMD validation
  target/arm: Perform fpdp_v2 check first
  target/arm: Replace ARM_FEATURE_VFP3 checks with fp{sp,dp}_v3
  target/arm: Add missing checks for fpsp_v2
  target/arm: Replace ARM_FEATURE_VFP4 with isar_feature_aa32_simdfmac
  target/arm: Remove ARM_FEATURE_VFP check from disas_vfp_insn
  target/arm: Move VLLDM and VLSTM to vfp.decode
  target/arm: Move the vfp decodetree calls next to the base isa
  linux-user/arm: Replace ARM_FEATURE_VFP* tests for HWCAP
  target/arm: Remove ARM_FEATURE_VFP*
  target/arm: Add formats for some vfp 2 and 3-register insns
  target/arm: Split VFM decode
  target/arm: Split VMINMAXNM decode

 target/arm/cpu.h               |  57 ++++-
 target/arm/vfp-uncond.decode   |  12 +-
 target/arm/vfp.decode          | 153 +++++------
 hw/intc/armv7m_nvic.c          |  20 +-
 linux-user/arm/signal.c        |   4 +-
 linux-user/elfload.c           |  23 +-
 target/arm/arch_dump.c         |  11 +-
 target/arm/cpu.c               |  67 ++---
 target/arm/cpu64.c             |   3 -
 target/arm/helper.c            |   4 +-
 target/arm/kvm32.c             |   5 -
 target/arm/kvm64.c             |   1 -
 target/arm/m_helper.c          |  11 +-
 target/arm/machine.c           |   5 +-
 target/arm/translate-vfp.inc.c | 448 ++++++++++++++++++++-------------
 target/arm/translate.c         | 122 +++------
 16 files changed, 498 insertions(+), 448 deletions(-)

-- 
2.20.1

Comments

Peter Maydell Feb. 25, 2020, 5:40 p.m. | #1
On Mon, 24 Feb 2020 at 22:22, Richard Henderson
<richard.henderson@linaro.org> wrote:
>

> The main goal of the patchset is to move the ARM_FEATURE_VFP test from

> outside of the disas_vfp_insn() to inside each of the trans_* functions,

> so that we get the proper ISA check for each case.  At the end of that,

> it is easy to eliminate all of the remaining tests vs ARM_FEATURE_VFP*

> in favor of the preferred ISAR tests.  Finally, there are a couple of

> cleanups to vfp.decode to make things a bit more legible.

>

> Changes for v2:

>   * Replace aa32_simd_r16 by aa32_vfp_simd.

>   * Add aa64_fp_simd, aa32_vfp.

>   * Improve aa64 has_vfp/has_neon check.

>   * Fix some "any" tests.

>


I've dropped patch 5 and applied the rest to target-arm.next.

thanks
-- PMM