From patchwork Thu Apr 30 09:16:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ulf Hansson X-Patchwork-Id: 185881 Delivered-To: patches@linaro.org Received: by 2002:a92:3d9a:0:0:0:0:0 with SMTP id k26csp1838992ilf; Thu, 30 Apr 2020 02:16:55 -0700 (PDT) X-Received: by 2002:a2e:5847:: with SMTP id x7mr1554153ljd.61.1588238215016; Thu, 30 Apr 2020 02:16:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588238215; cv=none; d=google.com; s=arc-20160816; b=yNcBf9ho8EClj+yjgCuCFXJF1PYxzPPZG4WJMgoTB3qKuYkggANRmW2rl7cdO7VtS5 OZ0ocjXySiKF/5hkzix2YCf0xvf7sQGKurCRZwZ1cWIcfqS/HzjAFZOeZUtxSzeeSpVy 4i5mBidF0Z8XLM7VakhQy3yW7lQ3QWrXvWD3OAAQ8eShOn+BNm4+7f7AHrZLfUjgPCKF +BwIgdmSw9y+5OyCJPtoSR7WxEPdVFw3ewE5Q0i+w/IKELXCjRaewU4141fAWLk2mc40 o2gY5qlCmhV2tVcvxFKl2h1jXtId74eGdQ1zpTlPYybW6+A/mExrJ7TZgviLthfhIzyT cDeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=5PLEzFtiTHiEFZcHjUWZsk1as7iY/+JvOpvH6h5KaAg=; b=wF6dMCpnojspM3Z6EveWl5nQgc4Dk99Qj5Xnepdf9M+V/hIbHMHWEy7HmF3LE8W7XP KOyW/6whRmdrEkvuT8Zx+v5P4joYmnJW8PlAzwACvJUfzOUZQyFrf0v9mNOZUDaCf8iV djL7cDsSxgjLB9SrAnZ0sggxbicZz83N+AYop08dbdc86Yf3bJ0dGyUEjynBMcr6v1+Z jzq9d3riUOFy6FNP6e825kDxcsU9OoWO1Iba+y1cNgpHp64+Qda0lY9eO9ScqCPnze6J nz8ILBmra7rFFJadr5wnjWvglOa7KbINo5FnwCpBfBtZGux7MSHqkP1dIPECASDYQath amEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zsgulO4d; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id q2sor3633172ljj.4.2020.04.30.02.16.54 for (Google Transport Security); Thu, 30 Apr 2020 02:16:54 -0700 (PDT) Received-SPF: pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zsgulO4d; spf=pass (google.com: domain of ulf.hansson@linaro.org designates 209.85.220.65 as permitted sender) smtp.mailfrom=ulf.hansson@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5PLEzFtiTHiEFZcHjUWZsk1as7iY/+JvOpvH6h5KaAg=; b=zsgulO4dH6Do3VLsT9f6zvu2dpTxiUxO2SFwYAi9HkkAAg4JSb1g4ZVe0twlUbfDpf 30bxNRvUrjtk83t9+fxVdVZoAbMzJF1dty37BByl6zDGYXYAVThgD/cDiKHRbPmg0FgA h/JMcCi7C+k/Y7s5uY9oRkkncDrmydYcZJkzrHByCGXxdxl5G73VWtmt35kwVe53mEYc syHyacn5KN8YRmuKCidwj5OXUfO9+sON6MJzAWJ2ARBrFEDwZsUMezwJTu1QZy/9ip7V 4TR257zdscbQ9mrz4jZn9QqRtMPH6Qh3BKkjTrOrt43GDzz4zQqsdVz8qPA3Lv8T2eRO RqXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5PLEzFtiTHiEFZcHjUWZsk1as7iY/+JvOpvH6h5KaAg=; b=KohqAJYr/gaS7gRQPQDSoXwTFV2eHJon3aNgXzfhKymins1FEdv7bMOl3+EgjnT9mv 6hECaVk63eqqSDIDdyAytzmnoAbabNMMjuU72PgGpBeXizRfk+yEvCl4mXcaQqaNPqXc tgI8qWIFei5LF4bElN5pnBEogB8SKqK+GrqsnC3yHcYeRRuFDolBEEI4QpY5aX/+ymg/ 3Z9OPl/JzdAuJ+DETJspRWWlm7QKgLPBW1FUHsXXEH9JnBFsnw88NiyEnNcPShd5e8li HgR2RV4yvpc4mJ6WsPRNuzD48UQYmAwREs09M4NG+WR2hWNcIb5lCjklLlq4pkMOZ3zD 0xaQ== X-Gm-Message-State: AGi0PubaJcGmY7m2X+V8fc4sdR87NAm3jLOxLoJdKBkAJ2NiPMBAG8w9 369rq+8A0zKQTrZaJby/UDVUPWAb X-Google-Smtp-Source: APiQypIk8S4FeWypTzc/IlTqJlvLuTOrnen4IjIj+4LjqQ6dgxQqQf3++gUkr7FL7gKDQPnm355s2Q== X-Received: by 2002:a2e:98c4:: with SMTP id s4mr1561552ljj.97.1588238214479; Thu, 30 Apr 2020 02:16:54 -0700 (PDT) Return-Path: Received: from localhost.localdomain (h-98-128-181-7.NA.cust.bahnhof.se. [98.128.181.7]) by smtp.gmail.com with ESMTPSA id x29sm4417818lfn.64.2020.04.30.02.16.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2020 02:16:53 -0700 (PDT) From: Ulf Hansson To: linux-mmc@vger.kernel.org, Ulf Hansson Cc: Adrian Hunter , Douglas Anderson , Matthias Kaehlcke , Shawn Lin , Yong Mao , Chaotian Jing Subject: [PATCH 0/4] mmc: sdio: Fix various issues in mmc_sdio_init_card() Date: Thu, 30 Apr 2020 11:16:36 +0200 Message-Id: <20200430091640.455-1-ulf.hansson@linaro.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Over the years, the code in mmc_sdio_init_card() has grown to become quite messy. Unfortunate also leading to several various errors. This series addresses some of them, but it's likely that there are even more things that needs to be fixed on top. I have tested this on Hikey board, with an SDIO card corresponding to a WiFi chip from TI (wl1835). Additional tests and review comments, are usual much appreciated. Kind regards Uffe Ulf Hansson (4): mmc: sdio: Fix potential NULL pointer error in mmc_sdio_init_card() mmc: sdio: Fix several potential memory leaks in mmc_sdio_init_card() mmc: sdio: Re-use negotiated OCR mask when re-sending CMD8 mmc: sdio: Align the initialization commands in retry path for UHS-I drivers/mmc/core/sdio.c | 116 +++++++++++++++++++--------------------- 1 file changed, 55 insertions(+), 61 deletions(-) -- 2.20.1