| Message ID | 20200519164957.26920-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | softfloat misc cleanups | expand |
Patchew URL: https://patchew.org/QEMU/20200519164957.26920-1-richard.henderson@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200519164957.26920-1-richard.henderson@linaro.org Subject: [PULL 00/10] softfloat misc cleanups Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20200515170804.5707-1-philmd@redhat.com -> patchew/20200515170804.5707-1-philmd@redhat.com - [tag update] patchew/20200516063746.18296-1-anup.patel@wdc.com -> patchew/20200516063746.18296-1-anup.patel@wdc.com * [new tag] patchew/cover.1589923785.git.alistair.francis@wdc.com -> patchew/cover.1589923785.git.alistair.francis@wdc.com Switched to a new branch 'test' c74e51d softfloat: Return bool from all classification predicates 796da14 softfloat: Inline floatx80 compare specializations f3197d3 softfloat: Inline float128 compare specializations c4e06ab softfloat: Inline float64 compare specializations 65adcae softfloat: Inline float32 compare specializations 4afb04e softfloat: Name compare relation enum 5383e5e softfloat: Name rounding mode enum af9e7fd softfloat: Change tininess_before_rounding to bool 876ddf8 softfloat: Replace flag with bool 802d7a7 softfloat: Use post test for floatN_mul === OUTPUT BEGIN === 1/10 Checking commit 802d7a73a18b (softfloat: Use post test for floatN_mul) 2/10 Checking commit 876ddf8f83ce (softfloat: Replace flag with bool) 3/10 Checking commit af9e7fdfdaed (softfloat: Change tininess_before_rounding to bool) ERROR: space prohibited before that close parenthesis ')' #68: FILE: fpu/softfloat.c:3877: + || (zExp < 0 ) total: 1 errors, 0 warnings, 143 lines checked Patch 3/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/10 Checking commit 5383e5ecf1e3 (softfloat: Name rounding mode enum) 5/10 Checking commit 4afb04e42c21 (softfloat: Name compare relation enum) 6/10 Checking commit 65adcae6a290 (softfloat: Inline float32 compare specializations) 7/10 Checking commit c4e06abc4c09 (softfloat: Inline float64 compare specializations) 8/10 Checking commit f3197d3ad884 (softfloat: Inline float128 compare specializations) 9/10 Checking commit 796da149b721 (softfloat: Inline floatx80 compare specializations) 10/10 Checking commit c74e51d0ed0d (softfloat: Return bool from all classification predicates) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200519164957.26920-1-richard.henderson@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Tue, 19 May 2020 at 17:49, Richard Henderson <richard.henderson@linaro.org> wrote: > > The following changes since commit f2465433b43fb87766d79f42191607dac4aed5b4: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2020-05-19 13:42:58 +0100) > > are available in the Git repository at: > > https://github.com/rth7680/qemu.git tags/pull-fpu-20200519 > > for you to fetch changes up to 150c7a91ce7862bcaf7422f6038dcf0ba4a7eee3: > > softfloat: Return bool from all classification predicates (2020-05-19 08:43:05 -0700) > > ---------------------------------------------------------------- > Misc cleanups > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM
The following changes since commit f2465433b43fb87766d79f42191607dac4aed5b4: Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2020-05-19 13:42:58 +0100) are available in the Git repository at: https://github.com/rth7680/qemu.git tags/pull-fpu-20200519 for you to fetch changes up to 150c7a91ce7862bcaf7422f6038dcf0ba4a7eee3: softfloat: Return bool from all classification predicates (2020-05-19 08:43:05 -0700) ---------------------------------------------------------------- Misc cleanups ---------------------------------------------------------------- Richard Henderson (10): softfloat: Use post test for floatN_mul softfloat: Replace flag with bool softfloat: Change tininess_before_rounding to bool softfloat: Name rounding mode enum softfloat: Name compare relation enum softfloat: Inline float32 compare specializations softfloat: Inline float64 compare specializations softfloat: Inline float128 compare specializations softfloat: Inline floatx80 compare specializations softfloat: Return bool from all classification predicates include/fpu/softfloat-helpers.h | 27 +- include/fpu/softfloat-macros.h | 24 +- include/fpu/softfloat-types.h | 28 +- include/fpu/softfloat.h | 336 +++++++--- target/i386/ops_sse.h | 8 +- fpu/softfloat-specialize.inc.c | 32 +- fpu/softfloat.c | 1305 +++++---------------------------------- target/arm/sve_helper.c | 8 +- target/arm/vfp_helper.c | 14 +- target/hppa/op_helper.c | 7 +- target/i386/fpu_helper.c | 8 +- target/m68k/fpu_helper.c | 6 +- target/m68k/softfloat.c | 70 +-- target/mips/msa_helper.c | 10 +- target/openrisc/fpu_helper.c | 4 +- target/ppc/int_helper.c | 13 +- target/s390x/fpu_helper.c | 22 +- target/s390x/vec_fpu_helper.c | 2 +- target/sparc/fop_helper.c | 4 +- target/unicore32/ucf64_helper.c | 6 +- target/xtensa/fpu_helper.c | 6 +- tests/fp/fp-test.c | 2 +- 22 files changed, 547 insertions(+), 1395 deletions(-)