mbox series

[net,0/2] wireguard fixes for 5.8-rc3

Message ID 20200623095945.1402468-1-Jason@zx2c4.com
Headers show
Series wireguard fixes for 5.8-rc3 | expand

Message

Jason A. Donenfeld June 23, 2020, 9:59 a.m. UTC 
Hi Dave,

This series contains two fixes, one cosmetic and one quite important:

1) Avoid the `if ((x = f()) == y)` pattern, from Frank
   Werner-Krippendorf.

2) Mitigate a potential memory leak by creating circular netns
   references, while also making the netns semantics a bit more
   robust.

Patch (2) has a "Fixes:" line and should be backported to stable.

Thanks,
Jason


Frank Werner-Krippendorf (1):
  wireguard: noise: do not assign initiation time in if condition

Jason A. Donenfeld (1):
  wireguard: device: avoid circular netns references

 drivers/net/wireguard/device.c             | 58 ++++++++++------------
 drivers/net/wireguard/device.h             |  3 +-
 drivers/net/wireguard/netlink.c            | 14 ++++--
 drivers/net/wireguard/noise.c              |  4 +-
 drivers/net/wireguard/socket.c             | 25 +++++++---
 tools/testing/selftests/wireguard/netns.sh | 13 ++++-
 6 files changed, 69 insertions(+), 48 deletions(-)

-- 
2.27.0

Comments

David Miller June 23, 2020, 9:51 p.m. UTC | #1 
From: "Jason A. Donenfeld" <Jason@zx2c4.com>

Date: Tue, 23 Jun 2020 03:59:43 -0600

> This series contains two fixes, one cosmetic and one quite important:

> 

> 1) Avoid the `if ((x = f()) == y)` pattern, from Frank

>    Werner-Krippendorf.

> 

> 2) Mitigate a potential memory leak by creating circular netns

>    references, while also making the netns semantics a bit more

>    robust.


Series applied.

> Patch (2) has a "Fixes:" line and should be backported to stable.


Queued up.

Thanks.