mbox series

[0/5] crypto: hisilicon/sec2 - fix SEC bugs and coding styles

Message ID 1593167529-22463-1-git-send-email-liulongfang@huawei.com
Headers show
Series crypto: hisilicon/sec2 - fix SEC bugs and coding styles | expand

Message

liulongfang June 26, 2020, 10:32 a.m. UTC 
Fix some SEC driver bugs and modify some coding styles

Kai Ye (2):
  crypto: hisilicon/sec2 - clear SEC debug regs
  crypto:hisilicon/sec2 - update busy processing logic

Longfang Liu (3):
  crypto: hisilicon/sec2 - update SEC initialization and reset
  crypto: hisilicon/sec2 - update debugfs interface parameters
  crypto: hisilicon/sec2 - fix some coding styles

 drivers/crypto/hisilicon/qm.h              |   1 +
 drivers/crypto/hisilicon/sec2/sec.h        |   3 +
 drivers/crypto/hisilicon/sec2/sec_crypto.c |  81 +++++++++++++------
 drivers/crypto/hisilicon/sec2/sec_main.c   | 126 +++++++++++++++--------------
 4 files changed, 128 insertions(+), 83 deletions(-)

Comments

Herbert Xu July 3, 2020, 4:14 a.m. UTC | #1 
On Fri, Jun 26, 2020 at 06:32:06PM +0800, Longfang Liu wrote:
> From: Kai Ye <yekai13@huawei.com>

> 

> As before, if a SEC queue is at the 'fake busy' status,

> the request with a 'fake busy' flag will be sent into hardware

> and the sending function returns busy. After the request is

> finished, SEC driver's call back will identify the 'fake busy' flag,

> and notifies the user that hardware is not busy now by calling

> user's call back function.

> 

> Now, a request sent into busy hardware will be cached in the

> SEC queue's backlog, return '-EBUSY' to user.

> After the request being finished, the cached requests will

> be processed in the call back function. to notify the

> corresponding user that SEC queue can process more requests.

> 

> Signed-off-by: Kai Ye <yekai13@huawei.com>

> Reviewed-by: Longfang Liu <liulongfang@huawei.com>


Why does this driver not take MAY_BACKLOG into account?

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
liulongfang July 3, 2020, 8:18 a.m. UTC | #2 
On 2020/7/3 12:14, Herbert Xu Wrote:
> On Fri, Jun 26, 2020 at 06:32:06PM +0800, Longfang Liu wrote:

>> From: Kai Ye <yekai13@huawei.com>

>>

>> As before, if a SEC queue is at the 'fake busy' status,

>> the request with a 'fake busy' flag will be sent into hardware

>> and the sending function returns busy. After the request is

>> finished, SEC driver's call back will identify the 'fake busy' flag,

>> and notifies the user that hardware is not busy now by calling

>> user's call back function.

>>

>> Now, a request sent into busy hardware will be cached in the

>> SEC queue's backlog, return '-EBUSY' to user.

>> After the request being finished, the cached requests will

>> be processed in the call back function. to notify the

>> corresponding user that SEC queue can process more requests.

>>

>> Signed-off-by: Kai Ye <yekai13@huawei.com>

>> Reviewed-by: Longfang Liu <liulongfang@huawei.com>

> Why does this driver not take MAY_BACKLOG into account?

>

> Cheers,


OK, I will apply MAY_BACKLOG in the next version soon.

thanks,

Longfang

.