[net,0/2] Two phylink pause fixes

Message ID 20200623164642.GV1551@shell.armlinux.org.uk
Headers show
  • Two phylink pause fixes
Related show


Russell King - ARM Linux admin June 23, 2020, 4:46 p.m.
While testing, I discovered two issues with ethtool -A with phylink.
First, if there is a PHY bound to the network device, we hit a
deadlock when phylib tries to notify us of the link changing as a
result of triggering a renegotiation.

Second, when we are manually forcing the pause settings, and there
is no renegotiation triggered, we do not update the MAC via the new
mac_link_up approach.

These two patches solve both problems, and will need to be backported
to v5.7; they do not apply cleanly there due to the introduction of
PCS in the v5.8 merge window.

 drivers/net/phy/phylink.c | 45 ++++++++++++++++++++++++++++++++-------------
 1 file changed, 32 insertions(+), 13 deletions(-)