mbox series

[v2,0/5] cpuidle: psci: Various improvements for PSCI PM domains

Message ID 20200707125804.13030-1-ulf.hansson@linaro.org
Headers show
Series cpuidle: psci: Various improvements for PSCI PM domains | expand

Message

Ulf Hansson July 7, 2020, 12:57 p.m. UTC
Changes in v2:
	- Put patch 3 as patch 1 and rebased accordingly. No other changes have
	been made.
	- Added reviewed-by and acked-by tags.

The main change in this series is done in patch 5/5, which implements support
to prevent domain idlestates until all PSCI PM domain consumers are ready for
it. To reach that point the corresponding code for cpuidle-psci and
cpuidle-psci-domain, needed to be converted into platform drivers, which is
done by the earlier changes in the series.

Additionally, some improvements have been made to the error path, which becomes
easier when the code gets converted to platform drivers.

Deployment for a Qcom SoC, which actually takes full benefit of these changes
are also in the pipe, but deferring then a bit until $subject series have been
discussed.

Kind regards
Ulf Hansson

Ulf Hansson (5):
  cpuidle: psci: Split into two separate build objects
  cpuidle: psci: Fail cpuidle registration if set OSI mode failed
  cpuidle: psci: Fix error path via converting to a platform driver
  cpuidle: psci: Convert PM domain to platform driver
  cpuidle: psci: Prevent domain idlestates until consumers are ready

 drivers/cpuidle/Kconfig.arm           |  10 ++
 drivers/cpuidle/Makefile              |   5 +-
 drivers/cpuidle/cpuidle-psci-domain.c |  74 +++++++++-----
 drivers/cpuidle/cpuidle-psci.c        | 141 +++++++++++++++-----------
 drivers/cpuidle/cpuidle-psci.h        |  11 +-
 5 files changed, 150 insertions(+), 91 deletions(-)

-- 
2.20.1

Comments

Ulf Hansson July 15, 2020, 9:53 a.m. UTC | #1
On Tue, 7 Jul 2020 at 14:58, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>

> Changes in v2:

>         - Put patch 3 as patch 1 and rebased accordingly. No other changes have

>         been made.

>         - Added reviewed-by and acked-by tags.


Rafael, I think this is ready to be picked up. In particular, the code
that Sudeep/Lorenzo cares most about has been reviewed by
Sudeep/Lukaz.

Kind regards
Uffe


>

> The main change in this series is done in patch 5/5, which implements support

> to prevent domain idlestates until all PSCI PM domain consumers are ready for

> it. To reach that point the corresponding code for cpuidle-psci and

> cpuidle-psci-domain, needed to be converted into platform drivers, which is

> done by the earlier changes in the series.

>

> Additionally, some improvements have been made to the error path, which becomes

> easier when the code gets converted to platform drivers.

>

> Deployment for a Qcom SoC, which actually takes full benefit of these changes

> are also in the pipe, but deferring then a bit until $subject series have been

> discussed.

>

> Kind regards

> Ulf Hansson

>

> Ulf Hansson (5):

>   cpuidle: psci: Split into two separate build objects

>   cpuidle: psci: Fail cpuidle registration if set OSI mode failed

>   cpuidle: psci: Fix error path via converting to a platform driver

>   cpuidle: psci: Convert PM domain to platform driver

>   cpuidle: psci: Prevent domain idlestates until consumers are ready

>

>  drivers/cpuidle/Kconfig.arm           |  10 ++

>  drivers/cpuidle/Makefile              |   5 +-

>  drivers/cpuidle/cpuidle-psci-domain.c |  74 +++++++++-----

>  drivers/cpuidle/cpuidle-psci.c        | 141 +++++++++++++++-----------

>  drivers/cpuidle/cpuidle-psci.h        |  11 +-

>  5 files changed, 150 insertions(+), 91 deletions(-)

>

> --

> 2.20.1

>
Ulf Hansson July 24, 2020, 11:14 a.m. UTC | #2
On Wed, 15 Jul 2020 at 11:53, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>

> On Tue, 7 Jul 2020 at 14:58, Ulf Hansson <ulf.hansson@linaro.org> wrote:

> >

> > Changes in v2:

> >         - Put patch 3 as patch 1 and rebased accordingly. No other changes have

> >         been made.

> >         - Added reviewed-by and acked-by tags.

>

> Rafael, I think this is ready to be picked up. In particular, the code

> that Sudeep/Lorenzo cares most about has been reviewed by

> Sudeep/Lukaz.


Rafael, apologies for nagging. Any reasons you see why this can't be
queued up by now?

Kind regards
Uffe

>

>

> >

> > The main change in this series is done in patch 5/5, which implements support

> > to prevent domain idlestates until all PSCI PM domain consumers are ready for

> > it. To reach that point the corresponding code for cpuidle-psci and

> > cpuidle-psci-domain, needed to be converted into platform drivers, which is

> > done by the earlier changes in the series.

> >

> > Additionally, some improvements have been made to the error path, which becomes

> > easier when the code gets converted to platform drivers.

> >

> > Deployment for a Qcom SoC, which actually takes full benefit of these changes

> > are also in the pipe, but deferring then a bit until $subject series have been

> > discussed.

> >

> > Kind regards

> > Ulf Hansson

> >

> > Ulf Hansson (5):

> >   cpuidle: psci: Split into two separate build objects

> >   cpuidle: psci: Fail cpuidle registration if set OSI mode failed

> >   cpuidle: psci: Fix error path via converting to a platform driver

> >   cpuidle: psci: Convert PM domain to platform driver

> >   cpuidle: psci: Prevent domain idlestates until consumers are ready

> >

> >  drivers/cpuidle/Kconfig.arm           |  10 ++

> >  drivers/cpuidle/Makefile              |   5 +-

> >  drivers/cpuidle/cpuidle-psci-domain.c |  74 +++++++++-----

> >  drivers/cpuidle/cpuidle-psci.c        | 141 +++++++++++++++-----------

> >  drivers/cpuidle/cpuidle-psci.h        |  11 +-

> >  5 files changed, 150 insertions(+), 91 deletions(-)

> >

> > --

> > 2.20.1

> >
Rafael J. Wysocki July 24, 2020, 11:22 a.m. UTC | #3
On Fri, Jul 24, 2020 at 1:15 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:
>

> On Wed, 15 Jul 2020 at 11:53, Ulf Hansson <ulf.hansson@linaro.org> wrote:

> >

> > On Tue, 7 Jul 2020 at 14:58, Ulf Hansson <ulf.hansson@linaro.org> wrote:

> > >

> > > Changes in v2:

> > >         - Put patch 3 as patch 1 and rebased accordingly. No other changes have

> > >         been made.

> > >         - Added reviewed-by and acked-by tags.

> >

> > Rafael, I think this is ready to be picked up. In particular, the code

> > that Sudeep/Lorenzo cares most about has been reviewed by

> > Sudeep/Lukaz.

>

> Rafael, apologies for nagging. Any reasons you see why this can't be

> queued up by now?


I'm mostly offline this week.  I'll queue it up when I'm back early next week.

Cheers!
Rafael J. Wysocki July 27, 2020, 11:24 a.m. UTC | #4
On Fri, Jul 24, 2020 at 1:22 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>

> On Fri, Jul 24, 2020 at 1:15 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:

> >

> > On Wed, 15 Jul 2020 at 11:53, Ulf Hansson <ulf.hansson@linaro.org> wrote:

> > >

> > > On Tue, 7 Jul 2020 at 14:58, Ulf Hansson <ulf.hansson@linaro.org> wrote:

> > > >

> > > > Changes in v2:

> > > >         - Put patch 3 as patch 1 and rebased accordingly. No other changes have

> > > >         been made.

> > > >         - Added reviewed-by and acked-by tags.

> > >

> > > Rafael, I think this is ready to be picked up. In particular, the code

> > > that Sudeep/Lorenzo cares most about has been reviewed by

> > > Sudeep/Lukaz.

> >

> > Rafael, apologies for nagging. Any reasons you see why this can't be

> > queued up by now?

>

> I'm mostly offline this week.  I'll queue it up when I'm back early next week.


And so now applied as 5.9 material, thanks!