[v2,00/13] Rid W=1 warnings in CPUFreq

Message ID 20200715082634.3024816-1-lee.jones@linaro.org
Headers show
Series
  • Rid W=1 warnings in CPUFreq
Related show

Message

Lee Jones July 15, 2020, 8:26 a.m.
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

After these patches are applied, the build system no longer
complains about any W=0 nor W=1 level warnings in drivers/cpufreq.

Hurrah!

Changelog

v1 => v2:
 - Collect *-bys
 - Use __maybe_unused instead of removing device IDs
 - Use __always_unused instead of using unused variables
 - Include architecture header instead of creating new include file

Lee Jones (13):
  cpufreq: freq_table: Demote obvious misuse of kerneldoc to standard
    comment blocks
  cpufreq: cpufreq: Demote lots of function headers unworthy of
    kerneldoc status
  cpufreq: cpufreq_governor: Demote store_sampling_rate() header to
    standard comment block
  cpufreq: sti-cpufreq: Fix some formatting and misspelling issues
  cpufreq: pasemi: Include header file for {check,restore}_astate
    prototypes
  cpufreq: powernv-cpufreq: Functions only used in call-backs should be
    static
  cpufreq: powernv-cpufreq: Fix a bunch of kerneldoc related issues
  cpufreq: acpi-cpufreq: Mark 'dummy' variable as __always_unused
  cpufreq: acpi-cpufreq: Mark sometimes used ID structs as
    __maybe_unused
  cpufreq: powernow-k8: Mark 'hi' and 'lo' dummy variables as
    __always_unused
  cpufreq: pcc-cpufreq: Mark sometimes used ID structs as __maybe_unused
  cpufreq: intel_pstate: Supply struct attribute description for
    get_aperf_mperf_shift()
  cpufreq: amd_freq_sensitivity: Mark sometimes used ID structs as
    __maybe_unused

 drivers/cpufreq/acpi-cpufreq.c         |  8 +++----
 drivers/cpufreq/amd_freq_sensitivity.c |  2 +-
 drivers/cpufreq/cpufreq.c              | 32 ++++++++++++++------------
 drivers/cpufreq/cpufreq_governor.c     |  2 +-
 drivers/cpufreq/freq_table.c           |  6 ++---
 drivers/cpufreq/intel_pstate.c         |  2 ++
 drivers/cpufreq/pasemi-cpufreq.c       |  2 ++
 drivers/cpufreq/pcc-cpufreq.c          |  2 +-
 drivers/cpufreq/powernow-k8.c          |  4 ++--
 drivers/cpufreq/powernv-cpufreq.c      | 15 ++++++------
 drivers/cpufreq/sti-cpufreq.c          |  8 +++----
 11 files changed, 45 insertions(+), 38 deletions(-)

-- 
2.25.1

Comments

Viresh Kumar July 15, 2020, 9:46 a.m. | #1
On 15-07-20, 09:26, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1

> kernel builds, which are currently overwhelmingly riddled with

> niggly little warnings.

> 

> After these patches are applied, the build system no longer

> complains about any W=0 nor W=1 level warnings in drivers/cpufreq.

> 

> Hurrah!

> 

> Changelog

> 

> v1 => v2:

>  - Collect *-bys

>  - Use __maybe_unused instead of removing device IDs

>  - Use __always_unused instead of using unused variables

>  - Include architecture header instead of creating new include file


Acked-by: Viresh Kumar <viresh.kumar@linaro.org>


-- 
viresh
Rafael J. Wysocki July 15, 2020, 1:23 p.m. | #2
On Wed, Jul 15, 2020 at 10:27 AM Lee Jones <lee.jones@linaro.org> wrote:
>

> This set is part of a larger effort attempting to clean-up W=1

> kernel builds, which are currently overwhelmingly riddled with

> niggly little warnings.

>

> After these patches are applied, the build system no longer

> complains about any W=0 nor W=1 level warnings in drivers/cpufreq.

>

> Hurrah!

>

> Changelog

>

> v1 => v2:

>  - Collect *-bys

>  - Use __maybe_unused instead of removing device IDs

>  - Use __always_unused instead of using unused variables

>  - Include architecture header instead of creating new include file

>

> Lee Jones (13):

>   cpufreq: freq_table: Demote obvious misuse of kerneldoc to standard

>     comment blocks

>   cpufreq: cpufreq: Demote lots of function headers unworthy of

>     kerneldoc status

>   cpufreq: cpufreq_governor: Demote store_sampling_rate() header to

>     standard comment block

>   cpufreq: sti-cpufreq: Fix some formatting and misspelling issues

>   cpufreq: pasemi: Include header file for {check,restore}_astate

>     prototypes

>   cpufreq: powernv-cpufreq: Functions only used in call-backs should be

>     static

>   cpufreq: powernv-cpufreq: Fix a bunch of kerneldoc related issues

>   cpufreq: acpi-cpufreq: Mark 'dummy' variable as __always_unused

>   cpufreq: acpi-cpufreq: Mark sometimes used ID structs as

>     __maybe_unused

>   cpufreq: powernow-k8: Mark 'hi' and 'lo' dummy variables as

>     __always_unused

>   cpufreq: pcc-cpufreq: Mark sometimes used ID structs as __maybe_unused

>   cpufreq: intel_pstate: Supply struct attribute description for

>     get_aperf_mperf_shift()

>   cpufreq: amd_freq_sensitivity: Mark sometimes used ID structs as

>     __maybe_unused

>

>  drivers/cpufreq/acpi-cpufreq.c         |  8 +++----

>  drivers/cpufreq/amd_freq_sensitivity.c |  2 +-

>  drivers/cpufreq/cpufreq.c              | 32 ++++++++++++++------------

>  drivers/cpufreq/cpufreq_governor.c     |  2 +-

>  drivers/cpufreq/freq_table.c           |  6 ++---

>  drivers/cpufreq/intel_pstate.c         |  2 ++

>  drivers/cpufreq/pasemi-cpufreq.c       |  2 ++

>  drivers/cpufreq/pcc-cpufreq.c          |  2 +-

>  drivers/cpufreq/powernow-k8.c          |  4 ++--

>  drivers/cpufreq/powernv-cpufreq.c      | 15 ++++++------

>  drivers/cpufreq/sti-cpufreq.c          |  8 +++----

>  11 files changed, 45 insertions(+), 38 deletions(-)

>

> --


All patches except for the [04/13] (applied by Viresh) and [06/13]
(requested to be ignored) applied as 5.9 material with the ACKs from
Viresh, thanks!