From patchwork Mon Jan 16 11:17:54 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gilad Ben-Yossef X-Patchwork-Id: 91555 Delivered-To: patch@linaro.org Received: by 10.182.3.34 with SMTP id 2csp1230986obz; Mon, 16 Jan 2017 03:18:13 -0800 (PST) X-Received: by 10.98.99.197 with SMTP id x188mr36518941pfb.179.1484565493271; Mon, 16 Jan 2017 03:18:13 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u85si21265401pgb.137.2017.01.16.03.18.13; Mon, 16 Jan 2017 03:18:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of netdev-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751350AbdAPLSK (ORCPT + 5 others); Mon, 16 Jan 2017 06:18:10 -0500 Received: from foss.arm.com ([217.140.101.70]:50202 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074AbdAPLSK (ORCPT ); Mon, 16 Jan 2017 06:18:10 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BDE44707; Mon, 16 Jan 2017 03:18:09 -0800 (PST) Received: from gby.kfn.arm.com (unknown [10.45.48.149]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7FF8A3F220; Mon, 16 Jan 2017 03:18:07 -0800 (PST) From: Gilad Ben-Yossef To: steffen.klassert@secunet.com, herbert@gondor.apana.org.au, davem@davemloft.net, netdev@vger.kernel.org Cc: ofir.drang@arm.com, gilad.benyossef@arm.com, Alexander Alemayhu Subject: [PATCH ipsec-next v3 0/2] IPsec: do not ignore crypto err in ah input Date: Mon, 16 Jan 2017 13:17:54 +0200 Message-Id: <1484565476-19371-1-git-send-email-gilad@benyossef.com> X-Mailer: git-send-email 2.1.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org ah input processing uses the asynchronous hash crypto API which supplies an error code as part of the operation completion but the error code was being ignored. Treat a crypto API error indication as a verification failure. While a crypto API reported error would almost certainly result in a memcpy of the digest failing anyway and thus the security risk seems minor, performing a memory compare on what might be uninitialized memory is wrong. Signed-off-by: Gilad Ben-Yossef CC: Alexander Alemayhu --- The change was boot tested on Arm64 but I did not exercise the specific error code path in question. Changes from v2: - Added fix for same problem in IPv6 pointed out by Steffen Klassert Changes from v1: - Fixed typo in patch description pointed out by Alexander Gilad Ben-Yossef (2): IPsec: do not ignore crypto err in ah4 input IPsec: do not ignore crypto err in ah6 input net/ipv4/ah4.c | 3 +++ net/ipv6/ah6.c | 3 +++ 2 files changed, 6 insertions(+) -- 2.1.4