[v9,0/8] Add PWM and IIO timer drivers for STM32

Message ID 1484903709-11650-1-git-send-email-benjamin.gaignard@st.com
Headers show
Series
  • Add PWM and IIO timer drivers for STM32
Related show

Message

Benjamin Gaignard Jan. 20, 2017, 9:15 a.m.
version 9:
- fix pwm commit message header
- re-oerder nodes in DT file

version 8:
- rebase on v4.10-rc4
- fix comments done by Thierry on PWM
- reword "reg" parameter description
- change kernel kernel in IIO ABI documentation

version 7:
- rebase on v4.10-rc2
- remove iio_device code from driver and keep only the trigger part

version 6:
- rename stm32-gptimer in stm32-timers.
- change "st,stm32-gptimer" compatible to "st,stm32-timers".
- modify "st,breakinput" parameter in pwm part.
- split DT patch in 2

version 5:
- fix comments done on version 4
- rebased on kernel 4.9-rc8
- change nodes names and re-order then by addresses

version 4:
- fix comments done on version 3
- don't use interrupts anymore in IIO timer
- detect hardware capabilities at probe time to simplify binding

version 3:
- no change on mfd and pwm divers patches
- add cross reference between bindings
- change compatible to "st,stm32-timer-trigger"
- fix attributes access rights
- use string instead of int for master_mode and slave_mode
- document device attributes in sysfs-bus-iio-timer-stm32
- update DT with the new compatible

version 2:
- keep only one compatible per driver
- use DT parameters to describe hardware block configuration:
  - pwm channels, complementary output, counter size, break input
  - triggers accepted and create by IIO timers
- change DT to limite use of reference to the node
- interrupt is now in IIO timer driver
- rename stm32-mfd-timer to stm32-timers (for general purpose timer)

The following patches enable PWM and IIO Timer features for STM32 platforms.

Those two features are mixed into the registers of the same hardware block
(named general purpose timer) which lead to introduce a multifunctions driver 
on the top of them to be able to share the registers.

In STM32f4 14 instances of timer hardware block exist, even if they all have
the same register mapping they could have a different number of pwm channels
and/or different triggers capabilities. We use various parameters in DT to 
describe the differences between hardware blocks

The MFD (stm32-timers.c) takes care of clock and register mapping
by using regmap. stm32_timers structure is provided to its sub-node to
share those information.

PWM driver is implemented into pwm-stm32.c. Depending of the instance we may
have up to 4 channels, sometime with complementary outputs or 32 bits counter
instead of 16 bits. Some hardware blocks may also have a break input function
which allows to stop pwm depending of a level, defined in devicetree, on an
external pin.

IIO timer driver (stm32-timer-trigger.c and stm32-timer-trigger.h) define a list
of hardware triggers usable by hardware blocks like ADC, DAC or other timers. 

The matrix of possible connections between blocks is quite complex so we use 
trigger names and is_stm32_iio_timer_trigger() function to be sure that
triggers are valid and configure the IPs.

At run time IIO timer hardware blocks can configure (through "master_mode" 
IIO device attribute) which internal signal (counter enable, reset,
comparison block, etc...) is used to generate the trigger.

Benjamin Gaignard (8):
  MFD: add bindings for STM32 Timers driver
  MFD: add STM32 Timers driver
  dt-bindings: pwm: Add STM32 bindings
  pwm: add driver for STM32 plaftorm
  IIO: add bindings for STM32 timer trigger driver
  IIO: add STM32 timer trigger driver
  ARM: dts: stm32: add Timers driver for stm32f429 MCU
  ARM: dts: stm32: Enable pwm1 and pwm3 for stm32f469-disco

 .../ABI/testing/sysfs-bus-iio-timer-stm32          |  29 ++
 .../bindings/iio/timer/stm32-timer-trigger.txt     |  23 ++
 .../devicetree/bindings/mfd/stm32-timers.txt       |  46 +++
 .../devicetree/bindings/pwm/pwm-stm32.txt          |  35 ++
 arch/arm/boot/dts/stm32f429.dtsi                   | 275 ++++++++++++++
 arch/arm/boot/dts/stm32f469-disco.dts              |  28 ++
 drivers/iio/trigger/Kconfig                        |   9 +
 drivers/iio/trigger/Makefile                       |   1 +
 drivers/iio/trigger/stm32-timer-trigger.c          | 342 ++++++++++++++++++
 drivers/mfd/Kconfig                                |  11 +
 drivers/mfd/Makefile                               |   2 +
 drivers/mfd/stm32-timers.c                         |  80 +++++
 drivers/pwm/Kconfig                                |   9 +
 drivers/pwm/Makefile                               |   1 +
 drivers/pwm/pwm-stm32.c                            | 398 +++++++++++++++++++++
 include/linux/iio/timer/stm32-timer-trigger.h      |  62 ++++
 include/linux/mfd/stm32-timers.h                   |  71 ++++
 17 files changed, 1422 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-timer-stm32
 create mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/stm32-timers.txt
 create mode 100644 Documentation/devicetree/bindings/pwm/pwm-stm32.txt
 create mode 100644 drivers/iio/trigger/stm32-timer-trigger.c
 create mode 100644 drivers/mfd/stm32-timers.c
 create mode 100644 drivers/pwm/pwm-stm32.c
 create mode 100644 include/linux/iio/timer/stm32-timer-trigger.h
 create mode 100644 include/linux/mfd/stm32-timers.h

-- 
1.9.1

Comments

Lee Jones Jan. 23, 2017, 12:12 p.m. | #1
Arm, IIO and PWM Maintainers,

Enjoy!

The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77:

  Linux 4.10-rc1 (2016-12-25 16:13:08 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-arm-iio-pwm-v4.10

for you to fetch changes up to 94df449273475980a39f1bf47f1e3d2b07ce6577:

  ARM: dts: stm32: Enable pwm1 and pwm3 for stm32f469-disco (2017-01-23 12:06:28 +0000)

----------------------------------------------------------------
Immutable branch between MFD, ARM, IIO and PWM due for the v4.10 merge window

----------------------------------------------------------------
Benjamin Gaignard (8):
      dt-bindings: mfd: Add bindings for STM32 Timers driver
      mfd: Add STM32 Timers driver
      dt-bindings: pwm: Add STM32 bindings
      pwm: Add driver for STM32 plaftorm
      iio: Add bindings for STM32 timer trigger driver
      iio: Add STM32 timer trigger driver
      ARM: dts: stm32: add Timers driver for stm32f429 MCU
      ARM: dts: stm32: Enable pwm1 and pwm3 for stm32f469-disco

 .../ABI/testing/sysfs-bus-iio-timer-stm32          |  29 ++
 .../bindings/iio/timer/stm32-timer-trigger.txt     |  23 ++
 .../devicetree/bindings/mfd/stm32-timers.txt       |  46 +++
 .../devicetree/bindings/pwm/pwm-stm32.txt          |  35 ++
 arch/arm/boot/dts/stm32f429.dtsi                   | 275 ++++++++++++++
 arch/arm/boot/dts/stm32f469-disco.dts              |  28 ++
 drivers/iio/trigger/Kconfig                        |   9 +
 drivers/iio/trigger/Makefile                       |   1 +
 drivers/iio/trigger/stm32-timer-trigger.c          | 342 ++++++++++++++++++
 drivers/mfd/Kconfig                                |  11 +
 drivers/mfd/Makefile                               |   2 +
 drivers/mfd/stm32-timers.c                         |  80 +++++
 drivers/pwm/Kconfig                                |   9 +
 drivers/pwm/Makefile                               |   1 +
 drivers/pwm/pwm-stm32.c                            | 398 +++++++++++++++++++++
 include/linux/iio/timer/stm32-timer-trigger.h      |  62 ++++
 include/linux/mfd/stm32-timers.h                   |  71 ++++
 17 files changed, 1422 insertions(+)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-timer-stm32
 create mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt
 create mode 100644 Documentation/devicetree/bindings/mfd/stm32-timers.txt
 create mode 100644 Documentation/devicetree/bindings/pwm/pwm-stm32.txt
 create mode 100644 drivers/iio/trigger/stm32-timer-trigger.c
 create mode 100644 drivers/mfd/stm32-timers.c
 create mode 100644 drivers/pwm/pwm-stm32.c
 create mode 100644 include/linux/iio/timer/stm32-timer-trigger.h
 create mode 100644 include/linux/mfd/stm32-timers.h

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Lee Jones Jan. 24, 2017, 8:12 a.m. | #2
On Mon, 23 Jan 2017, Olof Johansson wrote:
> On Mon, Jan 23, 2017 at 4:12 AM, Lee Jones <lee.jones@linaro.org> wrote:

> > Arm, IIO and PWM Maintainers,

> >

> > Enjoy!

> >

> > The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77:

> >

> >   Linux 4.10-rc1 (2016-12-25 16:13:08 -0800)

> >

> > are available in the git repository at:

> >

> >   git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-arm-iio-pwm-v4.10

> >

> > for you to fetch changes up to 94df449273475980a39f1bf47f1e3d2b07ce6577:

> >

> >   ARM: dts: stm32: Enable pwm1 and pwm3 for stm32f469-disco (2017-01-23 12:06:28 +0000)

> >

> > ----------------------------------------------------------------

> > Immutable branch between MFD, ARM, IIO and PWM due for the v4.10 merge window

> >

> > ----------------------------------------------------------------

> > Benjamin Gaignard (8):

> >       dt-bindings: mfd: Add bindings for STM32 Timers driver

> >       mfd: Add STM32 Timers driver

> >       dt-bindings: pwm: Add STM32 bindings

> >       pwm: Add driver for STM32 plaftorm

> >       iio: Add bindings for STM32 timer trigger driver

> >       iio: Add STM32 timer trigger driver

> >       ARM: dts: stm32: add Timers driver for stm32f429 MCU

> >       ARM: dts: stm32: Enable pwm1 and pwm3 for stm32f469-disco

> >

> >  .../ABI/testing/sysfs-bus-iio-timer-stm32          |  29 ++

> >  .../bindings/iio/timer/stm32-timer-trigger.txt     |  23 ++

> >  .../devicetree/bindings/mfd/stm32-timers.txt       |  46 +++

> >  .../devicetree/bindings/pwm/pwm-stm32.txt          |  35 ++

> >  arch/arm/boot/dts/stm32f429.dtsi                   | 275 ++++++++++++++

> >  arch/arm/boot/dts/stm32f469-disco.dts              |  28 ++

> >  drivers/iio/trigger/Kconfig                        |   9 +

> >  drivers/iio/trigger/Makefile                       |   1 +

> >  drivers/iio/trigger/stm32-timer-trigger.c          | 342 ++++++++++++++++++

> >  drivers/mfd/Kconfig                                |  11 +

> >  drivers/mfd/Makefile                               |   2 +

> >  drivers/mfd/stm32-timers.c                         |  80 +++++

> >  drivers/pwm/Kconfig                                |   9 +

> >  drivers/pwm/Makefile                               |   1 +

> >  drivers/pwm/pwm-stm32.c                            | 398 +++++++++++++++++++++

> >  include/linux/iio/timer/stm32-timer-trigger.h      |  62 ++++

> >  include/linux/mfd/stm32-timers.h                   |  71 ++++

> >  17 files changed, 1422 insertions(+)

> >  create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-timer-stm32

> >  create mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt

> >  create mode 100644 Documentation/devicetree/bindings/mfd/stm32-timers.txt

> >  create mode 100644 Documentation/devicetree/bindings/pwm/pwm-stm32.txt

> >  create mode 100644 drivers/iio/trigger/stm32-timer-trigger.c

> >  create mode 100644 drivers/mfd/stm32-timers.c

> >  create mode 100644 drivers/pwm/pwm-stm32.c

> >  create mode 100644 include/linux/iio/timer/stm32-timer-trigger.h

> >  create mode 100644 include/linux/mfd/stm32-timers.h

> 

> May I ask why you're creating an immutable branch of all this contents?

> 

> We should get the dts/dtsi contents like usual from any maintainer;

> just the DT updates in a branch.

> 

> Sometimes (but less and less due to us discouraging the use) we need

> an immutable branch that includes dt-include updates. But I don't see

> any of those in this contents.

> 

> I.e. I guess I can see the need between mfd and downstream trees

> (iio/pwm), but not the DTS contents at this time. Or am I missing

> something here?


I agree with you.  However, since one of the STM32 Maintainers Acked
the DTS patches, and the other one hasn't been heard from for months,
I took that to mean he wanted me to apply and take them through the
MFD tree.

A misunderstanding or misaction perhaps, but this is the normal
assumption.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Olof Johansson Jan. 24, 2017, 7:54 p.m. | #3
On Tue, Jan 24, 2017 at 12:12 AM, Lee Jones <lee.jones@linaro.org> wrote:
> On Mon, 23 Jan 2017, Olof Johansson wrote:

>> On Mon, Jan 23, 2017 at 4:12 AM, Lee Jones <lee.jones@linaro.org> wrote:

>> > Arm, IIO and PWM Maintainers,

>> >

>> > Enjoy!

>> >

>> > The following changes since commit 7ce7d89f48834cefece7804d38fc5d85382edf77:

>> >

>> >   Linux 4.10-rc1 (2016-12-25 16:13:08 -0800)

>> >

>> > are available in the git repository at:

>> >

>> >   git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-arm-iio-pwm-v4.10

>> >

>> > for you to fetch changes up to 94df449273475980a39f1bf47f1e3d2b07ce6577:

>> >

>> >   ARM: dts: stm32: Enable pwm1 and pwm3 for stm32f469-disco (2017-01-23 12:06:28 +0000)

>> >

>> > ----------------------------------------------------------------

>> > Immutable branch between MFD, ARM, IIO and PWM due for the v4.10 merge window

>> >

>> > ----------------------------------------------------------------

>> > Benjamin Gaignard (8):

>> >       dt-bindings: mfd: Add bindings for STM32 Timers driver

>> >       mfd: Add STM32 Timers driver

>> >       dt-bindings: pwm: Add STM32 bindings

>> >       pwm: Add driver for STM32 plaftorm

>> >       iio: Add bindings for STM32 timer trigger driver

>> >       iio: Add STM32 timer trigger driver

>> >       ARM: dts: stm32: add Timers driver for stm32f429 MCU

>> >       ARM: dts: stm32: Enable pwm1 and pwm3 for stm32f469-disco

>> >

>> >  .../ABI/testing/sysfs-bus-iio-timer-stm32          |  29 ++

>> >  .../bindings/iio/timer/stm32-timer-trigger.txt     |  23 ++

>> >  .../devicetree/bindings/mfd/stm32-timers.txt       |  46 +++

>> >  .../devicetree/bindings/pwm/pwm-stm32.txt          |  35 ++

>> >  arch/arm/boot/dts/stm32f429.dtsi                   | 275 ++++++++++++++

>> >  arch/arm/boot/dts/stm32f469-disco.dts              |  28 ++

>> >  drivers/iio/trigger/Kconfig                        |   9 +

>> >  drivers/iio/trigger/Makefile                       |   1 +

>> >  drivers/iio/trigger/stm32-timer-trigger.c          | 342 ++++++++++++++++++

>> >  drivers/mfd/Kconfig                                |  11 +

>> >  drivers/mfd/Makefile                               |   2 +

>> >  drivers/mfd/stm32-timers.c                         |  80 +++++

>> >  drivers/pwm/Kconfig                                |   9 +

>> >  drivers/pwm/Makefile                               |   1 +

>> >  drivers/pwm/pwm-stm32.c                            | 398 +++++++++++++++++++++

>> >  include/linux/iio/timer/stm32-timer-trigger.h      |  62 ++++

>> >  include/linux/mfd/stm32-timers.h                   |  71 ++++

>> >  17 files changed, 1422 insertions(+)

>> >  create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-timer-stm32

>> >  create mode 100644 Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt

>> >  create mode 100644 Documentation/devicetree/bindings/mfd/stm32-timers.txt

>> >  create mode 100644 Documentation/devicetree/bindings/pwm/pwm-stm32.txt

>> >  create mode 100644 drivers/iio/trigger/stm32-timer-trigger.c

>> >  create mode 100644 drivers/mfd/stm32-timers.c

>> >  create mode 100644 drivers/pwm/pwm-stm32.c

>> >  create mode 100644 include/linux/iio/timer/stm32-timer-trigger.h

>> >  create mode 100644 include/linux/mfd/stm32-timers.h

>>

>> May I ask why you're creating an immutable branch of all this contents?

>>

>> We should get the dts/dtsi contents like usual from any maintainer;

>> just the DT updates in a branch.

>>

>> Sometimes (but less and less due to us discouraging the use) we need

>> an immutable branch that includes dt-include updates. But I don't see

>> any of those in this contents.

>>

>> I.e. I guess I can see the need between mfd and downstream trees

>> (iio/pwm), but not the DTS contents at this time. Or am I missing

>> something here?

>

> I agree with you.  However, since one of the STM32 Maintainers Acked

> the DTS patches, and the other one hasn't been heard from for months,

> I took that to mean he wanted me to apply and take them through the

> MFD tree.

>

> A misunderstanding or misaction perhaps, but this is the normal

> assumption.


It seems to be a misunderstanding in this case, since there are other
additions in the stm32 tree this release cycle so we should only pick
up DTS changes through our tree.

By now, I think it should be pretty well known that we nearly never
want DTS contents merged through any other tree. Ever.

So, please revoke your branch and take those out. We'll take them
through the normal flow. Thanks!


-Olof
Jonathan Cameron Jan. 25, 2017, 6:23 p.m. | #4
On 25 January 2017 10:08:58 GMT+00:00, Lee Jones <lee.jones@linaro.org> wrote:
>Jonathan, Thierry,

>

>On Tue, 24 Jan 2017, Olof Johansson wrote:

>> On Tue, Jan 24, 2017 at 12:12 AM, Lee Jones <lee.jones@linaro.org>

>wrote:

>> > On Mon, 23 Jan 2017, Olof Johansson wrote:

>> >> On Mon, Jan 23, 2017 at 4:12 AM, Lee Jones <lee.jones@linaro.org>

>wrote:

>> >> > Arm, IIO and PWM Maintainers,

>> >> >

>> >> > Enjoy!

>> >> >

>> >> > The following changes since commit

>7ce7d89f48834cefece7804d38fc5d85382edf77:

>> >> >

>> >> >   Linux 4.10-rc1 (2016-12-25 16:13:08 -0800)

>> >> >

>> >> > are available in the git repository at:

>> >> >

>> >> >   git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git

>ib-mfd-arm-iio-pwm-v4.10

>> >> >

>> >> > for you to fetch changes up to

>94df449273475980a39f1bf47f1e3d2b07ce6577:

>> >> >

>> >> >   ARM: dts: stm32: Enable pwm1 and pwm3 for stm32f469-disco

>(2017-01-23 12:06:28 +0000)

>> >> >

>> >> > ----------------------------------------------------------------

>> >> > Immutable branch between MFD, ARM, IIO and PWM due for the v4.10

>merge window

>> >> >

>> >> > ----------------------------------------------------------------

>> >> > Benjamin Gaignard (8):

>> >> >       dt-bindings: mfd: Add bindings for STM32 Timers driver

>> >> >       mfd: Add STM32 Timers driver

>> >> >       dt-bindings: pwm: Add STM32 bindings

>> >> >       pwm: Add driver for STM32 plaftorm

>> >> >       iio: Add bindings for STM32 timer trigger driver

>> >> >       iio: Add STM32 timer trigger driver

>> >> >       ARM: dts: stm32: add Timers driver for stm32f429 MCU

>> >> >       ARM: dts: stm32: Enable pwm1 and pwm3 for stm32f469-disco

>> >> >

>> >> >  .../ABI/testing/sysfs-bus-iio-timer-stm32          |  29 ++

>> >> >  .../bindings/iio/timer/stm32-timer-trigger.txt     |  23 ++

>> >> >  .../devicetree/bindings/mfd/stm32-timers.txt       |  46 +++

>> >> >  .../devicetree/bindings/pwm/pwm-stm32.txt          |  35 ++

>> >> >  arch/arm/boot/dts/stm32f429.dtsi                   | 275

>++++++++++++++

>> >> >  arch/arm/boot/dts/stm32f469-disco.dts              |  28 ++

>> >> >  drivers/iio/trigger/Kconfig                        |   9 +

>> >> >  drivers/iio/trigger/Makefile                       |   1 +

>> >> >  drivers/iio/trigger/stm32-timer-trigger.c          | 342

>++++++++++++++++++

>> >> >  drivers/mfd/Kconfig                                |  11 +

>> >> >  drivers/mfd/Makefile                               |   2 +

>> >> >  drivers/mfd/stm32-timers.c                         |  80 +++++

>> >> >  drivers/pwm/Kconfig                                |   9 +

>> >> >  drivers/pwm/Makefile                               |   1 +

>> >> >  drivers/pwm/pwm-stm32.c                            | 398

>+++++++++++++++++++++

>> >> >  include/linux/iio/timer/stm32-timer-trigger.h      |  62 ++++

>> >> >  include/linux/mfd/stm32-timers.h                   |  71 ++++

>> >> >  17 files changed, 1422 insertions(+)

>> >> >  create mode 100644

>Documentation/ABI/testing/sysfs-bus-iio-timer-stm32

>> >> >  create mode 100644

>Documentation/devicetree/bindings/iio/timer/stm32-timer-trigger.txt

>> >> >  create mode 100644

>Documentation/devicetree/bindings/mfd/stm32-timers.txt

>> >> >  create mode 100644

>Documentation/devicetree/bindings/pwm/pwm-stm32.txt

>> >> >  create mode 100644 drivers/iio/trigger/stm32-timer-trigger.c

>> >> >  create mode 100644 drivers/mfd/stm32-timers.c

>> >> >  create mode 100644 drivers/pwm/pwm-stm32.c

>> >> >  create mode 100644

>include/linux/iio/timer/stm32-timer-trigger.h

>> >> >  create mode 100644 include/linux/mfd/stm32-timers.h

>> >>

>> >> May I ask why you're creating an immutable branch of all this

>contents?

>> >>

>> >> We should get the dts/dtsi contents like usual from any

>maintainer;

>> >> just the DT updates in a branch.

>> >>

>> >> Sometimes (but less and less due to us discouraging the use) we

>need

>> >> an immutable branch that includes dt-include updates. But I don't

>see

>> >> any of those in this contents.

>> >>

>> >> I.e. I guess I can see the need between mfd and downstream trees

>> >> (iio/pwm), but not the DTS contents at this time. Or am I missing

>> >> something here?

>> >

>> > I agree with you.  However, since one of the STM32 Maintainers

>Acked

>> > the DTS patches, and the other one hasn't been heard from for

>months,

>> > I took that to mean he wanted me to apply and take them through the

>> > MFD tree.

>> >

>> > A misunderstanding or misaction perhaps, but this is the normal

>> > assumption.

>> 

>> It seems to be a misunderstanding in this case, since there are other

>> additions in the stm32 tree this release cycle so we should only pick

>> up DTS changes through our tree.

>> 

>> By now, I think it should be pretty well known that we nearly never

>> want DTS contents merged through any other tree. Ever.

>> 

>> So, please revoke your branch and take those out. We'll take them

>> through the normal flow. Thanks!

>

>That okay with you?

Bit late from me but fine. I tend to only pull in these branches when stuff to go on top turns up.
Not happened with this set yet!


J

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.