[00/10] Packet function inline

Message ID	1486384684-14761-1-git-send-email-petri.savolainen@linaro.org
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org designates 54.225.227.206 as permitted sender) client-ip=54.225.227.206; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning linaro.org discourages use of 131.228.2.36 as permitted sender) From: Petri Savolainen <petri.savolainen@linaro.org> To: <lng-odp@lists.linaro.org> Date: Mon, 6 Feb 2017 14:37:54 +0200 Message-ID: <1486384684-14761-1-git-send-email-petri.savolainen@linaro.org> MIME-Version: 1.0 Content-Type: text/plain SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; HE1PR07MB1625; 7:k7OjtkylmL/JCS7BOjuzcIYL/Ow/WeVQmslXtKyrWvjxUozvAuaiszsXn2o2O2ziZrFcRBA4jXGh8MvnipTMMWaW7DFRyfPnpzU3OpJ9uC6V2v7ES6PUduA0sPjYLh1ZNatTVekIg7Www482GN7juV0A231DrdMOe28V3xb3a5316hUNbf1q3uNkyos7fQdeEW/e66u/Opoa3zgNJCewGbdg4cgGzm/1V/NshDtfCoMDIap+EDCxyX/pNxZ3PyKEl0xUBvORMmTKyOI7b3dezzkguriMUBeghjpP3Dob3maQyYtsrrj+4evpE9sIEfAc2unbfyk6ZOUuKI4tmQ8TUkKLwLxuibqxbyHadrUENRTEg1o9rLCaiEaqddQjuSrnbEHzfOn5TNPYd9SvvSn0J1s4HqLXbcfjyKN1W/SDhScyepPvXdgrxpYSQQJ1hzN3vO2HdDjt5vplYVYOJp+jHdmy+xt/fomnv4CIyURNjloq9lXvYx4iGplSCV71SZKDMuc+icAa/O2jV74xnfv7KQ== Subject: [lng-odp] [PATCH 00/10] Packet function inline Precedence: list Errors-To: lng-odp-bounces@lists.linaro.org Sender: "lng-odp" <lng-odp-bounces@lists.linaro.org>
Series	Packet function inline \| expand [00/10] Packet function inline [01/10] linux-gen: inline: rename _STATIC to _ODP_INLINE [02/10] linux-gen: ticketlock: inline also in application [03/10] linux-gen: packet: packet handle is hdr pointer [04/10] test: l2fwd: add pktio driver print out [05/10] validation: packet: print reason for suite init failure [06/10] test: generator: various improvements [07/10] test: l2fwd script: limit number of generator cpus [08/10] test: l2fwd: use packet_data [09/10] linux-gen: packet: inline functions [10/10] linux-gen: packet: inline flag functions

Message ID

1486384684-14761-1-git-send-email-petri.savolainen@linaro.org

Headers

Received-SPF: pass (google.com: domain of lng-odp-bounces@lists.linaro.org
	designates 54.225.227.206 as permitted sender)
	client-ip=54.225.227.206; 
Received-SPF: SoftFail (protection.outlook.com: domain of transitioning
	linaro.org discourages use of 131.228.2.36 as permitted sender)
From: Petri Savolainen <petri.savolainen@linaro.org>
To: <lng-odp@lists.linaro.org>
Date: Mon, 6 Feb 2017 14:37:54 +0200
Message-ID: <1486384684-14761-1-git-send-email-petri.savolainen@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2017 12:38:25.8957
	(UTC)
X-MS-Exchange-CrossTenant-Id: 5d471751-9675-428d-917b-70f44f9630b0
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5d471751-9675-428d-917b-70f44f9630b0;
	Ip=[131.228.2.36]; 
	Helo=[hybrid2.ext.net.nokia.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB1625
Subject: [lng-odp] [PATCH 00/10] Packet function inline
X-BeenThere: lng-odp@lists.linaro.org
X-Mailman-Version: 2.1.16
Precedence: list
List-Id: "The OpenDataPlane \(ODP\) List" <lng-odp.lists.linaro.org>
List-Unsubscribe: <https://lists.linaro.org/mailman/options/lng-odp>,
	<mailto:lng-odp-request@lists.linaro.org?subject=unsubscribe>
List-Archive: <http://lists.linaro.org/pipermail/lng-odp/>
List-Post: <mailto:lng-odp@lists.linaro.org>
List-Help: <mailto:lng-odp-request@lists.linaro.org?subject=help>
List-Subscribe: <https://lists.linaro.org/mailman/listinfo/lng-odp>,
	<mailto:lng-odp-request@lists.linaro.org?subject=subscribe>
Errors-To: lng-odp-bounces@lists.linaro.org
Sender: "lng-odp" <lng-odp-bounces@lists.linaro.org>

Series

Packet function inline | expand

Message

Petri Savolainen Feb. 6, 2017, 12:37 p.m. UTC

First set of packet and packet flag functions are inlined. Inline functions are
used (can be used) internally always, but are exposed through API only when 
builing for non-ABI compatibility.

Packet handle value is changed from index(es) to a packet header pointer. 
Packet/buffer header structure or other internal types are not exposed to 
applications, but offsets to header fields are used instead.

Ticketlock inlining was changed to the same file structure, which allows now 
also application to use inlined functions.

Performance is improved significantly on both packet microbench 
(e.g. odp_packet_len() from 9 to 4 cycles per call) and l2fwd 
(packet rate +20%).


Petri Savolainen (10):
  linux-gen: inline: rename _STATIC to _ODP_INLINE
  linux-gen: ticketlock: inline also in application
  linux-gen: packet: packet handle is hdr pointer
  test: l2fwd: add pktio driver print out
  validation: packet: print reason for suite init failure
  test: generator: various improvements
  test: l2fwd script: limit number of generator cpus
  test: l2fwd: use packet_data
  linux-gen: packet: inline functions
  linux-gen: packet: inline flag functions

 example/generator/odp_generator.c                  |  77 ++++--
 platform/linux-generic/Makefile.am                 |   5 +
 platform/linux-generic/include/odp/api/packet.h    |  11 +-
 .../linux-generic/include/odp/api/packet_flags.h   |  11 +-
 .../include/odp/api/plat/atomic_inlines.h          | 114 +++++----
 .../include/odp/api/plat/byteorder_inlines.h       |  24 +-
 .../include/odp/api/plat/packet_flag_inlines.h     |  90 +++++++
 .../include/odp/api/plat/packet_flag_inlines_api.h |  41 +++
 .../include/odp/api/plat/packet_inlines.h          | 173 +++++++++++++
 .../include/odp/api/plat/packet_inlines_api.h      | 113 +++++++++
 .../include/odp/api/plat/packet_types.h            |  87 ++++++-
 .../include/odp/api/plat/static_inline.h.in        |   8 +-
 .../include/odp/api/plat/std_clib_inlines.h        |   6 +-
 .../include/odp/api/plat/sync_inlines.h            |   6 +-
 .../include/odp/api/plat/ticketlock_inlines.h      |  19 +-
 .../include/odp/api/plat/ticketlock_inlines_api.h  |  36 +++
 .../linux-generic/include/odp/api/ticketlock.h     |   4 +
 .../linux-generic/include/odp_packet_internal.h    |  57 +----
 platform/linux-generic/odp_packet.c                | 278 ++++++++-------------
 platform/linux-generic/odp_packet_flags.c          |  41 +--
 platform/linux-generic/odp_ticketlock.c            |  24 +-
 platform/linux-generic/pktio/dpdk.c                |   5 +-
 platform/linux-generic/pktio/netmap.c              |   5 +-
 test/common_plat/performance/Makefile.am           |   4 +
 test/common_plat/performance/odp_l2fwd.c           |  22 +-
 test/common_plat/performance/odp_l2fwd_run.sh      |  10 +-
 test/common_plat/validation/api/packet/packet.c    |  23 +-
 27 files changed, 877 insertions(+), 417 deletions(-)
 create mode 100644 platform/linux-generic/include/odp/api/plat/packet_flag_inlines.h
 create mode 100644 platform/linux-generic/include/odp/api/plat/packet_flag_inlines_api.h
 create mode 100644 platform/linux-generic/include/odp/api/plat/packet_inlines.h
 create mode 100644 platform/linux-generic/include/odp/api/plat/packet_inlines_api.h
 create mode 100644 platform/linux-generic/include/odp/api/plat/ticketlock_inlines_api.h

-- 
2.8.1