mbox series

[Linaro-uefi,v2,0/4] AMD/Styx: enable strict memory permissions

Message ID 1488294680-1884-1-git-send-email-ard.biesheuvel@linaro.org
Headers show
Series AMD/Styx: enable strict memory permissions | expand

Message

Ard Biesheuvel Feb. 28, 2017, 3:11 p.m. UTC
This cleans up some dodgy code in the SMBIOS driver, after which it is
possible to enable the shiny new memory protection controls.

Changes since v1:
- enable on Cello as well as Overdrive, I will leave it up to Alan whether
  this gets enabled on the Overdrive 1000 as well
- simplify patch #1

Note that the prerequisite EDK2 changes have now been merged.

Ard Biesheuvel (4):
  Platforms/AMD/Styx/PlatformSmbiosDxe: don't write to string literals
  Platforms/AMD/Styx: constify/staticize all local functions and
    variables
  Platforms/AMD/Overdrive: enable strict memory permission policy
  Platforms/AMD/Cello: enable strict memory permission policy

 Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc                     | 16 ++++
 Platforms/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 79 +++++++++++---------
 Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc             | 16 ++++
 3 files changed, 74 insertions(+), 37 deletions(-)

Comments

Alan Ott Feb. 28, 2017, 5:47 p.m. UTC | #1
On 02/28/2017 10:11 AM, Ard Biesheuvel wrote:
> This cleans up some dodgy code in the SMBIOS driver, after which it is
> possible to enable the shiny new memory protection controls.
>
> Changes since v1:
> - enable on Cello as well as Overdrive, I will leave it up to Alan whether
>    this gets enabled on the Overdrive 1000 as well
> - simplify patch #1
>
> Note that the prerequisite EDK2 changes have now been merged.

I think this all looks great. Thanks for your work on it. I'll have a 
test on the OverDrive 1000 too.

> Ard Biesheuvel (4):
>    Platforms/AMD/Styx/PlatformSmbiosDxe: don't write to string literals
>    Platforms/AMD/Styx: constify/staticize all local functions and
>      variables
>    Platforms/AMD/Overdrive: enable strict memory permission policy
>    Platforms/AMD/Cello: enable strict memory permission policy
>
>   Platforms/AMD/Styx/CelloBoard/CelloBoard.dsc                     | 16 ++++
>   Platforms/AMD/Styx/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 79 +++++++++++---------
>   Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc             | 16 ++++
>   3 files changed, 74 insertions(+), 37 deletions(-)
>