| Message ID | 1490191448-22398-1-git-send-email-ard.biesheuvel@linaro.org |
|---|---|
| Headers | show |
| Series | Shell/Quark/ArmPkg: promote shell app FILE_GUID to proper GUID | expand |
On 22 March 2017 at 14:04, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote: > To avoid the need for open coded GUID declarations that copy the FILE_GUID > of the Shell app, add it to ShellPkg.dec and replace existing references. > Thanks all I went ahead and pushed 2edc20c46863 ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to package 07548e17c5ff ArmPkg/PlatformBootManagerLib: refer to Shell FILE_GUID directly c81c2c0fc453 ArmVirtPkg/ArmVirtQemu: refer to Shell app via its declared GUID because I have some stuff queued up that depends on it. > Ard Biesheuvel (4): > ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to > package > QuarkPlatformPkg/PlatformBootManagerLib: use new UefiShellFileGuid > definition > ArmPkg/PlatformBootManagerLib: refer to Shell FILE_GUID directly > ArmVirtPkg/ArmVirtQemu: refer to Shell app via its declared GUID > > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 5 ++--- > ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 3 ++- > ArmVirtPkg/ArmVirtQemu.dsc | 1 - > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 - > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 6 +++--- > QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c | 4 +--- > QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 2 ++ > ShellPkg/ShellPkg.dec | 3 +++ > 9 files changed, 14 insertions(+), 13 deletions(-) > > -- > 2.7.4 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
> -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Wednesday, March 22, 2017 8:38 AM > To: edk2-devel@lists.01.org; Leif Lindholm <leif.lindholm@linaro.org>; Laszlo > Ersek <lersek@redhat.com>; Carsey, Jaben <jaben.carsey@intel.com>; Ni, > Ruiyu <ruiyu.ni@intel.com>; Kinney, Michael D > <michael.d.kinney@intel.com>; Steele, Kelly <kelly.steele@intel.com> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Subject: Re: [edk2] [PATCH 0/4] Shell/Quark/ArmPkg: promote shell app > FILE_GUID to proper GUID > Importance: High > > On 22 March 2017 at 14:04, Ard Biesheuvel <ard.biesheuvel@linaro.org> > wrote: > > To avoid the need for open coded GUID declarations that copy the > FILE_GUID > > of the Shell app, add it to ShellPkg.dec and replace existing references. > > > > Thanks all > > I went ahead and pushed I was hoping you would since it was involved in the series. :) > > 2edc20c46863 ShellPkg: add GUID declaration for FILE_GUID of UEFI > Shell app to package > 07548e17c5ff ArmPkg/PlatformBootManagerLib: refer to Shell FILE_GUID > directly > c81c2c0fc453 ArmVirtPkg/ArmVirtQemu: refer to Shell app via its declared > GUID > > because I have some stuff queued up that depends on it. > > > > Ard Biesheuvel (4): > > ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to > > package > > QuarkPlatformPkg/PlatformBootManagerLib: use new UefiShellFileGuid > > definition > > ArmPkg/PlatformBootManagerLib: refer to Shell FILE_GUID directly > > ArmVirtPkg/ArmVirtQemu: refer to Shell app via its declared GUID > > > > ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 5 > ++--- > > ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > | 3 ++- > > ArmVirtPkg/ArmVirtQemu.dsc | 1 - > > ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 - > > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 > +- > > > ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > | 6 +++--- > > > QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager. > c | 4 +--- > > > QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerL > ib.inf | 2 ++ > > ShellPkg/ShellPkg.dec | 3 +++ > > 9 files changed, 14 insertions(+), 13 deletions(-) > > > > -- > > 2.7.4 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
To avoid the need for open coded GUID declarations that copy the FILE_GUID of the Shell app, add it to ShellPkg.dec and replace existing references. Ard Biesheuvel (4): ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to package QuarkPlatformPkg/PlatformBootManagerLib: use new UefiShellFileGuid definition ArmPkg/PlatformBootManagerLib: refer to Shell FILE_GUID directly ArmVirtPkg/ArmVirtQemu: refer to Shell app via its declared GUID ArmPkg/Library/PlatformBootManagerLib/PlatformBm.c | 5 ++--- ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 3 ++- ArmVirtPkg/ArmVirtQemu.dsc | 1 - ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 - ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 6 +++--- QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c | 4 +--- QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf | 2 ++ ShellPkg/ShellPkg.dec | 3 +++ 9 files changed, 14 insertions(+), 13 deletions(-) -- 2.7.4 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel