From patchwork Wed May 17 14:52:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 100001 Delivered-To: patch@linaro.org Received: by 10.182.142.97 with SMTP id rv1csp254689obb; Wed, 17 May 2017 07:55:22 -0700 (PDT) X-Received: by 10.55.18.141 with SMTP id 13mr3692638qks.135.1495032922150; Wed, 17 May 2017 07:55:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1495032922; cv=none; d=google.com; s=arc-20160816; b=Jy7gOqyRkY1SD9ExdsIEmHk7u/E0gLyRp+9rpjTGGUH+QgSRoAJfcuINUaFSAH5rdw JM4fm2UpvRI8/3NMRutv25qJHm6Y51Agd/MRhPL0t1uDznmZUsGHlL1xZWTvKEaapRIz Cfc3DbDln7Z6UMIcEE3k46F8JR+9ZXUMnjJe0UxOuYDCjJ1js3zB/z568gOXuxqhzKOf Podh88eRgZzDhYvFTJNs9qWxxHu3k0cMALA4C//QKWsoUITO83flj6iUNzhya/JpO5HR JI++i153Sa3cIj/F/dgKN4FKnDQGZOGahUoQv6wefSNxsNDJrKwEN2kHAy2MkMhY+AP3 5LRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=qOkG1Gzi7LEm5JRwN5qbVc+hJqe9ViKx3y1dYHKPk6Y=; b=TlHbsLLRpGJKtgZ9nRCtp+G1X7dACjda8kLckAJQDhfFfOr/T0lxct+MfpRaZFYW9d S5/rKnYUhBe0Gyy9KA1gGqxtjQcsFOGzrZ4IfsQPNHFIL0YPKHOC+Dut935TSoBn/NAw le4vN92eE46OJH3kQNGKqbEWdzE0TXMfgGHHEd1dAZ8OG3N2F/H+/zQc4eMygcCR6pfU KQFRroIXVupdiWo5rWKIbgRYxygP/M9O/13iiMPhshvFJkLOk+Y3BMVCYJ64SECFvRXd MCgdtYHtyebjysttJmi78/RC2xwgK8p3ZqBBgaGYNWTdKKonBPSNuSAlPYEN9r4HBIBh S8XQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id i31si2394681qtc.198.2017.05.17.07.55.22 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 17 May 2017 07:55:22 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:49383 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dB0MD-0003zH-Mu for patch@linaro.org; Wed, 17 May 2017 10:55:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dB0J9-0001lW-9q for qemu-devel@nongnu.org; Wed, 17 May 2017 10:52:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dB0J8-0004fT-4Q for qemu-devel@nongnu.org; Wed, 17 May 2017 10:52:11 -0400 Received: from mail-wr0-x232.google.com ([2a00:1450:400c:c0c::232]:33486) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dB0J7-0004f6-VL for qemu-devel@nongnu.org; Wed, 17 May 2017 10:52:10 -0400 Received: by mail-wr0-x232.google.com with SMTP id w50so12426487wrc.0 for ; Wed, 17 May 2017 07:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qOkG1Gzi7LEm5JRwN5qbVc+hJqe9ViKx3y1dYHKPk6Y=; b=cTgOLJb0SpLaC031sOPN8VerEzUw/9sPhqQCE+MHzWwF6TpBTTEM8CDfvPGj6awjAO 4GbdHa81+lizK5gg0RhbV0r7lu6hhLHn57LmBDyi+NyS9neecmiuc4KLtilFk0XkNNc5 /fCwP2BeiZPgHKLaayoOQ4FN1m2rADfkNIhG0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qOkG1Gzi7LEm5JRwN5qbVc+hJqe9ViKx3y1dYHKPk6Y=; b=D1T50dy+D0Q5+kRYqb6NVKnagnSNma6HQNjveB1q7BHA7zRiH/aTOBE2bbzqP+u4u4 9Vyy3PlFreXbbE0nBGliZ7Q7lcsfbLWSfAJUcgA86AaGcv6nRBFHK3S/CL4p0rQEdpX5 ZhmVB/Y7QdjHdgqFd2CRXCdjnKiivJzkwsV2rU5ORbTEp5xlVj+fbRsnS6ri+ld/y9am FgfrXgIcWrbCosT9qlihOK56LAcSvZHCdY1sCl2Zg++RCvDeu5fGruyjnT/Pwkon3YgX rSlQh3rwsUcd4QdxCHZLEcRr4HCcEIa32nKHDMw35nMPj0Fpk+QTSavx+tRMPdB+bLsw ejSA== X-Gm-Message-State: AODbwcCryqcUrcY6hwQ5i7JeKf1asIb7F0TVQm6FCSpHR/RJWDrAbWOO 2EEZGfWsyX515HfZ X-Received: by 10.223.163.21 with SMTP id c21mr2476506wrb.38.1495032728850; Wed, 17 May 2017 07:52:08 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id s110sm2759117wrc.5.2017.05.17.07.52.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 May 2017 07:52:04 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id C641B3E087F; Wed, 17 May 2017 15:52:59 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: pbonzini@redhat.com, stefanha@redhat.com Date: Wed, 17 May 2017 15:52:57 +0100 Message-Id: <20170517145259.28979-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170517145259.28979-1-alex.bennee@linaro.org> References: <20170517145259.28979-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::232 Subject: [Qemu-devel] [PATCH v2 4/6] cputlb: remove tlb_flush_count X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , cota@braap.org, =?utf-8?q?Alex_Be?= =?utf-8?b?bm7DqWU=?= , qemu-devel@nongnu.org, Peter Crosthwaite Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Flushing of the CPU TLB is no longer a simple count. The ratio of self-flushes to cross-flushes and if they need to synchronise across vCPUs has more of an impact. To correctly capture this we'll replace the simple count with trace points in a future patch. Signed-off-by: Alex Bennée --- cputlb.c | 4 ---- include/exec/cputlb.h | 1 - translate-all.c | 1 - 3 files changed, 6 deletions(-) -- 2.11.0 diff --git a/cputlb.c b/cputlb.c index f5d056cc08..d1859c3f37 100644 --- a/cputlb.c +++ b/cputlb.c @@ -92,9 +92,6 @@ static void flush_all_helper(CPUState *src, run_on_cpu_func fn, } } -/* statistics */ -int tlb_flush_count; - /* This is OK because CPU architectures generally permit an * implementation to drop entries from the TLB at any time, so * flushing more entries than required is only an efficiency issue, @@ -112,7 +109,6 @@ static void tlb_flush_nocheck(CPUState *cpu) } assert_cpu_is_self(cpu); - tlb_debug("(count: %d)\n", tlb_flush_count++); tb_lock(); diff --git a/include/exec/cputlb.h b/include/exec/cputlb.h index 3f941783c5..dac9901da5 100644 --- a/include/exec/cputlb.h +++ b/include/exec/cputlb.h @@ -23,7 +23,6 @@ /* cputlb.c */ void tlb_protect_code(ram_addr_t ram_addr); void tlb_unprotect_code(ram_addr_t ram_addr); -extern int tlb_flush_count; #endif #endif diff --git a/translate-all.c b/translate-all.c index b3ee876526..eeb3807242 100644 --- a/translate-all.c +++ b/translate-all.c @@ -1927,7 +1927,6 @@ void dump_exec_info(FILE *f, fprintf_function cpu_fprintf) atomic_read(&tcg_ctx.tb_ctx.tb_flush_count)); cpu_fprintf(f, "TB invalidate count %d\n", tcg_ctx.tb_ctx.tb_phys_invalidate_count); - cpu_fprintf(f, "TLB flush count %d\n", tlb_flush_count); tcg_dump_info(f, cpu_fprintf); tb_unlock();