dmaengine: bcm-sba-raid: fix Kconfig dependencies

Message ID 20170518132639.1685053-1-arnd@arndb.de
State New
Headers show

Commit Message

Arnd Bergmann May 18, 2017, 1:25 p.m.
The new driver requires both mailbox and raid support for compile
testing:

drivers/dma/built-in.o: In function `sba_remove':
edma.c:(.text+0x4414): undefined reference to `mbox_free_channel'
drivers/dma/built-in.o: In function `sba_issue_pending':
edma.c:(.text+0x46cc): undefined reference to `mbox_send_message'
drivers/dma/built-in.o: In function `sba_probe':
edma.c:(.text+0x4e60): undefined reference to `mbox_request_channel'
edma.c:(.text+0x5038): undefined reference to `mbox_free_channel'
drivers/dma/built-in.o: In function `sba_tx_status':
edma.c:(.text+0x5210): undefined reference to `mbox_client_peek_data'

drivers/dma/built-in.o: In function `sba_prep_dma_pq_req':
edma.c:(.text+0x5784): undefined reference to `raid6_gflog'
edma.c:(.text+0x5798): undefined reference to `raid6_gflog'

This rearranges the Kconfig dependencies accordingly.

Fixes: 743e1c8ffe4e ("dmaengine: Add Broadcom SBA RAID driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/dma/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.9.0

Comments

Vinod Koul May 19, 2017, 3:20 a.m. | #1
On Thu, May 18, 2017 at 03:25:25PM +0200, Arnd Bergmann wrote:
> The new driver requires both mailbox and raid support for compile

> testing:

> 

> drivers/dma/built-in.o: In function `sba_remove':

> edma.c:(.text+0x4414): undefined reference to `mbox_free_channel'

> drivers/dma/built-in.o: In function `sba_issue_pending':

> edma.c:(.text+0x46cc): undefined reference to `mbox_send_message'

> drivers/dma/built-in.o: In function `sba_probe':

> edma.c:(.text+0x4e60): undefined reference to `mbox_request_channel'

> edma.c:(.text+0x5038): undefined reference to `mbox_free_channel'

> drivers/dma/built-in.o: In function `sba_tx_status':

> edma.c:(.text+0x5210): undefined reference to `mbox_client_peek_data'

> 

> drivers/dma/built-in.o: In function `sba_prep_dma_pq_req':

> edma.c:(.text+0x5784): undefined reference to `raid6_gflog'

> edma.c:(.text+0x5798): undefined reference to `raid6_gflog'

> 

> This rearranges the Kconfig dependencies accordingly.


Applied, thanks

-- 
~Vinod

Patch hide | download patch | download mbox

diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
index b7e0ab9585bc..686ae67d7e2a 100644
--- a/drivers/dma/Kconfig
+++ b/drivers/dma/Kconfig
@@ -101,7 +101,8 @@  config AXI_DMAC
 
 config BCM_SBA_RAID
 	tristate "Broadcom SBA RAID engine support"
-	depends on (ARM64 && MAILBOX && RAID6_PQ) || COMPILE_TEST
+	depends on ARM64 || COMPILE_TEST
+	depends on MAILBOX && RAID6_PQ
 	select DMA_ENGINE
 	select DMA_ENGINE_RAID
 	select ASYNC_TX_DISABLE_XOR_VAL_DMA