ARM: at91: select CONFIG_ARM_CPU_SUSPEND

Message ID 20170518144200.3663617-1-arnd@arndb.de
State Superseded
Headers show

Commit Message

Arnd Bergmann May 18, 2017, 2:41 p.m.
The reference to cpu_resume requires the corresponding
generic code to be enabled when CONFIG_PM is set:

arch/arm/mach-at91/pm.o: In function `sama5d2_pm_init':
pm.c:(.init.text+0x5e8): undefined reference to `cpu_resume'

Fixes: 24a0f5c539f9 ("ARM: at91: pm: Add sama5d2 backup mode")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 arch/arm/mach-at91/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.9.0

Comments

Alexandre Belloni May 23, 2017, 12:57 p.m. | #1
Hi,

On 18/05/2017 at 16:41:29 +0200, Arnd Bergmann wrote:
> The reference to cpu_resume requires the corresponding

> generic code to be enabled when CONFIG_PM is set:

> 

> arch/arm/mach-at91/pm.o: In function `sama5d2_pm_init':

> pm.c:(.init.text+0x5e8): undefined reference to `cpu_resume'

> 

> Fixes: 24a0f5c539f9 ("ARM: at91: pm: Add sama5d2 backup mode")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---

>  arch/arm/mach-at91/Kconfig | 1 +

>  1 file changed, 1 insertion(+)

> 

> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig

> index e754efd0016e..af76234d60c8 100644

> --- a/arch/arm/mach-at91/Kconfig

> +++ b/arch/arm/mach-at91/Kconfig

> @@ -1,6 +1,7 @@

>  menuconfig ARCH_AT91

>  	bool "Atmel SoCs"

>  	depends on ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7

> +	select ARM_CPU_SUSPEND if PM


This does not apply on v4.12-rc1 because the depends are different.

>  	select COMMON_CLK_AT91

>  	select GPIOLIB

>  	select PINCTRL

> -- 

> 2.9.0

> 


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Arnd Bergmann May 24, 2017, 3:39 p.m. | #2
On Tue, May 23, 2017 at 2:57 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> Hi,

>

> On 18/05/2017 at 16:41:29 +0200, Arnd Bergmann wrote:

>> The reference to cpu_resume requires the corresponding

>> generic code to be enabled when CONFIG_PM is set:

>>

>> arch/arm/mach-at91/pm.o: In function `sama5d2_pm_init':

>> pm.c:(.init.text+0x5e8): undefined reference to `cpu_resume'

>>

>> Fixes: 24a0f5c539f9 ("ARM: at91: pm: Add sama5d2 backup mode")

>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

>> ---

>>  arch/arm/mach-at91/Kconfig | 1 +

>>  1 file changed, 1 insertion(+)

>>

>> diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig

>> index e754efd0016e..af76234d60c8 100644

>> --- a/arch/arm/mach-at91/Kconfig

>> +++ b/arch/arm/mach-at91/Kconfig

>> @@ -1,6 +1,7 @@

>>  menuconfig ARCH_AT91

>>       bool "Atmel SoCs"

>>       depends on ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7

>> +     select ARM_CPU_SUSPEND if PM

>

> This does not apply on v4.12-rc1 because the depends are different.


Sent a new version now.

       Arnd

Patch hide | download patch | download mbox

diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index e754efd0016e..af76234d60c8 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -1,6 +1,7 @@ 
 menuconfig ARCH_AT91
 	bool "Atmel SoCs"
 	depends on ARCH_MULTI_V4_V5 || ARCH_MULTI_V6_V7
+	select ARM_CPU_SUSPEND if PM
 	select COMMON_CLK_AT91
 	select GPIOLIB
 	select PINCTRL