From patchwork Thu May 18 16:19:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudeep Holla X-Patchwork-Id: 100111 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp797095qge; Thu, 18 May 2017 09:19:53 -0700 (PDT) X-Received: by 10.84.132.98 with SMTP id 89mr5859850ple.29.1495124393447; Thu, 18 May 2017 09:19:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1495124393; cv=none; d=google.com; s=arc-20160816; b=X1POgZbuC5nnwQPnHIYQgbn/E2MmQfujGVcpa4xFhN/4HHF5n4j3wkUSYlB0TU1EKJ Th2B6J9eQ4hIE93zUQdEiFeO55PnRXGVaeZ5YY0PJ+03/L8T2y9z9v+oljxikVekM6Bi 007cXMpVAPhGaqA53IQLU6ew41TnjGYuo1VT3JvTP1ykRSOlQUiM5ue6Dyv2o33tYMeN a0K5v8YW+0GiU3TltD0VPKb1uPkryPkfyLiSjkLzekNocY3kltsZoJbvCCDZ39cMZOCp nkSzGn7fwTfMeHHDQq5aDrBrwsZWCIoCiQmJHrU3dbr+HM8+98inSo38Qh4ScF3XWOx8 CfPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=AwTSybc9JiXm4ns84xHjcK1o152BVQF7rOXsTZ2aAWY=; b=EriAaZ6ian4SXtYJeZtUXsr/p91sMoqq/tqiRleVwLzTAeoel/XD1iS3ljgYeJwAzE 3/dji3DXQTNSBsYyf9exQJ1kAs+W5Sd6YASRgfO1nv2PDkMm8reIFczlVdq0k2VtQCsq jvT4cBIdtpiD7S26DMWDRfzdeeNON9H9wF8VVyUw3T+MO3A40v43Rp9l0IjWgq3A7G7p zFfX4gE+rQT2m4fJmGX8wDB19VkxqvUViYXIguu0pAV/pu4tMCgbd12ZeEz9KtKQVlk0 +UCQwSsDGrLwCQAEAKs4nm2ElCcw6g7KgodLoMJjb+M2WM8BqiqQ9el8dJW7p/G9s31E nTqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t184si5416533pgd.216.2017.05.18.09.19.53; Thu, 18 May 2017 09:19:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932697AbdERQTk (ORCPT + 25 others); Thu, 18 May 2017 12:19:40 -0400 Received: from foss.arm.com ([217.140.101.70]:34154 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754521AbdERQTj (ORCPT ); Thu, 18 May 2017 12:19:39 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4FE6A344; Thu, 18 May 2017 09:19:38 -0700 (PDT) Received: from e107155-lin.cambridge.arm.com (unknown [10.1.210.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5F4533F41F; Thu, 18 May 2017 09:19:37 -0700 (PDT) From: Sudeep Holla To: linux-clk@vger.kernel.org, Stephen Boyd , Michael Turquette Cc: Sudeep Holla , linux-kernel@vger.kernel.org Subject: [PATCH] clk: scpi: fix return type of __scpi_dvfs_round_rate Date: Thu, 18 May 2017 17:19:28 +0100 Message-Id: <1495124368-26191-1-git-send-email-sudeep.holla@arm.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The frequencies above the maximum value of signed integer(i.e. 2^31 -1) will overflow with the current code. This patch fixes the return type of __scpi_dvfs_round_rate from 'int' to 'unsigned long'. Fixes: cd52c2a4b5c4 ("clk: add support for clocks provided by SCP(System Control Processor)") Cc: Michael Turquette Cc: Stephen Boyd Signed-off-by: Sudeep Holla --- drivers/clk/clk-scpi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Hi, Sorry for the stupid bug, just noticed the issue running on software models with the frequency of 2.4 GHz. Not noticed so far as never ran this on a system above 1.2 GHz so far :( Regards, Sudeep -- 2.7.4 diff --git a/drivers/clk/clk-scpi.c b/drivers/clk/clk-scpi.c index 96d37175d0ad..8ad458b5ad6e 100644 --- a/drivers/clk/clk-scpi.c +++ b/drivers/clk/clk-scpi.c @@ -71,15 +71,15 @@ static const struct clk_ops scpi_clk_ops = { }; /* find closest match to given frequency in OPP table */ -static int __scpi_dvfs_round_rate(struct scpi_clk *clk, unsigned long rate) +static long __scpi_dvfs_round_rate(struct scpi_clk *clk, unsigned long rate) { int idx; - u32 fmin = 0, fmax = ~0, ftmp; + unsigned long fmin = 0, fmax = ~0, ftmp; const struct scpi_opp *opp = clk->info->opps; for (idx = 0; idx < clk->info->count; idx++, opp++) { ftmp = opp->freq; - if (ftmp >= (u32)rate) { + if (ftmp >= rate) { if (ftmp <= fmax) fmax = ftmp; break;