From patchwork Thu May 18 18:22:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Daniel_D=C3=ADaz?= X-Patchwork-Id: 100119 Delivered-To: patch@linaro.org Received: by 10.182.142.97 with SMTP id rv1csp804007obb; Thu, 18 May 2017 11:22:55 -0700 (PDT) X-Received: by 10.99.120.206 with SMTP id t197mr6034822pgc.64.1495131775338; Thu, 18 May 2017 11:22:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1495131775; cv=none; d=google.com; s=arc-20160816; b=gCLg59X3RanZ3rwWCGSj6cdxH8O1oYftwCtox2Pi69GbOO3Y8u5o/3GMfLOw6i7TqO o216khI81r7ZrtS4JtqKrktfrYS5I9wrTOkdFeTZfCi1gAiGzbw+LLoPUwaTalX5UGJv vBKxAg/XsfIQ3OmWgcGxKS8MixRLfy6PJRGFPmCjJbMF4a0ACLaF7zlCBDPqFNllNe02 bdh5hhv9Jkf/N5crTqAhgPP1Zq5wUg2Dgp9JzyJ6KDdWxH4V1+KWwQhbYy3/Wqm4JnIf 600kOVE+/KF/t13TPWO/KZ2McW6ivRqQdR8Xfzyt/aTA4riU0jI+MaYWY3LBq9OlchOg iGyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:references:in-reply-to:message-id:date:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=GeD0LJWO+q+2OJPj/zWBG5C0lP+JV2RFWHGpRz5a8gM=; b=JW2e1+FujN/JGnchjvDyLKYAqbP0t7PFqIYd7lwrSeLIbLRG9zy6ue3UIqcMPcbxtf oKSaFheAmiQgVbZaCLRJfL1bKrcsH9hfkx3/8//kVuD+CaaELfdwIuSe5rZoTYjcxaE5 ct+T0FrnSXF6uPY4RRkhYxHKt1l1EdzK29qMn5XpIx7XRvx9bGl8r2yiu47B/AnWQhDL nh0Pex3Gpo0Yy3fI6gWto6T0WkOyBRVlX50b9O1y9x0DAEk44ackurauxF70fQ7GU0zh BxycHzIjL3OFYwchML5+TZkUKtIhxa3wNrENH7GOsmCLRbqd9aT605Ha9PJPKf1riMe+ 6p4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail.openembedded.org (mail.openembedded.org. [140.211.169.62]) by mx.google.com with ESMTP id f12si6020895plm.262.2017.05.18.11.22.55; Thu, 18 May 2017 11:22:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) client-ip=140.211.169.62; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of openembedded-core-bounces@lists.openembedded.org designates 140.211.169.62 as permitted sender) smtp.mailfrom=openembedded-core-bounces@lists.openembedded.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from review.yoctoproject.org (localhost [127.0.0.1]) by mail.openembedded.org (Postfix) with ESMTP id BF92378094; Thu, 18 May 2017 18:22:52 +0000 (UTC) X-Original-To: openembedded-core@lists.openembedded.org Delivered-To: openembedded-core@lists.openembedded.org Received: from mail-oi0-f47.google.com (mail-oi0-f47.google.com [209.85.218.47]) by mail.openembedded.org (Postfix) with ESMTP id 9910678088 for ; Thu, 18 May 2017 18:22:51 +0000 (UTC) Received: by mail-oi0-f47.google.com with SMTP id l18so64981679oig.2 for ; Thu, 18 May 2017 11:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b9/zWubDRqwIIfH+ecj3X1nA0ZPChi53fOfdY7IkJ50=; b=jmwgOgd/XT/EA97J8fJr1wrqlu9wlbAVlhHJn8aCwo2QTQZqdVUaTsnw44KO1h5+GU 7AMHMPdcQ9Nz5/Kdn2QOfsh1uB63baiyJkqRkFUcQigL8qZpYrn78ChApbo/CKiDV2fP eRY640LOkwXZ3y6tnV7QYMYlLUHzCtFFnRwow= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b9/zWubDRqwIIfH+ecj3X1nA0ZPChi53fOfdY7IkJ50=; b=XMPvdZ+gmvuKLnmRlyHu+fJfN9tzeeHvY8zWDLhm9hRlhQT4TFi5zCp/BZPX/iXFdV BoQI9lERgrc/PDJTEKRb0PDnlkkd2oVX9UTjpfQNLX4GkwjaAiPsPDtyRpHwRE71qsKA jg/4tQfP9UlRRXlO2BQlwEc6B7ZQj+PyIaNdHJw3aAeJkx/+1s9jmKQf7U05QWLwu6Nd HnPdvBXEPs320NmF0dioBns0O1vaUgnUQtskkzkIvsCPOEcENBkUFbcVtIXiYNo0dTST 73KSXot/HV972Ts1aM+9PvgJIavau0W/YIuCawuQ3TDCtGUq3y/++m3mfdRz8EBNsMQm NmuQ== X-Gm-Message-State: AODbwcA8oi43EWLpFdq0AZ8zDdapLxbdJ8xE4diQZCs4cdJLbynv356c zrdb/R3ofin8Oehg X-Received: by 10.157.12.193 with SMTP id o1mr3299657otd.154.1495131772636; Thu, 18 May 2017 11:22:52 -0700 (PDT) Received: from aura.cortijodelrio.net (CableLink67-82.telefonia.InterCable.net. [201.172.67.82]) by smtp.googlemail.com with ESMTPSA id c10sm2863501otb.38.2017.05.18.11.22.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 May 2017 11:22:52 -0700 (PDT) From: =?utf-8?q?Daniel_D=C3=ADaz?= To: openembedded-core@lists.openembedded.org Date: Thu, 18 May 2017 13:22:36 -0500 Message-Id: <1495131757-7261-2-git-send-email-daniel.diaz@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1495131757-7261-1-git-send-email-daniel.diaz@linaro.org> References: <1495131757-7261-1-git-send-email-daniel.diaz@linaro.org> MIME-Version: 1.0 Subject: [OE-core] [PATCH 2/3] piglit: add patch for lack of gbm_bo_map X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: openembedded-core-bounces@lists.openembedded.org Errors-To: openembedded-core-bounces@lists.openembedded.org [Piglit Bug #100978] -- https://bugs.freedesktop.org/show_bug.cgi?id=100978 When linking against Mali 450 r6, errors like the following can be seen: ../../../../lib/libpiglitutil_gl.so.0: undefined reference to `gbm_bo_unmap' ../../../../lib/libpiglitutil_gl.so.0: undefined reference to `gbm_bo_map' collect2: error: ld returned 1 exit status make[2]: *** [bin/point-sprite] Error 1 This is due to gbm_bo_map() and gbm_bo_unmap() being recently added but not yet implemented by all graphics drivers. Instead of relying on GBM's version, actually try to link against those symbols. Upstream-Status: Submitted [piglit@lists.freedesktop.org] Signed-off-by: Daniel Díaz --- ...fine-GBM_BO_MAP-only-when-symbol-is-found.patch | 48 ++++++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 meta/recipes-graphics/piglit/piglit/0001-CMake-define-GBM_BO_MAP-only-when-symbol-is-found.patch diff --git a/meta/recipes-graphics/piglit/piglit/0001-CMake-define-GBM_BO_MAP-only-when-symbol-is-found.patch b/meta/recipes-graphics/piglit/piglit/0001-CMake-define-GBM_BO_MAP-only-when-symbol-is-found.patch new file mode 100644 index 0000000..0750676 --- /dev/null +++ b/meta/recipes-graphics/piglit/piglit/0001-CMake-define-GBM_BO_MAP-only-when-symbol-is-found.patch @@ -0,0 +1,48 @@ +From 6b6acee8841d092e5066b1bec2ba1c49cce4f91f Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Daniel=20D=C3=ADaz?= +Date: Thu, 4 May 2017 00:57:39 -0500 +Subject: [PATCH 1/4] CMake: define GBM_BO_MAP only when symbol is found +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +gbm_bo_map() and _unmap() have been added recently to Mesa, +and this update may not have reached all implementations of +GBM, such as the one provided by Mali r6, where said +definitions can be found in the header file but not in the +library itself. This leads to errors like the following when +linking: + ../../../../lib/libpiglitutil_gl.so.0: undefined reference to `gbm_bo_unmap' + ../../../../lib/libpiglitutil_gl.so.0: undefined reference to `gbm_bo_map' + collect2: error: ld returned 1 exit status + make[2]: *** [bin/point-sprite] Error 1 + +Instead of relying on the header file, actually try to link +using that symbol to determine if PIGLIT_HAS_GBM_BO_MAP +should be defined. + +Signed-off-by: Daniel Díaz +Reviewed-by: Jan Vesely +--- + CMakeLists.txt | 5 +++-- + 1 file changed, 3 insertions(+), 2 deletions(-) + +diff --git a/CMakeLists.txt b/CMakeLists.txt +index a4ff99e..cc26fa8 100644 +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -141,8 +141,9 @@ IF(${CMAKE_SYSTEM_NAME} MATCHES "Linux") + if(GBM_FOUND) + set(PIGLIT_HAS_GBM True) + add_definitions(-DPIGLIT_HAS_GBM) +- if (GBM_VERSION VERSION_EQUAL "12.1" OR GBM_VERSION VERSION_GREATER "12.1") +- set(PIGLIT_HAS_GBM_BO_MAP True) ++ set(CMAKE_REQUIRED_LIBRARIES ${CMAKE_REQUIRED_LIBRARIES} ${GBM_LIBRARIES}) ++ CHECK_FUNCTION_EXISTS(gbm_bo_map PIGLIT_HAS_GBM_BO_MAP) ++ if (PIGLIT_HAS_GBM_BO_MAP) + add_definitions(-DPIGLIT_HAS_GBM_BO_MAP) + endif() + endif(GBM_FOUND) +-- +1.9.1 +