From patchwork Fri May 19 04:25:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leo Yan X-Patchwork-Id: 100149 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp141207qge; Thu, 18 May 2017 21:27:35 -0700 (PDT) X-Received: by 10.99.160.17 with SMTP id r17mr4434115pge.37.1495168055011; Thu, 18 May 2017 21:27:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1495168055; cv=none; d=google.com; s=arc-20160816; b=vp/afN62tGN8+vNWFWZpPn610gBUPWvqn8keY3Bm/3TitR5Pid0tLOVLAX9PB6H1dr RBbmZzG5TJnaKlSVB1ppWR3J8a1rQzgaHqjq8UKxRcJ1Iu10uUDAgUHqFLzvJJ84Q5MC 4mco++QcQy7kXCNBp4C/FrQsiOWdAWX2CbJCeUpVrcuE1Ps/NuE5E4BLTKGWSvWKtTb4 9RyiwiHA7ojzCCv2ypUsnB6amHwWXdWgozp2BOslxVrtMCND2KagGcpq8xpEVHfcZv/A gpCyEXRteSJ76fgYlwRnIdVe3YYVaYQhwjKrvly57w12bIXwgOMg/puv5eHnntiJ8IRx gkTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=KPg79NY3sGvLdvwjFFRlkg3unWx7G4i/7+aegEzxzF8=; b=deHLm8PPPJlJ94vA/EI46cptrYZSEr+EksGWWLdYmbniEPsDSfCQ4aCE8r6p+gWhV4 FwFX2EJ76fMPMz5rtdcq/L1c7ardbH971Ov9jHJyA6GRN2ageeOCq6Mhb1lOfCLQKwxS vLypMjNj452Zc1sB2PolMMPXXVgY8/7LscDc7HxvxKDD5KTaIwD8lIp1U6jwHbA2G2VR 9xNoYFcMYS/leU7oOTQr3w4bW2lzKhbdyF18uWKSsNVLD+QpUf9Jt46a/zLdfPCI+NAY 3EK/VW7VKrmzTcv92J6+ga/BIB7P3iOBTOreNNE+G4aEhlsWhMfX3YHiWGfZDBdWPNJ6 dadw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q22si7089126pgc.268.2017.05.18.21.27.33; Thu, 18 May 2017 21:27:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754422AbdESE1L (ORCPT + 25 others); Fri, 19 May 2017 00:27:11 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:35365 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753067AbdESE1F (ORCPT ); Fri, 19 May 2017 00:27:05 -0400 Received: by mail-pf0-f179.google.com with SMTP id n23so33686165pfb.2 for ; Thu, 18 May 2017 21:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=KPg79NY3sGvLdvwjFFRlkg3unWx7G4i/7+aegEzxzF8=; b=bEoAHBYus7gV8JNk60ofG9hVOFcNUqQHBPoSF4eZkwZ2DMecwhCTAfluOL6FDOVQxl Vm+3pUmqgjs7zKqNoZcl0x6Bb+sa1hPw1Tng588vYZ5yeHgk5pdB8PNLAE/hPnUQUNnq W/XDnvIn5P6Hs9Afnno+9DX16JFwz1Nyp/EXM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=KPg79NY3sGvLdvwjFFRlkg3unWx7G4i/7+aegEzxzF8=; b=Tlrbyu8kHa4qNZZpUjNHHoI9XieO70Y8kd68PC7yMlu52/lh9u8V2u8OD2iWugJYT7 xkTikrFakf2hJevsPxEoGC9TmZYPN+a+AaeXvUxou5d/CwGIM1iS/CI5Z7XTNhkZhx5t g0tXtbnylLxwk7corSFLwpiintSchJV+khADtEVTeaVxM5NiKMN3dT2yrGiWqPvtP62R ZNAu+oPjx0Vhnth6oAFrWBpHreXVNcXaOcdjtnp4pilhQRSqgOPSfxMHVDvBx+OZtgvV 7hDb/v5L3iDWPbXXpMgkcpuDF/+QzxZMC5cfz46yf71FT8D5QxnHQUXnrFWVir+tO7gI rqkg== X-Gm-Message-State: AODbwcDEVqowDbH2zy73nmkSU0ym4gunk9Ou7s6kG94N4blW8EWxyUfA mqQ7r7K7NTrtob+l X-Received: by 10.99.137.194 with SMTP id v185mr7990036pgd.206.1495168024455; Thu, 18 May 2017 21:27:04 -0700 (PDT) Received: from localhost.localdomain (li637-108.members.linode.com. [106.186.117.108]) by smtp.gmail.com with ESMTPSA id c29sm5823259pfj.101.2017.05.18.21.26.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 May 2017 21:27:03 -0700 (PDT) From: Leo Yan To: Jonathan Corbet , Mathieu Poirier , Rob Herring , Mark Rutland , Liviu Dudau , Sudeep Holla , Lorenzo Pieralisi , Catalin Marinas , Will Deacon , Wei Xu , Andy Gross , David Brown , Greg Kroah-Hartman , Suzuki K Poulose , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, Stephen Boyd , Mike Leach Cc: Leo Yan Subject: [PATCH v10 05/10] coresight: of_get_coresight_platform_data: Add missing of_node_put Date: Fri, 19 May 2017 12:25:52 +0800 Message-Id: <1495167957-14923-6-git-send-email-leo.yan@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1495167957-14923-1-git-send-email-leo.yan@linaro.org> References: <1495167957-14923-1-git-send-email-leo.yan@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suzuki K Poulose The of_get_coresight_platform_data iterates over the possible CPU nodes to find a given cpu phandle. However it does not drop the reference to the node pointer returned by the of_get_coresight_platform_data. This patch also introduces another minor fix is to use of_cpu_device_node_get() to replace of_get_cpu_node(). Cc: Mathieu Poirier Reviewed-by: Suzuki K Poulose Signed-off-by: Suzuki K Poulose [Leo: minor tweaks for of_get_coresight_platform_data] Signed-off-by: Leo Yan --- drivers/hwtracing/coresight/of_coresight.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) -- 2.7.4 diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c index 2749853..225b2dd 100644 --- a/drivers/hwtracing/coresight/of_coresight.c +++ b/drivers/hwtracing/coresight/of_coresight.c @@ -109,7 +109,8 @@ of_get_coresight_platform_data(struct device *dev, struct coresight_platform_data *pdata; struct of_endpoint endpoint, rendpoint; struct device *rdev; - struct device_node *dn; + bool found; + struct device_node *dn, *np; struct device_node *ep = NULL; struct device_node *rparent = NULL; struct device_node *rport = NULL; @@ -176,17 +177,19 @@ of_get_coresight_platform_data(struct device *dev, } while (ep); } - /* Affinity defaults to CPU0 */ - pdata->cpu = 0; dn = of_parse_phandle(node, "cpu", 0); - for (cpu = 0; dn && cpu < nr_cpu_ids; cpu++) { - if (dn == of_get_cpu_node(cpu, NULL)) { - pdata->cpu = cpu; + for_each_possible_cpu(cpu) { + np = of_cpu_device_node_get(cpu); + found = (dn == np); + of_node_put(np); + if (found) break; - } } of_node_put(dn); + /* Affinity to CPU0 if no cpu nodes are found */ + pdata->cpu = found ? cpu : 0; + return pdata; } EXPORT_SYMBOL_GPL(of_get_coresight_platform_data);