[10/15] db: Add --tag=CC to cross libtool invocation

Message ID 20170522050042.42403-10-raj.khem@gmail.com
State New
Headers show
Series
  • [01/15] musl: Update to latest master
Related show

Commit Message

Khem Raj May 22, 2017, 5 a.m.
Fixes errors like

libtool: compile: unable to infer tagged configuration
libtool: compile: specify a tag with `--tag'

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta/recipes-support/db/db_5.3.28.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.13.0

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Burton, Ross May 23, 2017, 1:14 p.m. | #1
On 22 May 2017 at 06:00, Khem Raj <raj.khem@gmail.com> wrote:

> +EXTRA_OEMAKE_append_class-target = " LIBTOOL='${STAGING_BINDIR_CROSS}/${HOST_SYS}-libtool

> --tag=CC'"

>


packages/corei7-64-poky-linux/db/db-cxx: RDEPENDS: removed all items
"libstdc++ (['>= 6.3.0'])"

This doesn't seem right (happy to be told otherwise).

Ross
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj May 23, 2017, 2:32 p.m. | #2
On Tue, May 23, 2017 at 6:14 AM Burton, Ross <ross.burton@intel.com> wrote:

>

> On 22 May 2017 at 06:00, Khem Raj <raj.khem@gmail.com> wrote:

>

>> +EXTRA_OEMAKE_append_class-target = "

>> LIBTOOL='${STAGING_BINDIR_CROSS}/${HOST_SYS}-libtool --tag=CC'"

>>

>

> packages/corei7-64-poky-linux/db/db-cxx: RDEPENDS: removed all items

> "libstdc++ (['>= 6.3.0'])"

>

> This doesn't seem right (happy to be told otherwise).

>



I think you are right we have c++ here can you try with --tag=CXX

>

> Ross

>
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Burton, Ross May 23, 2017, 2:44 p.m. | #3
On 23 May 2017 at 15:32, Khem Raj <raj.khem@gmail.com> wrote:

> I think you are right we have c++ here can you try with --tag=CXX

>

>>

packages/corei7-64-poky-linux/db/db: RDEPENDS: added "libgcc (['>= 6.3.0'])
libstdc++ (['>= 6.3.0'])"

That's worse! :)

Ross
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj May 23, 2017, 2:48 p.m. | #4
On Tue, May 23, 2017 at 7:44 AM, Burton, Ross <ross.burton@intel.com> wrote:
> packages/corei7-64-poky-linux/db/db: RDEPENDS: added "libgcc (['>= 6.3.0'])

> libstdc++ (['>= 6.3.0'])"

>

> That's worse! :)


no its better, it reintroduced the deps and this time also on libgcc
which probably was latent. it worked because someone else pulled
libgcc into image. can you check readelf -d | grep DT_NEEDED output
from bins/solibs in db package. ?
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Burton, Ross May 23, 2017, 2:54 p.m. | #5
On 23 May 2017 at 15:48, Khem Raj <raj.khem@gmail.com> wrote:

> no its better, it reintroduced the deps and this time also on libgcc

> which probably was latent. it worked because someone else pulled

> libgcc into image. can you check readelf -d | grep DT_NEEDED output

> from bins/solibs in db package. ?

>


Well, and libstdc++ to the not-C++ bit.

I'll do the readelf shortly.

Ross
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Burton, Ross May 23, 2017, 3:02 p.m. | #6
On 23 May 2017 at 15:48, Khem Raj <raj.khem@gmail.com> wrote:

> no its better, it reintroduced the deps and this time also on libgcc

> which probably was latent. it worked because someone else pulled

> libgcc into image. can you check readelf -d | grep DT_NEEDED output

> from bins/solibs in db package. ?

>


Using --tag=CC:

$ readelf -d libdb.so |grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]
$ readelf -d libdb_cxx.so |grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libgcc_s.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]

Using --tag=CXX:

$ readelf -d libdb.so |grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libstdc++.so.6]
 0x0000000000000001 (NEEDED)             Shared library: [libgcc_s.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]
$ readelf -d libdb_cxx.so |grep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libstdc++.so.6]
 0x0000000000000001 (NEEDED)             Shared library: [libgcc_s.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]

Ross
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj May 23, 2017, 3:10 p.m. | #7
On Tue, May 23, 2017 at 8:02 AM, Burton, Ross <ross.burton@intel.com> wrote:
>

> On 23 May 2017 at 15:48, Khem Raj <raj.khem@gmail.com> wrote:

>>

>> no its better, it reintroduced the deps and this time also on libgcc

>> which probably was latent. it worked because someone else pulled

>> libgcc into image. can you check readelf -d | grep DT_NEEDED output

>> from bins/solibs in db package. ?

>

>

> Using --tag=CC:

>

> $ readelf -d libdb.so |grep NEEDED

>  0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]

>  0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]

> $ readelf -d libdb_cxx.so |grep NEEDED

>  0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]

>  0x0000000000000001 (NEEDED)             Shared library: [libgcc_s.so.1]

>  0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]

>

> Using --tag=CXX:

>

> $ readelf -d libdb.so |grep NEEDED

>  0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]

>  0x0000000000000001 (NEEDED)             Shared library: [libstdc++.so.6]

>  0x0000000000000001 (NEEDED)             Shared library: [libgcc_s.so.1]

>  0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]

> $ readelf -d libdb_cxx.so |grep NEEDED

>  0x0000000000000001 (NEEDED)             Shared library: [libpthread.so.0]

>  0x0000000000000001 (NEEDED)             Shared library: [libstdc++.so.6]

>  0x0000000000000001 (NEEDED)             Shared library: [libgcc_s.so.1]

>  0x0000000000000001 (NEEDED)             Shared library: [libc.so.6]

>


So I think we need to add the --tag inside the component configuration itself

> Ross

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-support/db/db_5.3.28.bb b/meta/recipes-support/db/db_5.3.28.bb
index 26065bbb0b..bbf52605f8 100644
--- a/meta/recipes-support/db/db_5.3.28.bb
+++ b/meta/recipes-support/db/db_5.3.28.bb
@@ -72,7 +72,7 @@  MUTEX = ""
 MUTEX_arm = "${ARM_MUTEX}"
 MUTEX_armeb = "${ARM_MUTEX}"
 EXTRA_OECONF += "${MUTEX} STRIP=true"
-EXTRA_OEMAKE_append_class-target = " LIBTOOL=${STAGING_BINDIR_CROSS}/${HOST_SYS}-libtool"
+EXTRA_OEMAKE_append_class-target = " LIBTOOL='${STAGING_BINDIR_CROSS}/${HOST_SYS}-libtool --tag=CC'"
 
 AUTOTOOLS_SCRIPT_PATH = "${S}/dist"