mmc: renesas-sdhi: export renesas_sdhi_probe

Message ID 20170522133339.798278-1-arnd@arndb.de
State New
Headers show

Commit Message

Arnd Bergmann May 22, 2017, 1:33 p.m.
We now build the sdhi driver in separate modules, which means we
have to export the symbols that are called from another module:

ERROR: "renesas_sdhi_remove" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!
ERROR: "renesas_sdhi_probe" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!

Fixes: 94418768f765 ("mmc: renesas-sdhi: make renesas_sdhi_sys_dmac main module file")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/mmc/host/renesas_sdhi_core.c | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Simon Horman May 23, 2017, 5:31 a.m. | #1
On Mon, May 22, 2017 at 03:33:08PM +0200, Arnd Bergmann wrote:
> We now build the sdhi driver in separate modules, which means we

> have to export the symbols that are called from another module:

> 

> ERROR: "renesas_sdhi_remove" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!

> ERROR: "renesas_sdhi_probe" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!

> 

> Fixes: 94418768f765 ("mmc: renesas-sdhi: make renesas_sdhi_sys_dmac main module file")


Sorry for messing this up and thanks for the fix.

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---

>  drivers/mmc/host/renesas_sdhi_core.c | 2 ++

>  1 file changed, 2 insertions(+)

> 

> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c

> index 846ee1a8e5a6..fa6c188e0327 100644

> --- a/drivers/mmc/host/renesas_sdhi_core.c

> +++ b/drivers/mmc/host/renesas_sdhi_core.c

> @@ -638,6 +638,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,

>  eprobe:

>  	return ret;

>  }

> +EXPORT_SYMBOL_GPL(renesas_sdhi_probe);

>  

>  int renesas_sdhi_remove(struct platform_device *pdev)

>  {

> @@ -648,3 +649,4 @@ int renesas_sdhi_remove(struct platform_device *pdev)

>  

>  	return 0;

>  }

> +EXPORT_SYMBOL_GPL(renesas_sdhi_remove);

> -- 

> 2.9.0

> 

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Wolfram Sang May 23, 2017, 8 a.m. | #2
On Mon, May 22, 2017 at 05:51:57PM +0200, Ulf Hansson wrote:
> On 22 May 2017 at 15:33, Arnd Bergmann <arnd@arndb.de> wrote:

> > We now build the sdhi driver in separate modules, which means we

> > have to export the symbols that are called from another module:

> >

> > ERROR: "renesas_sdhi_remove" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!

> > ERROR: "renesas_sdhi_probe" [drivers/mmc/host/renesas_sdhi_sys_dmac.ko] undefined!

> >

> > Fixes: 94418768f765 ("mmc: renesas-sdhi: make renesas_sdhi_sys_dmac main module file")

> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> 

> Thanks, applied for next!


Wow, that was fast :) FWIW:

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


Thanks, Arnd!

Patch

diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index 846ee1a8e5a6..fa6c188e0327 100644
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -638,6 +638,7 @@  int renesas_sdhi_probe(struct platform_device *pdev,
 eprobe:
 	return ret;
 }
+EXPORT_SYMBOL_GPL(renesas_sdhi_probe);
 
 int renesas_sdhi_remove(struct platform_device *pdev)
 {
@@ -648,3 +649,4 @@  int renesas_sdhi_remove(struct platform_device *pdev)
 
 	return 0;
 }
+EXPORT_SYMBOL_GPL(renesas_sdhi_remove);