[3/3] apt-native: Remove USE_NLS = "yes"

Message ID 20170523234744.34487-3-raj.khem@gmail.com
State New
Headers show
Series
  • [1/3] intltool: Adds gettext as a DEPENDS
Related show

Commit Message

Khem Raj May 23, 2017, 11:47 p.m.
USE_NLS is target specific, its redundant for native packages

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta/recipes-devtools/apt/apt-native.inc | 1 -
 1 file changed, 1 deletion(-)

-- 
2.13.0

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Burton, Ross May 24, 2017, 10:58 a.m. | #1
On 24 May 2017 at 00:47, Khem Raj <raj.khem@gmail.com> wrote:

> USE_NLS is target specific, its redundant for native packages

>


I don't think you're right:

| In file included from
/data/poky-master/tmp/work/x86_64-linux/apt-native/1.2.12-r0/build/include/apt-private/private-cachefile.h:12:0,
|                  from
/data/poky-master/tmp/work/x86_64-linux/apt-native/1.2.12-r0/apt-1.2.12/apt-private/private-output.cc:15:
| /usr/include/libintl.h:44:14: error: expected unqualified-id before ‘char’
|  extern char *dgettext (const char *__domainname, const char *__msgid)
|               ^
| /usr/include/libintl.h:44:14: error: expected initializer before ‘char’
| In file included from /usr/include/features.h:374:0,
|                  from /usr/include/x86_64-linux-gnu/sys/types.h:25,
|                  from /usr/include/regex.h:23,
|                  from
/data/poky-master/tmp/work/x86_64-linux/apt-native/1.2.12-r0/build/include/apt-pkg/configuration.h:31,
|                  from
/data/poky-master/tmp/work/x86_64-linux/apt-native/1.2.12-r0/apt-1.2.12/apt-private/private-output.cc:4:
| /usr/include/libintl.h:82:52: error: expected unqualified-id before
‘throw’
|  extern char *textdomain (const char *__domainname) __THROW;
|                                                     ^
| /usr/include/libintl.h:82:52: error: expected initializer before ‘throw’
| /usr/include/libintl.h:87:32: error: expected unqualified-id before
‘throw’
|          const char *__dirname) __THROW;
|                                 ^
| ERROR: oe_runmake failed
| /usr/include/libintl.h:87:32: error: expected initializer before ‘throw’

native.bbclass sets USE_NLS=no but I think apt requires it to be enabled,
thus the assignment.

Ross
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Patch hide | download patch | download mbox

diff --git a/meta/recipes-devtools/apt/apt-native.inc b/meta/recipes-devtools/apt/apt-native.inc
index 68f1b3ce2c..be806826e4 100644
--- a/meta/recipes-devtools/apt/apt-native.inc
+++ b/meta/recipes-devtools/apt/apt-native.inc
@@ -3,7 +3,6 @@  inherit native
 
 DEPENDS += "dpkg-native gettext-native db-native curl-native xz-native"
 PACKAGES = ""
-USE_NLS = "yes"
 
 SRC_URI += "file://db_linking_hack.patch \
             file://0001-Revert-always-run-dpkg-configure-a-at-the-end-of-our.patch \