From patchwork Fri May 26 10:55:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sekhar Nori X-Patchwork-Id: 100570 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp190478qge; Fri, 26 May 2017 03:55:40 -0700 (PDT) X-Received: by 10.84.236.6 with SMTP id q6mr32953527plk.146.1495796140665; Fri, 26 May 2017 03:55:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1495796140; cv=none; d=google.com; s=arc-20160816; b=TDrujrAgBlgWPzxTbobKDcr545ilwb8v8VYatoHDmgplQkDBVOMZmIthXrs26TuGiN ZSI6lLdW/yAANo9gZFxxG2IvPye9YtwUT5WKBaJDioU8JOgbzOQHIFXEJx9mqmAWueUp 16oHgexLCrSicy5AI4yU9YoNuWjbfhP/E8vt94hG9gw4sYW0YKB5zGt+/nu+ZUlHfl2j QvbsBQK5WUt630nRyC1ny5AwllsE0pV1SPEdFmhP64cKQQ8If4EAX1YTPIqjc8IveXfm zhQCQ5iIRQMS95T7SscwO4LGBOAeU7jBxouAKtiFM+sFe3Iy5cPcRT7pd3Z4a9QOO6at y5Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:dkim-signature:arc-authentication-results; bh=DyWo/PpDu7D+pCuQ/iY7glUCS2n9LvsGpmWzxlgltpk=; b=REsPl97Jqajsj0H4hKkgVYh83nyPtkGKhXaSHRVDZSLkmYoyUYaQpKTr56xZw5YJb3 OMRSpMjn76mzX9cIN+l2KwU78wd4/fbYSb7GMEESAg89ckrONiIJHSbz8M70sS3z0n52 JmBwG6LHd2H9Xh5nBZDABv15v0X3xH7RQkJiOYrVODfqSyRww6NZAYPXXAddIE9K0cY+ qKsfFeALRCpNLNUW86+IFXKSwtelrcsD2Sj+Bub9Amkpxur12pBxG4mJOFgwExttDcsz y1rD1jEZ1cGmTBcTay9rc3CkYaPF4MMHCWQ1C5lK1/0CChvH2x4FYDi2h5ZmHWp7CrOk F/FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com; spf=pass (google.com: best guess record for domain of linux-media-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i76si509112pgd.36.2017.05.26.03.55.40; Fri, 26 May 2017 03:55:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-media-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com; spf=pass (google.com: best guess record for domain of linux-media-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-media-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S971171AbdEZKzi (ORCPT + 4 others); Fri, 26 May 2017 06:55:38 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:44473 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965647AbdEZKzg (ORCPT ); Fri, 26 May 2017 06:55:36 -0400 Received: from dflxv15.itg.ti.com ([128.247.5.124]) by lelnx193.ext.ti.com (8.15.1/8.15.1) with ESMTP id v4QAtUoP020391; Fri, 26 May 2017 05:55:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com; s=ti-com-17Q1; t=1495796130; bh=t0AVRQe8vqvUvuk74bzHrYhKjsdMCc99C4rOIo6CyOo=; h=From:To:CC:Subject:Date; b=nESPTeh7pbEckENfscOmPYWftSTutkNbl06OTb1l/BoaQ1DQdzDTSy/8CUtnCIbMO KFHDWdpNLVMOKgIjjQMH4s+r7fiZ0prkE6XjkHrM6wkD1kkJOmdFMDa4s2VlDJuL0P y5I6mwUpn8Bsh+0WVyjZJH1pAMCHH6R5JNemgK1g= Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id v4QAtUKY007448; Fri, 26 May 2017 05:55:30 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE72.ent.ti.com (128.247.5.109) with Microsoft SMTP Server id 14.3.294.0; Fri, 26 May 2017 05:55:29 -0500 Received: from psplinux063.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v4QAtRcM017635; Fri, 26 May 2017 05:55:28 -0500 From: Sekhar Nori To: Prabhakar Lad , Mauro Carvalho Chehab , Hans Verkuil CC: , Kevin Hilman , Alejandro Hernandez , Sekhar Nori Subject: [PATCH] davinci: vpif_capture: fix default pixel format for BT.656/BT.1120 video Date: Fri, 26 May 2017 16:25:27 +0530 Message-ID: <20170526105527.10522-1-nsekhar@ti.com> X-Mailer: git-send-email 2.9.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org For both BT.656 and BT.1120 video, the pixel format used by VPIF is Y/CbCr 4:2:2 in semi-planar format (Luma in one plane and Chroma in another). This corresponds to NV16 pixel format. This is documented in section 36.2.3 of OMAP-L138 Technical Reference Manual, SPRUH77A. The VPIF driver incorrectly sets the default format to V4L2_PIX_FMT_YUV422P. Fix it. Reported-by: Alejandro Hernandez Signed-off-by: Sekhar Nori --- drivers/media/platform/davinci/vpif_capture.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.9.0 Acked-by: Kevin Hilman Acked-by: Lad, Prabhakar Acked-by: Benoit Parrot diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c index 44f702752d3a..128e92d1dd5a 100644 --- a/drivers/media/platform/davinci/vpif_capture.c +++ b/drivers/media/platform/davinci/vpif_capture.c @@ -513,7 +513,7 @@ static int vpif_update_std_info(struct channel_obj *ch) if (ch->vpifparams.iface.if_type == VPIF_IF_RAW_BAYER) common->fmt.fmt.pix.pixelformat = V4L2_PIX_FMT_SBGGR8; else - common->fmt.fmt.pix.pixelformat = V4L2_PIX_FMT_YUV422P; + common->fmt.fmt.pix.pixelformat = V4L2_PIX_FMT_NV16; common->fmt.type = V4L2_BUF_TYPE_VIDEO_CAPTURE; @@ -917,8 +917,8 @@ static int vpif_enum_fmt_vid_cap(struct file *file, void *priv, fmt->pixelformat = V4L2_PIX_FMT_SBGGR8; } else { fmt->type = V4L2_BUF_TYPE_VIDEO_CAPTURE; - strcpy(fmt->description, "YCbCr4:2:2 YC Planar"); - fmt->pixelformat = V4L2_PIX_FMT_YUV422P; + strcpy(fmt->description, "YCbCr4:2:2 Semi-Planar"); + fmt->pixelformat = V4L2_PIX_FMT_NV16; } return 0; } @@ -946,8 +946,8 @@ static int vpif_try_fmt_vid_cap(struct file *file, void *priv, if (pixfmt->pixelformat != V4L2_PIX_FMT_SBGGR8) pixfmt->pixelformat = V4L2_PIX_FMT_SBGGR8; } else { - if (pixfmt->pixelformat != V4L2_PIX_FMT_YUV422P) - pixfmt->pixelformat = V4L2_PIX_FMT_YUV422P; + if (pixfmt->pixelformat != V4L2_PIX_FMT_NV16) + pixfmt->pixelformat = V4L2_PIX_FMT_NV16; } common->fmt.fmt.pix.pixelformat = pixfmt->pixelformat;