[1/2] gpio: ingenic: add CONFIG_OF dependency

Message ID 20170529125802.163127-1-arnd@arndb.de
State New
Headers show
Series
  • [1/2] gpio: ingenic: add CONFIG_OF dependency
Related show

Commit Message

Arnd Bergmann May 29, 2017, 12:57 p.m.
The driver cannot access the of_node field when CONFIG_OF is disabled:

drivers/gpio/gpio-ingenic.c: In function 'ingenic_gpio_probe':
drivers/gpio/gpio-ingenic.c:324:10: error: 'struct gpio_chip' has no member named 'of_node'

Fixes: b0653ce39a0d ("gpio: Add gpio-ingenic driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.9.0

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Linus Walleij May 29, 2017, 4:45 p.m. | #1
On Mon, May 29, 2017 at 2:57 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> The driver cannot access the of_node field when CONFIG_OF is disabled:

>

> drivers/gpio/gpio-ingenic.c: In function 'ingenic_gpio_probe':

> drivers/gpio/gpio-ingenic.c:324:10: error: 'struct gpio_chip' has no member named 'of_node'

>

> Fixes: b0653ce39a0d ("gpio: Add gpio-ingenic driver")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


I already sent a combined patch fixing these two deps earlier today,
good that we are several at it :)

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Geert Uytterhoeven May 30, 2017, 9:03 a.m. | #2
On Mon, May 29, 2017 at 6:45 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, May 29, 2017 at 2:57 PM, Arnd Bergmann <arnd@arndb.de> wrote:

>

>> The driver cannot access the of_node field when CONFIG_OF is disabled:

>>

>> drivers/gpio/gpio-ingenic.c: In function 'ingenic_gpio_probe':

>> drivers/gpio/gpio-ingenic.c:324:10: error: 'struct gpio_chip' has no member named 'of_node'

>>

>> Fixes: b0653ce39a0d ("gpio: Add gpio-ingenic driver")

>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

>

> I already sent a combined patch fixing these two deps earlier today,

> good that we are several at it :)


Hmm... issues like these are actually the reasons why the of_node member
of struct device does not depend on CONFIG_OF?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index fe25de1b187c..436c38cdb297 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -245,6 +245,7 @@  config GPIO_ICH
 config GPIO_INGENIC
 	tristate "Ingenic JZ47xx SoCs GPIO support"
 	depends on MACH_INGENIC || COMPILE_TEST
+	depends on OF
 	select GPIOLIB_IRQCHIP
 	help
 	  Say yes here to support the GPIO functionality present on the