[PATCHv5,2/3] driver: mmc: update debug info

Message ID 1496067064-27447-2-git-send-email-jorge.ramirez-ortiz@linaro.org
State Superseded
Headers show
Series
  • [PATCHv5,1/3] ARM64: dts: hi3798cv200-poplar: add device tree bindings
Related show

Commit Message

Jorge Ramirez-Ortiz May 29, 2017, 2:11 p.m.
This driver is used in another board; remove board information from
the driver debug log.

Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
---
 drivers/mmc/hi6220_dw_mmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jorge Ramirez-Ortiz June 7, 2017, 2:57 p.m. | #1
just a quick reminder that this is pending

cheers
jorge


On 05/29/2017 04:11 PM, Jorge Ramirez-Ortiz wrote:
> This driver is used in another board; remove board information from
> the driver debug log.
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> ---
>   drivers/mmc/hi6220_dw_mmc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/hi6220_dw_mmc.c b/drivers/mmc/hi6220_dw_mmc.c
> index fdaf1e4..d795198 100644
> --- a/drivers/mmc/hi6220_dw_mmc.c
> +++ b/drivers/mmc/hi6220_dw_mmc.c
> @@ -20,7 +20,7 @@
>   
>   static int hi6220_dwmci_core_init(struct dwmci_host *host, int index)
>   {
> -	host->name = "HiKey DWMMC";
> +	host->name = "Hisilicon DWMMC";
>   
>   	host->dev_index = index;
>
Simon Glass June 9, 2017, 12:27 p.m. | #2
Hi Jorge,

On 29 May 2017 at 08:11, Jorge Ramirez-Ortiz
<jorge.ramirez-ortiz@linaro.org> wrote:
> This driver is used in another board; remove board information from
> the driver debug log.
>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
> ---
>  drivers/mmc/hi6220_dw_mmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

The patch looks OK but I barely understand how it relates to you
commit message. Could you redo the commit message to make it clearer?

BTW this driver should move to driver model (CONFIG_DM_MMC and
CONFIG_BLK). See for example exynos_dw_mmc.c

- Simon

>
> diff --git a/drivers/mmc/hi6220_dw_mmc.c b/drivers/mmc/hi6220_dw_mmc.c
> index fdaf1e4..d795198 100644
> --- a/drivers/mmc/hi6220_dw_mmc.c
> +++ b/drivers/mmc/hi6220_dw_mmc.c
> @@ -20,7 +20,7 @@
>
>  static int hi6220_dwmci_core_init(struct dwmci_host *host, int index)
>  {
> -       host->name = "HiKey DWMMC";
> +       host->name = "Hisilicon DWMMC";
>
>         host->dev_index = index;
>
> --
> 2.7.4
>

Patch

diff --git a/drivers/mmc/hi6220_dw_mmc.c b/drivers/mmc/hi6220_dw_mmc.c
index fdaf1e4..d795198 100644
--- a/drivers/mmc/hi6220_dw_mmc.c
+++ b/drivers/mmc/hi6220_dw_mmc.c
@@ -20,7 +20,7 @@ 
 
 static int hi6220_dwmci_core_init(struct dwmci_host *host, int index)
 {
-	host->name = "HiKey DWMMC";
+	host->name = "Hisilicon DWMMC";
 
 	host->dev_index = index;