[11/15] mfd: palmas: use devm_of_platform_populate()

Message ID 1496072763-31209-12-git-send-email-benjamin.gaignard@linaro.org
State New
Headers show
Series
  • [01/15] iio: adc: stm32: use devm_of_platform_populate()
Related show

Commit Message

Benjamin Gaignard May 29, 2017, 3:45 p.m.
Use devm_of_platform_populate() to be sure that of_platform_depopulate
is called when removing the driver.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>


CC: Tony Lindgren <tony@atomide.com>
CC: Lee Jones <lee.jones@linaro.org>
CC: linux-kernel@vger.kernel.org
---
 drivers/mfd/palmas.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

Comments

Lee Jones May 30, 2017, 9:31 a.m. | #1
On Mon, 29 May 2017, Benjamin Gaignard wrote:

> Use devm_of_platform_populate() to be sure that of_platform_depopulate

> is called when removing the driver.

> 

> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>

> 

> CC: Tony Lindgren <tony@atomide.com>

> CC: Lee Jones <lee.jones@linaro.org>

> CC: linux-kernel@vger.kernel.org

> ---

>  drivers/mfd/palmas.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)


Applied, thanks.

> diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c

> index 9103aff..3922a93 100644

> --- a/drivers/mfd/palmas.c

> +++ b/drivers/mfd/palmas.c

> @@ -676,7 +676,7 @@ static int palmas_i2c_probe(struct i2c_client *i2c,

>  	 * otherwise continue and add devices using mfd helpers.

>  	 */

>  	if (node) {

> -		ret = of_platform_populate(node, NULL, NULL, &i2c->dev);

> +		ret = devm_of_platform_populate(&i2c->dev);

>  		if (ret < 0) {

>  			goto err_irq;

>  		} else if (pdata->pm_off && !pm_power_off) {


-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Patch

diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index 9103aff..3922a93 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -676,7 +676,7 @@  static int palmas_i2c_probe(struct i2c_client *i2c,
 	 * otherwise continue and add devices using mfd helpers.
 	 */
 	if (node) {
-		ret = of_platform_populate(node, NULL, NULL, &i2c->dev);
+		ret = devm_of_platform_populate(&i2c->dev);
 		if (ret < 0) {
 			goto err_irq;
 		} else if (pdata->pm_off && !pm_power_off) {