[13/15] mfd: smsc-ece: use devm_of_platform_populate()

Message ID 1496072763-31209-14-git-send-email-benjamin.gaignard@linaro.org
State New
Headers show
Series
  • [01/15] iio: adc: stm32: use devm_of_platform_populate()
Related show

Commit Message

Benjamin Gaignard May 29, 2017, 3:46 p.m.
Use devm_of_platform_populate() to be sure that of_platform_depopulate
is called when removing the driver.

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>


CC: Lee Jones <lee.jones@linaro.org>
CC: linux-kernel@vger.kernel.org
---
 drivers/mfd/smsc-ece1099.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
1.9.1

Comments

Lee Jones May 30, 2017, 9:32 a.m. | #1
On Mon, 29 May 2017, Benjamin Gaignard wrote:

> Use devm_of_platform_populate() to be sure that of_platform_depopulate

> is called when removing the driver.

> 

> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>

> 

> CC: Lee Jones <lee.jones@linaro.org>

> CC: linux-kernel@vger.kernel.org

> ---

>  drivers/mfd/smsc-ece1099.c | 3 +--

>  1 file changed, 1 insertion(+), 2 deletions(-)


Applied, thanks.

> diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c

> index 1f40baf..93a8297 100644

> --- a/drivers/mfd/smsc-ece1099.c

> +++ b/drivers/mfd/smsc-ece1099.c

> @@ -69,8 +69,7 @@ static int smsc_i2c_probe(struct i2c_client *i2c,

>  

>  #ifdef CONFIG_OF

>  	if (i2c->dev.of_node)

> -		ret = of_platform_populate(i2c->dev.of_node,

> -					   NULL, NULL, &i2c->dev);

> +		ret = devm_of_platform_populate(&i2c->dev);

>  #endif

>  

>  	return ret;


-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Patch

diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c
index 1f40baf..93a8297 100644
--- a/drivers/mfd/smsc-ece1099.c
+++ b/drivers/mfd/smsc-ece1099.c
@@ -69,8 +69,7 @@  static int smsc_i2c_probe(struct i2c_client *i2c,
 
 #ifdef CONFIG_OF
 	if (i2c->dev.of_node)
-		ret = of_platform_populate(i2c->dev.of_node,
-					   NULL, NULL, &i2c->dev);
+		ret = devm_of_platform_populate(&i2c->dev);
 #endif
 
 	return ret;