[Linaro-uefi,1/6] Platforms/AMD/Styx: remove unused PCD 'PcdStyxFdt'

Message ID 20170601094353.16235-2-ard.biesheuvel@linaro.org
State Accepted
Commit a94c26a568555121a1a2b2385dbec35e780929a1
Headers show
Series
  • OpenPlatformPkg/AMD updates
Related show

Commit Message

Ard Biesheuvel June 1, 2017, 9:43 a.m.
Remove the PCD 'PcdStyxFdt' which is no longer used now that we have
switched to the generic DtPlatformDxe driver.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 Platforms/AMD/Styx/AmdStyx.dec                                   | 3 ---
 Platforms/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf | 1 -
 2 files changed, 4 deletions(-)

Comments

Leif Lindholm June 1, 2017, 1:37 p.m. | #1
On Thu, Jun 01, 2017 at 09:43:48AM +0000, Ard Biesheuvel wrote:
> Remove the PCD 'PcdStyxFdt' which is no longer used now that we have
> switched to the generic DtPlatformDxe driver.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


> ---
>  Platforms/AMD/Styx/AmdStyx.dec                                   | 3 ---
>  Platforms/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf | 1 -
>  2 files changed, 4 deletions(-)
> 
> diff --git a/Platforms/AMD/Styx/AmdStyx.dec b/Platforms/AMD/Styx/AmdStyx.dec
> index 6624f8ca74a7..8d4b4927c6b1 100644
> --- a/Platforms/AMD/Styx/AmdStyx.dec
> +++ b/Platforms/AMD/Styx/AmdStyx.dec
> @@ -46,9 +46,6 @@
>    # CPUID Register
>    gAmdStyxTokenSpaceGuid.PcdCpuIdRegister|0xE0000010|UINT32|0x00000200
>  
> -  # FDT support
> -  gAmdStyxTokenSpaceGuid.PcdStyxFdt|{ 0xe4, 0x08, 0x0d, 0x04, 0x9a, 0x47, 0x4b, 0x42, 0x8c, 0x42, 0x36, 0x64, 0xdf, 0x79, 0x3f, 0x4b }|VOID*|0x00010000
> -
>    # Synopsys SATA Controller
>    gAmdStyxTokenSpaceGuid.PcdSata0CtrlAxiSlvPort|0xE0300000|UINT32|0x00020000
>    gAmdStyxTokenSpaceGuid.PcdSata0PortCount|8|UINT8|0x00020001
> diff --git a/Platforms/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf b/Platforms/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
> index f5ba5f1d1335..8bb6e9fa41cb 100644
> --- a/Platforms/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
> +++ b/Platforms/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
> @@ -41,7 +41,6 @@
>    UefiBootServicesTableLib
>  
>  [Pcd]
> -  gAmdStyxTokenSpaceGuid.PcdStyxFdt
>    gAmdStyxTokenSpaceGuid.PcdSocCpuId
>    gAmdStyxTokenSpaceGuid.PcdEthMacA
>    gAmdStyxTokenSpaceGuid.PcdEthMacB
> -- 
> 2.9.3
>

Patch

diff --git a/Platforms/AMD/Styx/AmdStyx.dec b/Platforms/AMD/Styx/AmdStyx.dec
index 6624f8ca74a7..8d4b4927c6b1 100644
--- a/Platforms/AMD/Styx/AmdStyx.dec
+++ b/Platforms/AMD/Styx/AmdStyx.dec
@@ -46,9 +46,6 @@ 
   # CPUID Register
   gAmdStyxTokenSpaceGuid.PcdCpuIdRegister|0xE0000010|UINT32|0x00000200
 
-  # FDT support
-  gAmdStyxTokenSpaceGuid.PcdStyxFdt|{ 0xe4, 0x08, 0x0d, 0x04, 0x9a, 0x47, 0x4b, 0x42, 0x8c, 0x42, 0x36, 0x64, 0xdf, 0x79, 0x3f, 0x4b }|VOID*|0x00010000
-
   # Synopsys SATA Controller
   gAmdStyxTokenSpaceGuid.PcdSata0CtrlAxiSlvPort|0xE0300000|UINT32|0x00020000
   gAmdStyxTokenSpaceGuid.PcdSata0PortCount|8|UINT8|0x00020001
diff --git a/Platforms/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf b/Platforms/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
index f5ba5f1d1335..8bb6e9fa41cb 100644
--- a/Platforms/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
+++ b/Platforms/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.inf
@@ -41,7 +41,6 @@ 
   UefiBootServicesTableLib
 
 [Pcd]
-  gAmdStyxTokenSpaceGuid.PcdStyxFdt
   gAmdStyxTokenSpaceGuid.PcdSocCpuId
   gAmdStyxTokenSpaceGuid.PcdEthMacA
   gAmdStyxTokenSpaceGuid.PcdEthMacB