[Linaro-uefi,6/6] Platforms/AMD/Styx: align UEFI PCI bus range with DT/ACPI descriptions

Message ID 20170601094353.16235-7-ard.biesheuvel@linaro.org
State Accepted
Commit 4ccbfd0ccf2f9d74fd057e3ae3c443aad9c97d63
Headers show
Series
  • OpenPlatformPkg/AMD updates
Related show

Commit Message

Ard Biesheuvel June 1, 2017, 9:43 a.m.
The DT and ACPI descriptions of the PCIe root complex only specify a
bus range of [0x0, 0x7f]. So let's use the same range in UEFI.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Leif Lindholm June 1, 2017, 1:46 p.m. | #1
On Thu, Jun 01, 2017 at 09:43:53AM +0000, Ard Biesheuvel wrote:
> The DT and ACPI descriptions of the PCIe root complex only specify a
> bus range of [0x0, 0x7f]. So let's use the same range in UEFI.
> 

Sounds like a good idea...
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>


> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc b/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc
> index b4893ca34587..98f5c9452dcd 100644
> --- a/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc
> +++ b/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc
> @@ -423,7 +423,7 @@ DEFINE DO_KCS       = 1
>    gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xF0000000
>  
>    gArmTokenSpaceGuid.PcdPciBusMin|0x0
> -  gArmTokenSpaceGuid.PcdPciBusMax|0xFF
> +  gArmTokenSpaceGuid.PcdPciBusMax|0x7F
>  
>    gArmTokenSpaceGuid.PcdPciIoBase|0x1000
>    gArmTokenSpaceGuid.PcdPciIoSize|0xF000
> -- 
> 2.9.3
>

Patch

diff --git a/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc b/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc
index b4893ca34587..98f5c9452dcd 100644
--- a/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc
+++ b/Platforms/AMD/Styx/OverdriveBoard/OverdriveBoard.dsc
@@ -423,7 +423,7 @@  DEFINE DO_KCS       = 1
   gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|0xF0000000
 
   gArmTokenSpaceGuid.PcdPciBusMin|0x0
-  gArmTokenSpaceGuid.PcdPciBusMax|0xFF
+  gArmTokenSpaceGuid.PcdPciBusMax|0x7F
 
   gArmTokenSpaceGuid.PcdPciIoBase|0x1000
   gArmTokenSpaceGuid.PcdPciIoSize|0xF000