diff mbox

[RESEND] ssb: mark ssb_bus_register as __maybe_unused

Message ID 4037550.DMaVTE01Aq@wuerfel
State Superseded
Headers show

Commit Message

Arnd Bergmann Jan. 14, 2016, 11:13 p.m. UTC 
The SoC variant of the ssb code is now optional like the other
ones, which means we can build the framwork without any
front-end, but that results in a warning:

drivers/ssb/main.c:616:12: warning: 'ssb_bus_register' defined but not used [-Wunused-function]

This annotates the ssb_bus_register function as __maybe_unused to
shut up the warning. A configuration like this will not work on
any hardware of course, but we still want this to silently build
without warnings if the configuration is allowed in the first
place.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Fixes: 845da6e58e19 ("ssb: add Kconfig entry for compiling SoC related code")
Acked-by: Michael Buesch <m@bues.ch>

---

On Thursday 14 January 2016 08:46:29 Kalle Valo wrote:
> I can take it. For historical reasons ssb patches go through my

> wireless-drivers trees.


I found this in my backlog, and I believe it still applies. Can you take
that one too?

Comments

Kalle Valo Jan. 16, 2016, 12:10 p.m. UTC | #1 
Arnd Bergmann <arnd@arndb.de> writes:

> On Thursday 14 January 2016 08:46:29 Kalle Valo wrote:

>> I can take it. For historical reasons ssb patches go through my

>> wireless-drivers trees.

>

> I found this in my backlog, and I believe it still applies. Can you take

> that one too?


I'm not sure what you mean here, I can take any ssb patch if it's ok for
Michael or Rafal :)

Just please submit the patch properly (with S-o-B line) and CC
linux-wireless so that it goes to patchwork.

-- 
Kalle Valo
Rafał Miłecki Jan. 16, 2016, 2:44 p.m. UTC | #2 
On 16 January 2016 at 13:10, Kalle Valo <kvalo@codeaurora.org> wrote:
> Arnd Bergmann <arnd@arndb.de> writes:

>

>> On Thursday 14 January 2016 08:46:29 Kalle Valo wrote:

>>> I can take it. For historical reasons ssb patches go through my

>>> wireless-drivers trees.

>>

>> I found this in my backlog, and I believe it still applies. Can you take

>> that one too?

>

> I'm not sure what you mean here, I can take any ssb patch if it's ok for

> Michael or Rafal :)

>

> Just please submit the patch properly (with S-o-B line) and CC

> linux-wireless so that it goes to patchwork.


It was already sent once and Acked by Michael:
https://patchwork.kernel.org/patch/7543191/

The problem was not cc-ing linux-wireless so it wasn't picked by the
linux-wireless patchwork.

-- 
Rafał
Kalle Valo Jan. 18, 2016, 8:26 a.m. UTC | #3 
Rafał Miłecki <zajec5@gmail.com> writes:

> On 16 January 2016 at 13:10, Kalle Valo <kvalo@codeaurora.org> wrote:

>> Arnd Bergmann <arnd@arndb.de> writes:

>>

>>> On Thursday 14 January 2016 08:46:29 Kalle Valo wrote:

>>>> I can take it. For historical reasons ssb patches go through my

>>>> wireless-drivers trees.

>>>

>>> I found this in my backlog, and I believe it still applies. Can you take

>>> that one too?

>>

>> I'm not sure what you mean here, I can take any ssb patch if it's ok for

>> Michael or Rafal :)

>>

>> Just please submit the patch properly (with S-o-B line) and CC

>> linux-wireless so that it goes to patchwork.

>

> It was already sent once and Acked by Michael:

> https://patchwork.kernel.org/patch/7543191/

>

> The problem was not cc-ing linux-wireless so it wasn't picked by the

> linux-wireless patchwork.


Ah, that's why I missed it. I only follow patchwork, I basically ignore
patches which are sent via email. Arnd, can you please resend the patch
and CC linux-wireless? Sorry for the trouble.

To avoid this in the future I think we should replace netdev with
linux-wireless in the MAINTAINERS entry:

SONICS SILICON BACKPLANE DRIVER (SSB)
M:      Michael Buesch <m@bues.ch>
L:      netdev@vger.kernel.org
S:      Maintained
F:      drivers/ssb/
F:      include/linux/ssb/

Are people ok with that? Patches welcome :)

-- 
Kalle Valo
diff mbox

Patch

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index cde5ff7529eb..d1a750760cf3 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -613,9 +613,10 @@  out:
 	return err;
 }
 
-static int ssb_bus_register(struct ssb_bus *bus,
-			    ssb_invariants_func_t get_invariants,
-			    unsigned long baseaddr)
+static int __maybe_unused
+ssb_bus_register(struct ssb_bus *bus,
+		 ssb_invariants_func_t get_invariants,
+		 unsigned long baseaddr)
 {
 	int err;