clocksource: ftm: select CLKSRC_MMIO

Message ID 11970328.RVc8t0Mk1C@wuerfel
State New
Headers show

Commit Message

Arnd Bergmann Jan. 13, 2016, 11:02 p.m.
The ftm clocksource driver does not build if CLKSRC_MMIO is disabled:

drivers/built-in.o: In function `ftm_timer_init':
(init.text+0xd324): undefined reference to `clocksource_mmio_init'
(init.text+0xd484): undefined reference to `clocksource_mmio_readl_up'

This adds the same 'select' statement that the other similar drivers
use. Prior to allowing this driver to be enabled with COMPILE_TEST,
it was apparently unused. I'm not entirely sure who is using this
hardware, but it certainly can't hurt to ensure it builds cleanly.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Fixes: ef49336bbd15 ("clocksource/drivers/fsl-ftm: Add the COMPILE_TEST option")

Comments

Daniel Lezcano Jan. 14, 2016, 9:25 a.m. | #1
On 01/14/2016 12:02 AM, Arnd Bergmann wrote:
> The ftm clocksource driver does not build if CLKSRC_MMIO is disabled:

>

> drivers/built-in.o: In function `ftm_timer_init':

> (init.text+0xd324): undefined reference to `clocksource_mmio_init'

> (init.text+0xd484): undefined reference to `clocksource_mmio_readl_up'

>

> This adds the same 'select' statement that the other similar drivers

> use. Prior to allowing this driver to be enabled with COMPILE_TEST,

> it was apparently unused. I'm not entirely sure who is using this

> hardware, but it certainly can't hurt to ensure it builds cleanly.


Hi Arnd,

Thanks for the fix. It is already in Thomas's tree [1].

It has been merged in tip/timers/urgent. You will have to wait a bit 
this branch to be merged with tip/timers/core.

   -- Daniel

[1] 
https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=timers/urgent&id=03724ac3d48f8f0e3caf1d30fa134f8fd96c94e2



-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Arnd Bergmann Jan. 14, 2016, 12:23 p.m. | #2
On Thursday 14 January 2016 10:25:40 Daniel Lezcano wrote:
> On 01/14/2016 12:02 AM, Arnd Bergmann wrote:

> > The ftm clocksource driver does not build if CLKSRC_MMIO is disabled:

> >

> > drivers/built-in.o: In function `ftm_timer_init':

> > (init.text+0xd324): undefined reference to `clocksource_mmio_init'

> > (init.text+0xd484): undefined reference to `clocksource_mmio_readl_up'

> >

> > This adds the same 'select' statement that the other similar drivers

> > use. Prior to allowing this driver to be enabled with COMPILE_TEST,

> > it was apparently unused. I'm not entirely sure who is using this

> > hardware, but it certainly can't hurt to ensure it builds cleanly.

> 

> Hi Arnd,

> 

> Thanks for the fix. It is already in Thomas's tree [1].


Ok, thanks for fixing it already! I'll mark this one as superceded
in my randconfig testing git tree then and will drop it as soon as
yours is merged.

	Arnd

Patch

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index b251013eef0a..d3ad9512312b 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -256,6 +256,7 @@  config CLKSRC_SAMSUNG_PWM
 config FSL_FTM_TIMER
 	bool "Freescale FlexTimer Module driver" if COMPILE_TEST
 	depends on GENERIC_CLOCKEVENTS
+	select CLKSRC_MMIO
 	help
 	  Support for Freescale FlexTimer Module (FTM) timer.