| Message ID | 8128014.DbbgBtKY3z@wuerfel |
|---|---|
| State | Superseded |
| Headers | show |
Arnd Bergmann <arnd@arndb.de> writes: > Drivers that use the SSB sprom functionality typically 'select SSB_SPROM' > from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in > a build failure unless at least one of the other drivers that selects > it is enabled: > > drivers/built-in.o: In function `ssb_host_soc_get_invariants': > (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback' > > This adds the same select statement that is used elsewhere. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch") > --- > I'm not sure who the right person is to pick up the fix. The patch that > introduced the problem was merged by Kalle through the iwlwifi tree. I can take it. For historical reasons ssb patches go through my wireless-drivers trees. -- Kalle Valo
On 13 January 2016 at 23:51, Arnd Bergmann <arnd@arndb.de> wrote: > Drivers that use the SSB sprom functionality typically 'select SSB_SPROM' > from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in > a build failure unless at least one of the other drivers that selects > it is enabled: > > drivers/built-in.o: In function `ssb_host_soc_get_invariants': > (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback' > > This adds the same select statement that is used elsewhere. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch") I missed this dependency, thanks, patch looks OK.
From: Kalle Valo <kvalo@codeaurora.org> Date: Thu, 14 Jan 2016 08:46:29 +0200 > I can take it. For historical reasons ssb patches go through my > wireless-drivers trees. +1
diff --git a/drivers/ssb/Kconfig b/drivers/ssb/Kconfig index 0c675861623f..d8e4219c2324 100644 --- a/drivers/ssb/Kconfig +++ b/drivers/ssb/Kconfig @@ -83,6 +83,7 @@ config SSB_SDIOHOST config SSB_HOST_SOC bool "Support for SSB bus on SoC" depends on SSB && BCM47XX_NVRAM + select SSB_SPROM help Host interface for a SSB directly mapped into memory. This is for some Broadcom SoCs from the BCM47xx and BCM53xx lines.
Drivers that use the SSB sprom functionality typically 'select SSB_SPROM' from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in a build failure unless at least one of the other drivers that selects it is enabled: drivers/built-in.o: In function `ssb_host_soc_get_invariants': (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback' This adds the same select statement that is used elsewhere. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch") --- I'm not sure who the right person is to pick up the fix. The patch that introduced the problem was merged by Kalle through the iwlwifi tree.