From patchwork Fri Jan 1 22:04:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 101189 Delivered-To: patch@linaro.org Received: by 10.112.130.2 with SMTP id oa2csp4153211lbb; Fri, 1 Jan 2016 14:04:49 -0800 (PST) X-Received: by 10.98.18.11 with SMTP id a11mr108810188pfj.7.1451685889551; Fri, 01 Jan 2016 14:04:49 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b86si20756933pfj.138.2016.01.01.14.04.49; Fri, 01 Jan 2016 14:04:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752262AbcAAWEs (ORCPT + 29 others); Fri, 1 Jan 2016 17:04:48 -0500 Received: from mout.kundenserver.de ([217.72.192.74]:63513 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751462AbcAAWEp (ORCPT ); Fri, 1 Jan 2016 17:04:45 -0500 Received: from wuerfel.localnet ([134.3.118.24]) by mrelayeu.kundenserver.de (mreue102) with ESMTPSA (Nemesis) id 0MLgGJ-1aEqYZ1g5j-000pos; Fri, 01 Jan 2016 23:04:12 +0100 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: David Airlie , Liviu Dudau , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: [PATCH 4/3] drm: arm-hdlcd: add explictit DRM dependency Date: Fri, 01 Jan 2016 23:04:07 +0100 Message-ID: <5213510.IMdSbsXdoQ@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <4194408.X82ccDjh5X@wuerfel> References: <4194408.X82ccDjh5X@wuerfel> MIME-Version: 1.0 X-Provags-ID: V03:K0:9sTAeplSWjU8hGiJSwze73q71GvRkLkazOX6XsSh4HsPST/Ise6 OGwcuzyj+/hSE2J/kFI5if4VZapj7pFmvyskpnZhk3ngaAS4KRs+YTrAD2Ow5G5US2jhQnL omdpkxWnWxIViLGhD+Ch4vriN70n7yZTnmVSWCM/H0OUTpEvHHfW9u6l9vKH4GS8PPNCg8j gbILBeI2RM6uZU9NDKv2A== X-UI-Out-Filterresults: notjunk:1; V01:K0:G8iD2xanN44=:sukhBhrfP1maRmcnxKiB1H uQCGs/5TEGF8VperBu8tdMus468tNeN+jb1mHUazIA9BO4ems+TVvUtXaziOlg4Dys9MudihI pscUDpou+hN/mX8M3snKIn1zxDZtgIw8ASoc5X/ICkyCtLNq9NSDwHDcELgspf1eB0y0RzE7S TwJctmf1dylabPHDT5WjxmhONA4OC+hRktgVgvOdIdz/R0f13bn5v/o3C6qeNaCqSO3q6Fvpk tGJqKhVf0dJu/N6VyWYRwgv4NF7j4KywdLkbj7SwCw8jf2a4x06trnyCzYfurkxVwNUwa1Rwl Vt8sVMquoNg7x40B6GxmpDv//+hSSWZFh9Lcjb2lhHCcXdHKUq2JE7TItoMtSFk4G7cBe2S8/ eJmT56W5FlXux253/K0IlH8xLMBruEniuctWVkuo0SewojudpjFX3AHtsqWFfwFwA+x0tCRi4 8pEFrk0L9XOPGa7Sepx2CJZyaXPWKVhT9nlFSGZnGCoTyWmkX2OEFasDhfHFiF4Jgo14aauaF 3lrPWNRMDFdnTmJ6HThhDgesxgZCOxIZ6w9U9uVgYGUqw6HL95OWO9aWcWUWX3MTi/UAihJTN YQbIDg1R0iMGRcWcuBUZwHXDLdYesifDbS+gzwtduo9u/FNNnQXDusJD1Rc40z9oo7EtFrQjx quKYgOQVRNZAI4gWpSNjINwBSbBkIeKDzxsfXG1KCt590rC8kJ9rnnR+DCk+gWVSq0gzpN1Nw t9FeP5ZP0W4p5pvX Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org CONFIG_DRM_HDLCD is a tristate option that depends on the boolean CONFIG_DRM_ARM, which in turn depends on the tristate CONFIG_DRM. The effect of this is that a configuration with CONFIG_DRM=m and CONFIG_DRM_HDLCD=y can be chosen, but won't link because the DRM core symbols are not reachable from builtin code: drivers/built-in.o: In function `hdlcd_drm_unbind': drivers/gpu/drm/arm/hdlcd_drv.c:445: undefined reference to `drm_fbdev_cma_fini' drivers/gpu/drm/arm/hdlcd_drv.c:448: undefined reference to `drm_kms_helper_poll_fini' drivers/gpu/drm/arm/hdlcd_drv.c:450: undefined reference to `drm_vblank_cleanup' drivers/gpu/drm/arm/hdlcd_drv.c:452: undefined reference to `drm_irq_uninstall' drivers/gpu/drm/arm/hdlcd_drv.c:460: undefined reference to `drm_mode_config_cleanup' drivers/gpu/drm/arm/hdlcd_drv.c:461: undefined reference to `drm_dev_unregister' drivers/gpu/drm/arm/hdlcd_drv.c:462: undefined reference to `drm_dev_unref' ... This adds another dependency on CONFIG_DRM to enforce that DRM_HDLCD cannot be builtin if DRM is not. Signed-off-by: Arnd Bergmann --- Ok, I found yet another one after a few hundred extra randconfig builds on today's next. Let me know if you'd rather have the three Kconfig changes combined into a single patch, it's starting to get ridiculous. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig index 81ea7802ca50..487fb1f0c979 100644 --- a/drivers/gpu/drm/arm/Kconfig +++ b/drivers/gpu/drm/arm/Kconfig @@ -7,7 +7,7 @@ config DRM_ARM config DRM_HDLCD tristate "ARM HDLCD" - depends on DRM_ARM + depends on DRM_ARM && DRM depends on COMMON_CLK select DRM_KMS_CMA_HELPER select DRM_GEM_CMA_HELPER