diff mbox

davinci: omapl138_lcdk: fix tXSNR DDR2 timing value

Message ID 20170602123712.20168-1-nsekhar@ti.com
State Accepted
Commit 264e420f365cd673a0076adfcb975ead7139aedc
Headers show

Commit Message

Sekhar Nori June 2, 2017, 12:37 p.m. UTC
As per the datasheet[1] available for DDR2 part on board
the OMAP-L138 LCDK, the tXSNR (exit self refresh to a
non-read command) is 137.5 ns. This corresponds to a
value of 20 to be written to T_XSNR register field of
OMAP-L138's DDR configuration. The DDR2 is at 150 MHz.

Fix this. The correct value also appears on the initialization
scripts (called CCS GEL files) available on TI's wiki pages[2]

[1] http://www.samsung.com/global/business/semiconductor/file/product/ds_k4t1gxx4qf_rev12-0.pdf
[2] http://processors.wiki.ti.com/index.php/L138/C6748_Development_Kit_(LCDK)#CCS_XML_.26_GEL_Files

Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 include/configs/omapl138_lcdk.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini June 2, 2017, 2:04 p.m. UTC | #1
On Fri, Jun 02, 2017 at 06:07:12PM +0530, Sekhar Nori wrote:

> As per the datasheet[1] available for DDR2 part on board

> the OMAP-L138 LCDK, the tXSNR (exit self refresh to a

> non-read command) is 137.5 ns. This corresponds to a

> value of 20 to be written to T_XSNR register field of

> OMAP-L138's DDR configuration. The DDR2 is at 150 MHz.

> 

> Fix this. The correct value also appears on the initialization

> scripts (called CCS GEL files) available on TI's wiki pages[2]

> 

> [1] http://www.samsung.com/global/business/semiconductor/file/product/ds_k4t1gxx4qf_rev12-0.pdf

> [2] http://processors.wiki.ti.com/index.php/L138/C6748_Development_Kit_(LCDK)#CCS_XML_.26_GEL_Files

> 

> Signed-off-by: Sekhar Nori <nsekhar@ti.com>


Reviewed-by: Tom Rini <trini@konsulko.com>


-- 
Tom
Tom Rini June 10, 2017, 1:46 p.m. UTC | #2
On Fri, Jun 02, 2017 at 06:07:12PM +0530, Sekhar Nori wrote:

> As per the datasheet[1] available for DDR2 part on board

> the OMAP-L138 LCDK, the tXSNR (exit self refresh to a

> non-read command) is 137.5 ns. This corresponds to a

> value of 20 to be written to T_XSNR register field of

> OMAP-L138's DDR configuration. The DDR2 is at 150 MHz.

> 

> Fix this. The correct value also appears on the initialization

> scripts (called CCS GEL files) available on TI's wiki pages[2]

> 

> [1] http://www.samsung.com/global/business/semiconductor/file/product/ds_k4t1gxx4qf_rev12-0.pdf

> [2] http://processors.wiki.ti.com/index.php/L138/C6748_Development_Kit_(LCDK)#CCS_XML_.26_GEL_Files

> 

> Signed-off-by: Sekhar Nori <nsekhar@ti.com>

> Reviewed-by: Tom Rini <trini@konsulko.com>


Applied to u-boot/master, thanks!

-- 
Tom
diff mbox

Patch

diff --git a/include/configs/omapl138_lcdk.h b/include/configs/omapl138_lcdk.h
index 9db4eeb54edf..88cdf08b1979 100644
--- a/include/configs/omapl138_lcdk.h
+++ b/include/configs/omapl138_lcdk.h
@@ -110,7 +110,7 @@ 
 	(7 << DV_DDR_SDTMR2_RASMAX_SHIFT)	| \
 	(2 << DV_DDR_SDTMR2_XP_SHIFT)		| \
 	(0 << DV_DDR_SDTMR2_ODT_SHIFT)		| \
-	(10 << DV_DDR_SDTMR2_XSNR_SHIFT)	| \
+	(20 << DV_DDR_SDTMR2_XSNR_SHIFT)	| \
 	(199 << DV_DDR_SDTMR2_XSRD_SHIFT)	| \
 	(1 << DV_DDR_SDTMR2_RTP_SHIFT)		| \
 	(2 << DV_DDR_SDTMR2_CKE_SHIFT))