diff mbox

configs: omapl138_lcdk: dont disable fat write

Message ID 20170606114153.2569-1-nsekhar@ti.com
State Accepted
Commit 39f0819125834774e431a55d61f5d78ce7691819
Headers show

Commit Message

Sekhar Nori June 6, 2017, 11:41 a.m. UTC
CONFIG_FAT_WRITE is imply'ed when CONFIG_CMD_FAT
is selected (see CONFIG_TI_COMMON_CMD_OPTIONS).

Dont disable it in defconfig so the imply takes
effect and 'fatwrite' is available for users.

Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 configs/omapl138_lcdk_defconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Tom Rini June 6, 2017, 1:28 p.m. UTC | #1
On Tue, Jun 06, 2017 at 05:11:53PM +0530, Sekhar Nori wrote:

> CONFIG_FAT_WRITE is imply'ed when CONFIG_CMD_FAT

> is selected (see CONFIG_TI_COMMON_CMD_OPTIONS).

> 

> Dont disable it in defconfig so the imply takes

> effect and 'fatwrite' is available for users.

> 

> Signed-off-by: Sekhar Nori <nsekhar@ti.com>


I was hoping it would come down to something like this, thanks.

Reviewed-by: Tom Rini <trini@konsulko.com>


-- 
Tom
Tom Rini June 10, 2017, 1:47 p.m. UTC | #2
On Tue, Jun 06, 2017 at 05:11:53PM +0530, Sekhar Nori wrote:

> CONFIG_FAT_WRITE is imply'ed when CONFIG_CMD_FAT

> is selected (see CONFIG_TI_COMMON_CMD_OPTIONS).

> 

> Dont disable it in defconfig so the imply takes

> effect and 'fatwrite' is available for users.

> 

> Signed-off-by: Sekhar Nori <nsekhar@ti.com>

> Reviewed-by: Tom Rini <trini@konsulko.com>


Applied to u-boot/master, thanks!

-- 
Tom
diff mbox

Patch

diff --git a/configs/omapl138_lcdk_defconfig b/configs/omapl138_lcdk_defconfig
index b5d14d2cc45d..c6f474a9b2b0 100644
--- a/configs/omapl138_lcdk_defconfig
+++ b/configs/omapl138_lcdk_defconfig
@@ -31,5 +31,4 @@  CONFIG_SPI_FLASH=y
 CONFIG_SPI_FLASH_STMICRO=y
 CONFIG_SPI_FLASH_WINBOND=y
 CONFIG_SYS_NS16550=y
-# CONFIG_FAT_WRITE is not set
 CONFIG_OF_LIBFDT=y