From patchwork Wed Jun 7 21:13:30 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoffer Dall X-Patchwork-Id: 103316 Delivered-To: patch@linaro.org Received: by 10.140.91.77 with SMTP id y71csp2136099qgd; Wed, 7 Jun 2017 14:13:59 -0700 (PDT) X-Received: by 10.237.44.197 with SMTP id g63mr2485405qtd.241.1496870039415; Wed, 07 Jun 2017 14:13:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1496870039; cv=none; d=google.com; s=arc-20160816; b=JF8D4Q8S5U5Wolh3Efc77LAeJ+iok8i9dxYt6TEnzVtQJW4URfyJKVNyFSOJA5N7/h qa8/AhFe/J0GpxyvEVS03Ou3thyCefSnEnruk/aaDXfByTRK5QBVJK+k02HyNMWHfRr9 OzUOONDmq/wWYv7sAs/PcdhEIliKj7ajAMX9Dbx6wrmkZwhnLSgeb3auPqR82vqvOCU5 09Bo2lx6T2hFATnBeZiaIzLxifErBZRxMnkrHdXU/um2nLkPZwERWhkd9YZsHR8Jx67f g6L62Rqwv1W/XJi68ksgL/vc10X6yM8uBI6APzIIs0u9gybpuj0LzXjwonaDR7t+Umjb qKxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:message-id:date:to:from :dkim-signature:dkim-filter:dmarc-filter:delivered-to:dkim-filter :dmarc-filter:arc-authentication-results; bh=0/2GNC/IdCRrdugxPnlP4Fzy0hAc+E+3n2qeU96Ki5I=; b=jsuy7OOSfzWmsMJP/4ufqfRWg5yDXxoJF9JwghMpW/BmKQCOe/7AkjbXdQPQh3dpwR LRRprJJNQjbIfUMzrsSksJGPieDBmLpSFEdcJ9cvGPsvn9LQvDHeDo+jQ0FpvjdDl7NN eGmKjKpbSdrsi5BrDizO0btkcBD6jjvbAx4ppi+Ej9L+ATAT5+4vIFe+gM7+ItTcAMmy MQrLvn1hXRzDm9QpWvh9ZZxkqwVhr3xW8G1DiKho6imvtd4EL+A/pe41XYBs2VVY1fWY pcY1yoa1pT9/ey8bIU8D0vcvovCxaqZpAq7Y47l8mwaWdPbJ859w9ymVEWgs6KrYgmie M7Eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id s17si3193618qta.141.2017.06.07.14.13.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Jun 2017 14:13:59 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8FA7AC0587C5; Wed, 7 Jun 2017 21:13:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8FA7AC0587C5 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=libvir-list-bounces@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8FA7AC0587C5 Authentication-Results: mx1.redhat.com; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="FnddCyo2" Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F0FD418A53; Wed, 7 Jun 2017 21:13:55 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id BCCDF4BB7F; Wed, 7 Jun 2017 21:13:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id v57LDo00009051 for ; Wed, 7 Jun 2017 17:13:50 -0400 Received: by smtp.corp.redhat.com (Postfix) id D920B18A53; Wed, 7 Jun 2017 21:13:50 +0000 (UTC) Delivered-To: libvir-list@redhat.com Received: from mx1.redhat.com (ext-mx08.extmail.prod.ext.phx2.redhat.com [10.5.110.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D3DD318AB7 for ; Wed, 7 Jun 2017 21:13:49 +0000 (UTC) Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 784E5C0587C4 for ; Wed, 7 Jun 2017 21:13:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 784E5C0587C4 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=cdall@linaro.org DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 784E5C0587C4 Received: by mail-wm0-f54.google.com with SMTP id d64so11463211wmf.1 for ; Wed, 07 Jun 2017 14:13:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Hee8sS/oRjHvi5kMA77f09EwNS9BWKk3Gg4Jy7V9T30=; b=FnddCyo29K6iPoU36ORG12JOorKsG4Vax97TyrNy6Yr2Nlc5YslzjkD8EpAXs5J/1J d41461myYk2yOh8A0JvOpprZUpYPztmAe5VRO2GHSPajJ0J3mIEOObdZuK39xYL92QdC RQSb//IrM44weFQQU2cyqm5pu2ssp9FHNL6+4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Hee8sS/oRjHvi5kMA77f09EwNS9BWKk3Gg4Jy7V9T30=; b=L9NADQ1IRu7C3V+b9p4YjjdTzdvdT6P3YI/p3QSStN8smGFOSRt6VdLF7LZeSlSVxx NZlt2Bfe4amdUuvUAaPR9LBLB/tz3Mq7lYJrDZscBmwOaQjGAgtl+rsaVBQIFs9n1lPz nIb3NghWYy83/hLcOrONdY58Ov8UjuGh6SHg4cedRuneP8YYx0nwJFnEWK7GSfQrgYzS W8RPJpndm4knjqLbrImIvXYnjgtZrJr3JX7LFonUy0aPYJxq8/NL3dOuMnTNymmkOkZd WZqvsAHNLq4nRQDdypaFouhV7qTUrdwycMyosm9iRE/s5GadSJ3/9viFGv5R7K+mXwTO uUqA== X-Gm-Message-State: AODbwcBX3H7GoMx4VIpOSMMkBJhiYPti8gDa9OTStuPAimj2C6tyWm7A ZXtdiP8PbfrEILEEOauHQQ== X-Received: by 10.80.164.241 with SMTP id x46mr26142797edb.114.1496870025977; Wed, 07 Jun 2017 14:13:45 -0700 (PDT) Received: from localhost.localdomain (xd93ddc2d.cust.hiper.dk. [217.61.220.45]) by smtp.gmail.com with ESMTPSA id e18sm1388613edd.27.2017.06.07.14.13.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 07 Jun 2017 14:13:45 -0700 (PDT) From: Christoffer Dall To: libvir-list@redhat.com Date: Wed, 7 Jun 2017 23:13:30 +0200 Message-Id: <20170607211330.13266-1-cdall@linaro.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 07 Jun 2017 21:13:48 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 07 Jun 2017 21:13:48 +0000 (UTC) for IP:'74.125.82.54' DOMAIN:'mail-wm0-f54.google.com' HELO:'mail-wm0-f54.google.com' FROM:'cdall@linaro.org' RCPT:'' X-RedHat-Spam-Score: 0.269 (BAYES_50, DCC_REPUT_00_12, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_PASS) 74.125.82.54 mail-wm0-f54.google.com 74.125.82.54 mail-wm0-f54.google.com X-Scanned-By: MIMEDefang 2.78 on 10.5.110.32 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Christoffer Dall Subject: [libvirt] [PATCH] qemu: Support chardevs with ARM virt machines X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 07 Jun 2017 21:13:58 +0000 (UTC) The function to check if -chardev is supported by QEMU was written a long time ago, where adding chardevs did not make sense on the fixed ARM platforms. Since then, we now have a general purpose virt platform, which should support plugging in any device over PCIe which is supported in a similar fashion on x86. Signed-off-by: Christoffer Dall --- src/qemu/qemu_capabilities.c | 5 +++++ 1 file changed, 5 insertions(+) -- 2.9.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list Reviewed-by: Andrea Bolognani diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 7f22492..1348af7 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -5507,6 +5507,11 @@ virQEMUCapsSupportsChardev(const virDomainDef *def, if ((def->os.arch != VIR_ARCH_ARMV7L) && (def->os.arch != VIR_ARCH_AARCH64)) return true; + /* The virt machine has a PCIe bus and allows plugging in the same type of + * devices as x86 systems do on a PCIe bus. */ + if (qemuDomainIsVirt(def)) + return true; + /* This may not be true for all ARM machine types, but at least * the only supported non-virtio serial devices of vexpress and versatile * don't have the -chardev property wired up. */