| Message ID | 20170609102304.2896514-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | aca4e68acf3a08561f2a413322cbb232edad8764 |
| Headers | show |
On 2017-06-09 12:22, Arnd Bergmann wrote: > COMPILE_TEST makes no sense when I2C is disabled, as the driver cannot compile > in that configuration: Ouch, thanks for catching! Reviewed-by: Peter Rosin <peda@axentia.se> Greg, I assume you will you be taking this? Cheers, peda
On Fri, Jun 09, 2017 at 12:31:10PM +0200, Peter Rosin wrote: > On 2017-06-09 12:22, Arnd Bergmann wrote: > > COMPILE_TEST makes no sense when I2C is disabled, as the driver cannot compile > > in that configuration: > > Ouch, thanks for catching! > > Reviewed-by: Peter Rosin <peda@axentia.se> > > Greg, I assume you will you be taking this? Yes, will do so now, thanks. greg k-h
diff --git a/drivers/mux/Kconfig b/drivers/mux/Kconfig index e8f1df74644c..7c754a0f14bb 100644 --- a/drivers/mux/Kconfig +++ b/drivers/mux/Kconfig @@ -19,7 +19,7 @@ if MULTIPLEXER config MUX_ADG792A tristate "Analog Devices ADG792A/ADG792G Multiplexers" - depends on I2C || COMPILE_TEST + depends on I2C help ADG792A and ADG792G Wide Bandwidth Triple 4:1 Multiplexers
COMPILE_TEST makes no sense when I2C is disabled, as the driver cannot compile in that configuration: drivers/mux/mux-adg792a.c: In function 'adg792a_write_cmd': drivers/mux/mux-adg792a.c:34:9: error: implicit declaration of function 'i2c_smbus_write_byte_data'; did you mean 'i2c_set_clientdata'? [-Werror=implicit-function-declaration] drivers/mux/mux-adg792a.o: In function `adg792a_driver_init': mux-adg792a.c:(.init.text+0x14): undefined reference to `i2c_register_driver' drivers/mux/mux-adg792a.o: In function `adg792a_probe': mux-adg792a.c:(.text.adg792a_probe+0x94): undefined reference to `i2c_smbus_write_byte_data' drivers/mux/mux-adg792a.o: In function `adg792a_set': mux-adg792a.c:(.text.adg792a_set+0x80): undefined reference to `i2c_smbus_write_byte_data' Fixes: afda08c4caa9 ("mux: adg792a: add mux controller driver for ADG792A/G") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/mux/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.0