diff mbox series

[PULL,1/1] block/gluster.c: Handle qdict_array_entries() failure

Message ID 20170609124313.8026-2-jcody@redhat.com
State Accepted
Commit 56faeb9bb6872b3f926b3b3e0452a70beea10af2
Headers show
Series [PULL,1/1] block/gluster.c: Handle qdict_array_entries() failure | expand

Commit Message

Jeff Cody June 9, 2017, 12:43 p.m. UTC 
From: Peter Maydell <peter.maydell@linaro.org>


In qemu_gluster_parse_json(), the call to qdict_array_entries()
could return a negative error code, which we were ignoring
because we assigned the result to an unsigned variable.
Fix this by using the 'int' type instead, which matches the
return type of qdict_array_entries() and also the type
we use for the loop enumeration variable 'i'.

(Spotted by Coverity, CID 1360960.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Eric Blake <eblake@redhat.com>

Reviewed-by: Jeff Cody <jcody@redhat.com>

Message-id: 1496682098-1540-1-git-send-email-peter.maydell@linaro.org
Signed-off-by: Jeff Cody <jcody@redhat.com>

---
 block/gluster.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.9.3
diff mbox series

Patch

diff --git a/block/gluster.c b/block/gluster.c
index 031596a..addceed 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -493,8 +493,7 @@  static int qemu_gluster_parse_json(BlockdevOptionsGluster *gconf,
     Error *local_err = NULL;
     char *str = NULL;
     const char *ptr;
-    size_t num_servers;
-    int i, type;
+    int i, type, num_servers;
 
     /* create opts info from runtime_json_opts list */
     opts = qemu_opts_create(&runtime_json_opts, NULL, 0, &error_abort);