Applied "ASoC: intel: atom: localize variable without external linkage" to the asoc tree

Message ID E1dAAxY-0002P1-09@finisterre
State New
Headers show

Commit Message

Mark Brown May 15, 2017, 8:02 a.m.
The patch

   ASoC: intel: atom: localize variable without external linkage

has been applied to the asoc tree at


All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.


From 65db85fba1df213ff80d6f3cbafee244c58f6ec3 Mon Sep 17 00:00:00 2001
From: Takashi Sakamoto <>

Date: Tue, 2 May 2017 22:33:03 +0900
Subject: [PATCH] ASoC: intel: atom: localize variable without external linkage

A driver for Intel SST driver for old atom platform includes a variable
which has no external linkage. These functions should have static

This commit adds the qualifier to localize the variable. This issue is
detected by sparse:

sst.c:261:1: warning: symbol 'dev_attr_firmware_version' was not declared. Should it be static?

Cc: Sebastien Guiriec <>
Cc: Vinod Koul <>
Signed-off-by: Takashi Sakamoto <>

Signed-off-by: Mark Brown <>

 sound/soc/intel/atom/sst/sst.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Alsa-devel mailing list


diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c
index f9ba71315e33..d97556a3772c 100644
--- a/sound/soc/intel/atom/sst/sst.c
+++ b/sound/soc/intel/atom/sst/sst.c
@@ -258,7 +258,7 @@  static ssize_t firmware_version_show(struct device *dev,
+static DEVICE_ATTR_RO(firmware_version);
 static const struct attribute *sst_fw_version_attrs[] = {