Applied "ASoC: Intel: Skylake: Create ASoC jack for hdmi in skl_nau88l25_max98357a machine" to the asoc tree

Message ID E1ceRLy-0007Zn-6Q@debutante
State Superseded
Headers show

Commit Message

Mark Brown Feb. 16, 2017, 7:04 p.m.
The patch

   ASoC: Intel: Skylake: Create ASoC jack for hdmi in skl_nau88l25_max98357a machine

has been applied to the asoc tree at


All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.


From c541b2dd45042c1e031778e0229d032dff90f045 Mon Sep 17 00:00:00 2001
From: Jeeja KP <>

Date: Tue, 7 Feb 2017 19:09:51 +0530
Subject: [PATCH] ASoC: Intel: Skylake: Create ASoC jack for hdmi in
 skl_nau88l25_max98357a machine

Creates ASoC jack for HDMI PCM and calls hdmi codec API to initialize
jack in skl_nau88l25_max98357a machine

Signed-off-by: Jeeja KP <>

Acked-by: Vinod Koul <>

Signed-off-by: Mark Brown <>

 sound/soc/intel/boards/skl_nau88l25_max98357a.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)


Alsa-devel mailing list


diff --git a/sound/soc/intel/boards/skl_nau88l25_max98357a.c b/sound/soc/intel/boards/skl_nau88l25_max98357a.c
index bb4196867752..48f7c96b3f3d 100644
--- a/sound/soc/intel/boards/skl_nau88l25_max98357a.c
+++ b/sound/soc/intel/boards/skl_nau88l25_max98357a.c
@@ -32,6 +32,7 @@ 
 static struct snd_soc_jack skylake_headset;
 static struct snd_soc_card skylake_audio_card;
 static const struct snd_pcm_hw_constraint_list *dmic_constraints;
+static struct snd_soc_jack skylake_hdmi[3];
 struct skl_hdmi_pcm {
 	struct list_head head;
@@ -603,16 +604,31 @@  static struct snd_soc_dai_link skylake_dais[] = {
+#define NAME_SIZE	32
 static int skylake_card_late_probe(struct snd_soc_card *card)
 	struct skl_nau8825_private *ctx = snd_soc_card_get_drvdata(card);
 	struct skl_hdmi_pcm *pcm;
-	int err;
+	int err, i = 0;
+	char jack_name[NAME_SIZE];
 	list_for_each_entry(pcm, &ctx->hdmi_pcm_list, head) {
-		err = hdac_hdmi_jack_init(pcm->codec_dai, pcm->device);
+		snprintf(jack_name, sizeof(jack_name),
+			"HDMI/DP, pcm=%d Jack", pcm->device);
+		err = snd_soc_card_jack_new(card, jack_name,
+					&skylake_hdmi[i],
+					NULL, 0);
+		if (err)
+			return err;
+		err = hdac_hdmi_jack_init(pcm->codec_dai, pcm->device,
+						&skylake_hdmi[i]);
 		if (err < 0)
 			return err;
+		i++;
 	return 0;