diff mbox

spi: Add cond_resched() in main message processing loop

Message ID 1455561281-18573-1-git-send-email-broonie@kernel.org
State Accepted
Commit 628269704f19fcfc765499b7158effccfc79b6cf
Headers show

Commit Message

Mark Brown Feb. 15, 2016, 6:34 p.m. UTC
When a controller has only PIO support it is very likely that we will
run into use cases where we spend a very large amount of time consuming
CPU.  Code that does this should call cond_resched() every once in a
while to give other tasks more of a chance to run so do that in the main
SPI loop, the overhead is negligable if it's not needed.

Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mark Brown <broonie@kernel.org>

---
 drivers/spi/spi.c | 3 +++
 1 file changed, 3 insertions(+)

-- 
2.7.0

--
To unsubscribe from this list: send the line "unsubscribe linux-spi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 0ad55946e388..4252a112985c 100644
--- a/drivers/spi/spi.c
+++ b/drivers/spi/spi.c
@@ -1207,6 +1207,9 @@  static void __spi_pump_messages(struct spi_master *master, bool in_kthread)
 		return;
 	}
 	mutex_unlock(&master->bus_lock_mutex);
+
+	/* Prod the scheduler in case transfer_one() was busy waiting */
+	cond_resched();
 }
 
 /**