diff mbox series

[1/2] regmap: Return an error if a caller attempts to do an unsupported raw read

Message ID 1454415411-14404-1-git-send-email-festevam@gmail.com
State New
Headers show
Series [1/2] regmap: Return an error if a caller attempts to do an unsupported raw read | expand

Commit Message

Fabio Estevam Feb. 2, 2016, 12:16 p.m. UTC 
From: Mark Brown <broonie@kernel.org>


regmaps without raw I/O access can't implement raw I/O operations,
return an error if someone tries to do that rather than crashing.

Signed-off-by: Mark Brown <broonie@kernel.org>

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

---
 drivers/base/regmap/regmap.c | 3 +++
 1 file changed, 3 insertions(+)

-- 
1.9.1
diff mbox series

Patch

diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
index 3432634..e2f6880 100644
--- a/drivers/base/regmap/regmap.c
+++ b/drivers/base/regmap/regmap.c
@@ -2255,6 +2255,9 @@  static int _regmap_raw_read(struct regmap *map, unsigned int reg, void *val,
 
 	WARN_ON(!map->bus);
 
+	if (!map->bus || !map->bus->read)
+		return -EINVAL;
+
 	range = _regmap_range_lookup(map, reg);
 	if (range) {
 		ret = _regmap_select_page(map, &reg, range,