Applied "ASoC: Intel: Skylake: fix memory leak" to the asoc tree

Message ID E1a0pUS-0005Rg-Nh@debutante
State New
Headers show

Commit Message

Mark Brown Nov. 23, 2015, 11:41 a.m.
The patch

   ASoC: Intel: Skylake: fix memory leak

has been applied to the asoc tree at


All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.


From 87b5ed8ecb9fe05a696e1c0b53c7a49ea66432c1 Mon Sep 17 00:00:00 2001
From: Sudip Mukherjee <>

Date: Mon, 23 Nov 2015 16:38:48 +0530
Subject: [PATCH] ASoC: Intel: Skylake: fix memory leak

We have requested the firmware but missed releasing it.

Signed-off-by: Sudip Mukherjee <>

Signed-off-by: Mark Brown <>

 sound/soc/intel/skylake/skl-topology.c | 1 +
 1 file changed, 1 insertion(+)


Alsa-devel mailing list


diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c
index a7854c8fc523..ffea427aeca8 100644
--- a/sound/soc/intel/skylake/skl-topology.c
+++ b/sound/soc/intel/skylake/skl-topology.c
@@ -1240,6 +1240,7 @@  int skl_tplg_init(struct snd_soc_platform *platform, struct hdac_ext_bus *ebus)
 	ret = snd_soc_tplg_component_load(&platform->component,
 					&skl_tplg_ops, fw, 0);
+	release_firmware(fw);
 	if (ret < 0) {
 		dev_err(bus->dev, "tplg component load failed%d\n", ret);
 		return -EINVAL;