From patchwork Tue Jun 13 16:13:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 105381 Delivered-To: patch@linaro.org Received: by 10.140.91.77 with SMTP id y71csp486295qgd; Tue, 13 Jun 2017 09:15:09 -0700 (PDT) X-Received: by 10.107.18.15 with SMTP id a15mr758540ioj.189.1497370509603; Tue, 13 Jun 2017 09:15:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1497370509; cv=none; d=google.com; s=arc-20160816; b=NifalP+jKhbnwSdcb1t4sD94sGLeBhGjqQXfG/OKO9c42MD6ruiXPEABNxqmjIOcM2 KTpx4fY7mx207//coKjb6kHnGYVfBiQ9xPZ57oPAHqzaxKBE8ne44C6yLPWtPV3A3cgm pJmXaTV/EFaTZ0Hh7GCSOPJSRpw6sjQcjaHTVT1gzGSY2kHilXJA74HIxcrmpoBcFG6I zn5nPjaTzMdWh1enFb+vVhWEjiEvq2cXQBUb9ux3eR0FFu+RvPYh7nnOBanYBt7DoOE4 ee1GVpXSlWVskQRlIOpR9ftYXjuy73SdAzkwON8cVV5kXJYPMiu/OFZtL1vKVGIHbEVJ oS9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:cc:references:in-reply-to:message-id:date:to :from:arc-authentication-results; bh=j/l7eugevNuE+5HkuD8qrPrloFjduVCf6WX0iKCi5gg=; b=QizoVJU4vVhNrbfZA13CpRuwAkY/v4Ym3gSJPfnQMxj51Zqb1/2OQ05BovSzY/TZn1 ZBfPzIFFcL9fmUv9QrjH+l8ZedmRpH6xSUVz3y8mXi46+eFO83MV4b6A4t47hOv3mHbG K/JF7CCMR0QTWYqCN1Qq07+ogDbu7703UBwAHvcsFTsGC1s4wXfZNiWSPF6tNrdSLU4k DrTEVNJanr+SK/YdBZYS0CVqru0n6l8QsffDfCYz1cdw0/6FMS0bpM69guaodtR7FotE 9rwwJSCjiSeqd2IiMcjq3bFsobW/UIbswG6p+BvFbO9ZhIp4oFhQm+v1hz4yyVagHs0j /0UQ== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id w196si407000iow.24.2017.06.13.09.15.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Jun 2017 09:15:09 -0700 (PDT) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKoRx-0008Ig-LQ; Tue, 13 Jun 2017 16:13:49 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dKoRw-0008Fq-N8 for xen-devel@lists.xen.org; Tue, 13 Jun 2017 16:13:48 +0000 Received: from [85.158.139.211] by server-7.bemta-5.messagelabs.com id 6D/3D-02181-C3F00495; Tue, 13 Jun 2017 16:13:48 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRWlGSWpSXmKPExsVysyfVTdeE3yH SoOe/tcWSj4tZHBg9ju7+zRTAGMWamZeUX5HAmnHy1wu2gmUGFcfuzmJuYDyj0sXIySEksJlR YvmM3C5GLiD7NKPEqT+rmEASbAKaEnc+fwKzRQSkJa59vswIYjMLREg0LdgLFOfgEBbwkPjx0 QkkzCKgKnFn005WEJtXwFJi14SJbCC2hIC8xK62i2BxTgEriUvPmxgh9lpKNO9ezzSBkXsBI8 MqRo3i1KKy1CJdQ0O9pKLM9IyS3MTMHF1DA1O93NTi4sT01JzEpGK95PzcTYxA7zIAwQ7Gle3 OhxglOZiURHm3XLGJFOJLyk+pzEgszogvKs1JLT7EKMPBoSTBu5DPIVJIsCg1PbUiLTMHGGYw aQkOHiUR3vssQGne4oLE3OLMdIjUKUZFKXHeCSB9AiCJjNI8uDZYaF9ilJUS5mUEOkSIpyC1K DezBFX+FaM4B6OSMG8LD9AUnsy8Erjpr4AWMwEtvg5yM29xSSJCSqqBsVH3fganV/3K/JVbmr 5vZnY5YKLz7sT/XdP4J4vE6efxGs6u9d3wd9/e2qxExdhJC14dVrmX9fPqzdpa11NP7a5wzSx JkRK00zujcUAksczpnG1XULzAPe3pv+1jkhuV/0n7PChuLHecYPd35+mkxNydjHLHWw/HZMzq 0JVN+RHb3F6k552lxFKckWioxVxUnAgAAuFPB2gCAAA= X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-14.tower-206.messagelabs.com!1497370420!64400387!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.19; banners=-,-,- X-VirusChecked: Checked Received: (qmail 56889 invoked from network); 13 Jun 2017 16:13:40 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-14.tower-206.messagelabs.com with SMTP; 13 Jun 2017 16:13:40 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 09DC31596; Tue, 13 Jun 2017 09:13:40 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.206.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 450213F557; Tue, 13 Jun 2017 09:13:39 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Tue, 13 Jun 2017 17:13:07 +0100 Message-Id: <20170613161323.25196-9-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170613161323.25196-1-julien.grall@arm.com> References: <20170613161323.25196-1-julien.grall@arm.com> Cc: Julien Grall , sstabellini@kernel.org, punit.agrawal@arm.com Subject: [Xen-devel] [PATCH 08/24] xen/arm: mm: Use typesafe MFN in mfn_to_xen_entry X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- xen/arch/arm/mm.c | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index d164ed2eda..08116679ec 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -259,7 +259,7 @@ void dump_hyp_walk(vaddr_t addr) * We put the same permissions at every level, because they're ignored * by the walker in non-leaf entries. */ -static inline lpae_t mfn_to_xen_entry(unsigned long mfn, unsigned attr) +static inline lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned attr) { lpae_t e = (lpae_t) { .pt = { @@ -315,9 +315,9 @@ static inline lpae_t mfn_to_xen_entry(unsigned long mfn, unsigned attr) break; } - ASSERT(!(pfn_to_paddr(mfn) & ~PADDR_MASK)); + ASSERT(!(pfn_to_paddr(mfn_x(mfn)) & ~PADDR_MASK)); - e.pt.base = mfn; + e.pt.base = mfn_x(mfn); return e; } @@ -325,7 +325,7 @@ static inline lpae_t mfn_to_xen_entry(unsigned long mfn, unsigned attr) /* Map a 4k page in a fixmap entry */ void set_fixmap(unsigned map, unsigned long mfn, unsigned attributes) { - lpae_t pte = mfn_to_xen_entry(mfn, attributes); + lpae_t pte = mfn_to_xen_entry(_mfn(mfn), attributes); pte.pt.table = 1; /* 4k mappings always have this bit set */ pte.pt.xn = 1; write_pte(xen_fixmap + third_table_offset(FIXMAP_ADDR(map)), pte); @@ -363,7 +363,7 @@ static void __init create_mappings(lpae_t *second, count = nr_mfns / LPAE_ENTRIES; p = second + second_linear_offset(virt_offset); - pte = mfn_to_xen_entry(base_mfn, WRITEALLOC); + pte = mfn_to_xen_entry(_mfn(base_mfn), WRITEALLOC); if ( granularity == 16 * LPAE_ENTRIES ) pte.pt.contig = 1; /* These maps are in 16-entry contiguous chunks. */ for ( i = 0; i < count; i++ ) @@ -416,7 +416,7 @@ void *map_domain_page(mfn_t mfn) else if ( map[slot].pt.avail == 0 ) { /* Commandeer this 2MB slot */ - pte = mfn_to_xen_entry(slot_mfn, WRITEALLOC); + pte = mfn_to_xen_entry(_mfn(slot_mfn), WRITEALLOC); pte.pt.avail = 1; write_pte(map + slot, pte); break; @@ -537,7 +537,7 @@ static inline lpae_t pte_of_xenaddr(vaddr_t va) { paddr_t ma = va + phys_offset; unsigned long mfn = ma >> PAGE_SHIFT; - return mfn_to_xen_entry(mfn, WRITEALLOC); + return mfn_to_xen_entry(_mfn(mfn), WRITEALLOC); } /* Map the FDT in the early boot page table */ @@ -646,7 +646,7 @@ void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr) /* Initialise xen second level entries ... */ /* ... Xen's text etc */ - pte = mfn_to_xen_entry(xen_paddr>>PAGE_SHIFT, WRITEALLOC); + pte = mfn_to_xen_entry(_mfn(xen_paddr>>PAGE_SHIFT), WRITEALLOC); pte.pt.xn = 0;/* Contains our text mapping! */ xen_second[second_table_offset(XEN_VIRT_START)] = pte; @@ -663,7 +663,7 @@ void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr) /* ... Boot Misc area for xen relocation */ dest_va = BOOT_RELOC_VIRT_START; - pte = mfn_to_xen_entry(xen_paddr >> PAGE_SHIFT, WRITEALLOC); + pte = mfn_to_xen_entry(_mfn(xen_paddr >> PAGE_SHIFT), WRITEALLOC); /* Map the destination in xen_second. */ xen_second[second_table_offset(dest_va)] = pte; /* Map the destination in boot_second. */ @@ -694,7 +694,7 @@ void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr) unsigned long va = XEN_VIRT_START + (i << PAGE_SHIFT); if ( !is_kernel(va) ) break; - pte = mfn_to_xen_entry(mfn, WRITEALLOC); + pte = mfn_to_xen_entry(_mfn(mfn), WRITEALLOC); pte.pt.table = 1; /* 4k mappings always have this bit set */ if ( is_kernel_text(va) || is_kernel_inittext(va) ) { @@ -764,7 +764,8 @@ int init_secondary_pagetables(int cpu) * domheap mapping pages. */ for ( i = 0; i < DOMHEAP_SECOND_PAGES; i++ ) { - pte = mfn_to_xen_entry(virt_to_mfn(domheap+i*LPAE_ENTRIES), WRITEALLOC); + pte = mfn_to_xen_entry(_mfn(virt_to_mfn(domheap+i*LPAE_ENTRIES)), + WRITEALLOC); pte.pt.table = 1; write_pte(&first[first_table_offset(DOMHEAP_VIRT_START+i*FIRST_SIZE)], pte); } @@ -862,13 +863,13 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, unsigned long first_mfn = alloc_boot_pages(1, 1); clear_page(mfn_to_virt(first_mfn)); - pte = mfn_to_xen_entry(first_mfn, WRITEALLOC); + pte = mfn_to_xen_entry(_mfn(first_mfn), WRITEALLOC); pte.pt.table = 1; write_pte(p, pte); first = mfn_to_virt(first_mfn); } - pte = mfn_to_xen_entry(mfn, WRITEALLOC); + pte = mfn_to_xen_entry(_mfn(mfn), WRITEALLOC); /* TODO: Set pte.pt.contig when appropriate. */ write_pte(&first[first_table_offset(vaddr)], pte); @@ -907,7 +908,7 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) for ( i = 0; i < nr_second; i++ ) { clear_page(mfn_to_virt(second_base + i)); - pte = mfn_to_xen_entry(second_base + i, WRITEALLOC); + pte = mfn_to_xen_entry(_mfn(second_base + i), WRITEALLOC); pte.pt.table = 1; write_pte(&xen_first[first_table_offset(FRAMETABLE_VIRT_START)+i], pte); } @@ -960,7 +961,7 @@ static int create_xen_table(lpae_t *entry) if ( p == NULL ) return -ENOMEM; clear_page(p); - pte = mfn_to_xen_entry(virt_to_mfn(p), WRITEALLOC); + pte = mfn_to_xen_entry(_mfn(virt_to_mfn(p)), WRITEALLOC); pte.pt.table = 1; write_pte(entry, pte); return 0; @@ -1011,7 +1012,7 @@ static int create_xen_entries(enum xenmap_operation op, } if ( op == RESERVE ) break; - pte = mfn_to_xen_entry(mfn, ai); + pte = mfn_to_xen_entry(_mfn(mfn), ai); pte.pt.table = 1; write_pte(&third[third_table_offset(addr)], pte); break;