[2/4] dt-bindings: iio: humidity: Add bindings for HTU21 and MS8607 sensors

Message ID 1497374443-20935-1-git-send-email-manivannan.sadhasivam@linaro.org
State New
Headers show
Series
  • Untitled series #2403
Related show

Commit Message

Manivannan Sadhasivam June 13, 2017, 5:20 p.m.
Add device tree bindings for Measurement-Specialties HTU21 temperature & humidity sensor and humidity part of MS8607 sensor

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

---
 Documentation/devicetree/bindings/iio/humidity/htu21.txt | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/iio/humidity/htu21.txt

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rob Herring June 18, 2017, 2:05 p.m. | #1
On Tue, Jun 13, 2017 at 10:50:43PM +0530, Manivannan Sadhasivam wrote:
> Add device tree bindings for Measurement-Specialties HTU21 temperature & humidity sensor and humidity part of MS8607 sensor

> 

> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> ---

>  Documentation/devicetree/bindings/iio/humidity/htu21.txt | 13 +++++++++++++

>  1 file changed, 13 insertions(+)

>  create mode 100644 Documentation/devicetree/bindings/iio/humidity/htu21.txt

> 

> diff --git a/Documentation/devicetree/bindings/iio/humidity/htu21.txt b/Documentation/devicetree/bindings/iio/humidity/htu21.txt

> new file mode 100644

> index 0000000..97d7963

> --- /dev/null

> +++ b/Documentation/devicetree/bindings/iio/humidity/htu21.txt

> @@ -0,0 +1,13 @@

> +*HTU21 - Measurement-Specialties htu21 temperature & humidity sensor and humidity part of MS8607 sensor


The binding should be for the device, not part of it. You should bind 
to a driver for MS8607 and then create 2 child devices for the humidity 
and temp sensors.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jonathan Cameron June 21, 2017, 7:40 p.m. | #2
On Sun, 18 Jun 2017 09:05:11 -0500
Rob Herring <robh@kernel.org> wrote:

> On Tue, Jun 13, 2017 at 10:50:43PM +0530, Manivannan Sadhasivam wrote:

> > Add device tree bindings for Measurement-Specialties HTU21 temperature & humidity sensor and humidity part of MS8607 sensor

> > 

> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> > ---

> >  Documentation/devicetree/bindings/iio/humidity/htu21.txt | 13 +++++++++++++

> >  1 file changed, 13 insertions(+)

> >  create mode 100644 Documentation/devicetree/bindings/iio/humidity/htu21.txt

> > 

> > diff --git a/Documentation/devicetree/bindings/iio/humidity/htu21.txt b/Documentation/devicetree/bindings/iio/humidity/htu21.txt

> > new file mode 100644

> > index 0000000..97d7963

> > --- /dev/null

> > +++ b/Documentation/devicetree/bindings/iio/humidity/htu21.txt

> > @@ -0,0 +1,13 @@

> > +*HTU21 - Measurement-Specialties htu21 temperature & humidity sensor and humidity part of MS8607 sensor  

> 

> The binding should be for the device, not part of it. You should bind 

> to a driver for MS8607 and then create 2 child devices for the humidity 

> and temp sensors.

Hi Rob,

It's a bit of an oddity as we are look at package in package parts. 
Really there are simply two parts here. There is no need to know
they are in the same package.  Obviously we 'could' describe this, but
it's no different form  mounting the chips next to each other on the
same bus sharing the same power rails.

I guess a binding that reflected this would act as 'documentation' perhaps,
but would provide no useful information.

Can you point us to a similar example (for future reference)?

Thanks

Jonathan

> 

> Rob


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rob Herring June 22, 2017, 3:05 a.m. | #3
On Wed, Jun 21, 2017 at 2:40 PM, Jonathan Cameron <jic23@kernel.org> wrote:
> On Sun, 18 Jun 2017 09:05:11 -0500

> Rob Herring <robh@kernel.org> wrote:

>

>> On Tue, Jun 13, 2017 at 10:50:43PM +0530, Manivannan Sadhasivam wrote:

>> > Add device tree bindings for Measurement-Specialties HTU21 temperature & humidity sensor and humidity part of MS8607 sensor

>> >

>> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

>> > ---

>> >  Documentation/devicetree/bindings/iio/humidity/htu21.txt | 13 +++++++++++++

>> >  1 file changed, 13 insertions(+)

>> >  create mode 100644 Documentation/devicetree/bindings/iio/humidity/htu21.txt

>> >

>> > diff --git a/Documentation/devicetree/bindings/iio/humidity/htu21.txt b/Documentation/devicetree/bindings/iio/humidity/htu21.txt

>> > new file mode 100644

>> > index 0000000..97d7963

>> > --- /dev/null

>> > +++ b/Documentation/devicetree/bindings/iio/humidity/htu21.txt

>> > @@ -0,0 +1,13 @@

>> > +*HTU21 - Measurement-Specialties htu21 temperature & humidity sensor and humidity part of MS8607 sensor

>>

>> The binding should be for the device, not part of it. You should bind

>> to a driver for MS8607 and then create 2 child devices for the humidity

>> and temp sensors.

> Hi Rob,

>

> It's a bit of an oddity as we are look at package in package parts.

> Really there are simply two parts here. There is no need to know

> they are in the same package.  Obviously we 'could' describe this, but

> it's no different form  mounting the chips next to each other on the

> same bus sharing the same power rails.


Okay, then it is fine as-is.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jonathan Cameron June 24, 2017, 8:50 p.m. | #4
On Wed, 21 Jun 2017 22:05:13 -0500
Rob Herring <robh@kernel.org> wrote:

> On Wed, Jun 21, 2017 at 2:40 PM, Jonathan Cameron <jic23@kernel.org> wrote:

> > On Sun, 18 Jun 2017 09:05:11 -0500

> > Rob Herring <robh@kernel.org> wrote:

> >  

> >> On Tue, Jun 13, 2017 at 10:50:43PM +0530, Manivannan Sadhasivam wrote:  

> >> > Add device tree bindings for Measurement-Specialties HTU21 temperature & humidity sensor and humidity part of MS8607 sensor

> >> >

> >> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> >> > ---

> >> >  Documentation/devicetree/bindings/iio/humidity/htu21.txt | 13 +++++++++++++

> >> >  1 file changed, 13 insertions(+)

> >> >  create mode 100644 Documentation/devicetree/bindings/iio/humidity/htu21.txt

> >> >

> >> > diff --git a/Documentation/devicetree/bindings/iio/humidity/htu21.txt b/Documentation/devicetree/bindings/iio/humidity/htu21.txt

> >> > new file mode 100644

> >> > index 0000000..97d7963

> >> > --- /dev/null

> >> > +++ b/Documentation/devicetree/bindings/iio/humidity/htu21.txt

> >> > @@ -0,0 +1,13 @@

> >> > +*HTU21 - Measurement-Specialties htu21 temperature & humidity sensor and humidity part of MS8607 sensor  

> >>

> >> The binding should be for the device, not part of it. You should bind

> >> to a driver for MS8607 and then create 2 child devices for the humidity

> >> and temp sensors.  

> > Hi Rob,

> >

> > It's a bit of an oddity as we are look at package in package parts.

> > Really there are simply two parts here. There is no need to know

> > they are in the same package.  Obviously we 'could' describe this, but

> > it's no different form  mounting the chips next to each other on the

> > same bus sharing the same power rails.  

> 

> Okay, then it is fine as-is.

> 

> Rob

Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.

Thanks Rob for getting back to me on this.

Jonathan

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch hide | download patch | download mbox

diff --git a/Documentation/devicetree/bindings/iio/humidity/htu21.txt b/Documentation/devicetree/bindings/iio/humidity/htu21.txt
new file mode 100644
index 0000000..97d7963
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/humidity/htu21.txt
@@ -0,0 +1,13 @@ 
+*HTU21 - Measurement-Specialties htu21 temperature & humidity sensor and humidity part of MS8607 sensor
+
+Required properties:
+
+	- compatible: should be "meas,htu21" or "meas,ms8607-humidity"
+	- reg: I2C address of the sensor
+
+Example:
+
+htu21@40 {
+	compatible = "meas,htu21";
+	reg = <0x40>;
+};