[v11,13/19] media: venus: hfi_venus: fix variable dereferenced before check

Message ID 1497544320-2269-14-git-send-email-stanimir.varbanov@linaro.org
State Accepted
Commit 4cb3548a87c4a3650ab9c4587abfcf5fe6fa7542
Headers show
Series
  • [v11,01/19] media: v4l2-mem2mem: extend m2m APIs for more accurate buffer management
Related show

Commit Message

Stanimir Varbanov June 15, 2017, 4:31 p.m.
This fixes a warning found when building with gcc7:

drivers/media/platform/qcom/venus/hfi_venus.c:998
venus_isr_thread() warn: variable dereferenced before check
'hdev' (see line 994)

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>

---
 drivers/media/platform/qcom/venus/hfi_venus.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.7.4

Patch hide | download patch | download mbox

diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c b/drivers/media/platform/qcom/venus/hfi_venus.c
index ab209f3d9498..1caae8feaa36 100644
--- a/drivers/media/platform/qcom/venus/hfi_venus.c
+++ b/drivers/media/platform/qcom/venus/hfi_venus.c
@@ -991,13 +991,14 @@  static void venus_process_msg_sys_error(struct venus_hfi_device *hdev,
 static irqreturn_t venus_isr_thread(struct venus_core *core)
 {
 	struct venus_hfi_device *hdev = to_hfi_priv(core);
-	const struct venus_resources *res = hdev->core->res;
+	const struct venus_resources *res;
 	void *pkt;
 	u32 msg_ret;
 
 	if (!hdev)
 		return IRQ_NONE;
 
+	res = hdev->core->res;
 	pkt = hdev->pkt_buf;
 
 	if (hdev->irq_status & WRAPPER_INTR_STATUS_A2HWD_MASK) {