diff mbox

drm: Convert CMA fbdev console suspend helpers to use bool

Message ID 20170620102320.8849-1-Liviu.Dudau@arm.com
State New
Headers show

Commit Message

Liviu Dudau June 20, 2017, 10:23 a.m. UTC
drm_fbdev_cma_set_suspend{,_unlocked} use an integer parameter
to describe whether the intended state is a suspend or a resume.
It then passes the value to drm_fb_helper_set_suspend{,_unlocked}
which uses a boolean. Switch to using bool everywhere.

Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>

---
 drivers/gpu/drm/drm_fb_cma_helper.c | 4 ++--
 include/drm/drm_fb_cma_helper.h     | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.13.1

Comments

Daniel Vetter June 20, 2017, 2:23 p.m. UTC | #1
On Tue, Jun 20, 2017 at 11:23:20AM +0100, Liviu Dudau wrote:
> drm_fbdev_cma_set_suspend{,_unlocked} use an integer parameter

> to describe whether the intended state is a suspend or a resume.

> It then passes the value to drm_fb_helper_set_suspend{,_unlocked}

> which uses a boolean. Switch to using bool everywhere.

> 

> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>


Sweet, patch applied, thanks.
-Daniel

> ---

>  drivers/gpu/drm/drm_fb_cma_helper.c | 4 ++--

>  include/drm/drm_fb_cma_helper.h     | 4 ++--

>  2 files changed, 4 insertions(+), 4 deletions(-)

> 

> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c

> index 53f9bdf470d7..ade319d10e70 100644

> --- a/drivers/gpu/drm/drm_fb_cma_helper.c

> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c

> @@ -640,7 +640,7 @@ EXPORT_SYMBOL_GPL(drm_fbdev_cma_hotplug_event);

>   * Calls drm_fb_helper_set_suspend, which is a wrapper around

>   * fb_set_suspend implemented by fbdev core.

>   */

> -void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, int state)

> +void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state)

>  {

>  	if (fbdev_cma)

>  		drm_fb_helper_set_suspend(&fbdev_cma->fb_helper, state);

> @@ -657,7 +657,7 @@ EXPORT_SYMBOL(drm_fbdev_cma_set_suspend);

>   * fb_set_suspend implemented by fbdev core.

>   */

>  void drm_fbdev_cma_set_suspend_unlocked(struct drm_fbdev_cma *fbdev_cma,

> -					int state)

> +					bool state)

>  {

>  	if (fbdev_cma)

>  		drm_fb_helper_set_suspend_unlocked(&fbdev_cma->fb_helper,

> diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h

> index 199a63f48659..a323781afc3f 100644

> --- a/include/drm/drm_fb_cma_helper.h

> +++ b/include/drm/drm_fb_cma_helper.h

> @@ -24,9 +24,9 @@ void drm_fbdev_cma_fini(struct drm_fbdev_cma *fbdev_cma);

>  

>  void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma);

>  void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma);

> -void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, int state);

> +void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state);

>  void drm_fbdev_cma_set_suspend_unlocked(struct drm_fbdev_cma *fbdev_cma,

> -					int state);

> +					bool state);

>  

>  void drm_fb_cma_destroy(struct drm_framebuffer *fb);

>  int drm_fb_cma_create_handle(struct drm_framebuffer *fb,

> -- 

> 2.13.1

> 

> _______________________________________________

> dri-devel mailing list

> dri-devel@lists.freedesktop.org

> https://lists.freedesktop.org/mailman/listinfo/dri-devel


-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
diff mbox

Patch

diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
index 53f9bdf470d7..ade319d10e70 100644
--- a/drivers/gpu/drm/drm_fb_cma_helper.c
+++ b/drivers/gpu/drm/drm_fb_cma_helper.c
@@ -640,7 +640,7 @@  EXPORT_SYMBOL_GPL(drm_fbdev_cma_hotplug_event);
  * Calls drm_fb_helper_set_suspend, which is a wrapper around
  * fb_set_suspend implemented by fbdev core.
  */
-void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, int state)
+void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state)
 {
 	if (fbdev_cma)
 		drm_fb_helper_set_suspend(&fbdev_cma->fb_helper, state);
@@ -657,7 +657,7 @@  EXPORT_SYMBOL(drm_fbdev_cma_set_suspend);
  * fb_set_suspend implemented by fbdev core.
  */
 void drm_fbdev_cma_set_suspend_unlocked(struct drm_fbdev_cma *fbdev_cma,
-					int state)
+					bool state)
 {
 	if (fbdev_cma)
 		drm_fb_helper_set_suspend_unlocked(&fbdev_cma->fb_helper,
diff --git a/include/drm/drm_fb_cma_helper.h b/include/drm/drm_fb_cma_helper.h
index 199a63f48659..a323781afc3f 100644
--- a/include/drm/drm_fb_cma_helper.h
+++ b/include/drm/drm_fb_cma_helper.h
@@ -24,9 +24,9 @@  void drm_fbdev_cma_fini(struct drm_fbdev_cma *fbdev_cma);
 
 void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma);
 void drm_fbdev_cma_hotplug_event(struct drm_fbdev_cma *fbdev_cma);
-void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, int state);
+void drm_fbdev_cma_set_suspend(struct drm_fbdev_cma *fbdev_cma, bool state);
 void drm_fbdev_cma_set_suspend_unlocked(struct drm_fbdev_cma *fbdev_cma,
-					int state);
+					bool state);
 
 void drm_fb_cma_destroy(struct drm_framebuffer *fb);
 int drm_fb_cma_create_handle(struct drm_framebuffer *fb,