diff mbox

drivers/fsi: fix fsi_slave_mode prototype

Message ID 20170620204417.854521-1-arnd@arndb.de
State Accepted
Commit ceb8a12ff2d4b085f7cee1ac44523ee63ce51e20
Headers show

Commit Message

Arnd Bergmann June 20, 2017, 8:43 p.m. UTC
gcc warns about the return type of this function:

drivers/fsi/fsi-core.c:535:8: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]

This removes the 'const' attribute, as suggested by the warning.

Fixes: 2b37c3e285f9 ("drivers/fsi: Set slave SMODE to init communication")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/fsi/fsi-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.9.0

Comments

Jeremy Kerr June 21, 2017, 12:49 a.m. UTC | #1
Hi Arnd,

> gcc warns about the return type of this function:

> 

> drivers/fsi/fsi-core.c:535:8: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]

> 

> This removes the 'const' attribute, as suggested by the warning.


Acked-by: Jeremy Kerr <jk@ozlabs.org>


Cheers,


Jeremy
Geert Uytterhoeven July 4, 2017, 10:29 a.m. UTC | #2
On Tue, Jun 20, 2017 at 10:43 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> gcc warns about the return type of this function:

>

> drivers/fsi/fsi-core.c:535:8: error: type qualifiers ignored on function return type [-Werror=ignored-qualifiers]

>

> This removes the 'const' attribute, as suggested by the warning.

>

> Fixes: 2b37c3e285f9 ("drivers/fsi: Set slave SMODE to init communication")

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>


Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
diff mbox

Patch

diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
index a485864cb512..f2e08932e2d9 100644
--- a/drivers/fsi/fsi-core.c
+++ b/drivers/fsi/fsi-core.c
@@ -532,7 +532,7 @@  static inline uint32_t fsi_smode_sid(int x)
 	return (x & FSI_SMODE_SID_MASK) << FSI_SMODE_SID_SHIFT;
 }
 
-static const uint32_t fsi_slave_smode(int id)
+static uint32_t fsi_slave_smode(int id)
 {
 	return FSI_SMODE_WSC | FSI_SMODE_ECRC
 		| fsi_smode_sid(id)