| Message ID | 1498022493-20292-3-git-send-email-john.stultz@linaro.org |
|---|---|
| State | Accepted |
| Commit | 369adf04d80a7e179b9ea6d74cc01c233f142f47 |
| Headers | show |
| Series | Timekeeping items for 4.13 | expand |
On Tue, Jun 20, 2017 at 10:21:31PM -0700, John Stultz wrote: > CONFIG_GENERIC_TIME_VSYSCALL_OLD was introduced five years ago > to allow a transition from the old vsyscall implementations to > the new method (which simplified internal accounting and made > timekeeping more precise). > > However, PPC and IA64 have yet to make the transition, despite > in some cases me sending test patches to try to help it along. Did you see my patch converting PPC to the new method? Did you have any comments on it? Regards, Paul.
John Stultz <john.stultz@linaro.org> writes: > CONFIG_GENERIC_TIME_VSYSCALL_OLD was introduced five years ago > to allow a transition from the old vsyscall implementations to > the new method (which simplified internal accounting and made > timekeeping more precise). > > However, PPC and IA64 have yet to make the transition, despite > in some cases me sending test patches to try to help it along. Any chance you can review/ack the patch from Paul to convert powerpc to the new style? :D cheers
On Tue, Jun 20, 2017 at 11:11 PM, Paul Mackerras <paulus@ozlabs.org> wrote: > On Tue, Jun 20, 2017 at 10:21:31PM -0700, John Stultz wrote: >> CONFIG_GENERIC_TIME_VSYSCALL_OLD was introduced five years ago >> to allow a transition from the old vsyscall implementations to >> the new method (which simplified internal accounting and made >> timekeeping more precise). >> >> However, PPC and IA64 have yet to make the transition, despite >> in some cases me sending test patches to try to help it along. > > Did you see my patch converting PPC to the new method? Did you have > any comments on it? Oh, somehow I missed it! My apologies. That's great to see! It roughly looks ok, but I'll need to look at it closer with fresh eyes (and honestly, its complex enough I'm not sure I will be able to fully mentally validate it :) But I'll try to give it a look tomorrow. thanks -john
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index 0454bfa..cedafa0 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c @@ -516,6 +516,7 @@ static void halt_fast_timekeeper(struct timekeeper *tk) } #ifdef CONFIG_GENERIC_TIME_VSYSCALL_OLD +#warning Please contact your maintainers, as GENERIC_TIME_VSYSCALL_OLD compatibity will disappear soon. static inline void update_vsyscall(struct timekeeper *tk) {
CONFIG_GENERIC_TIME_VSYSCALL_OLD was introduced five years ago to allow a transition from the old vsyscall implementations to the new method (which simplified internal accounting and made timekeeping more precise). However, PPC and IA64 have yet to make the transition, despite in some cases me sending test patches to try to help it along. http://patches.linaro.org/patch/30501/ http://patches.linaro.org/patch/35412/ If its helpful, my last pass at the patches can be found here: https://git.linaro.org/people/john.stultz/linux.git dev/oldvsyscall-cleanup So I think its time to set a deadline and make it clear this is going away. So this patch adds warnings about this functionality being dropped. Likely to be in v4.15. Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@kernel.org> Cc: Miroslav Lichvar <mlichvar@redhat.com> Cc: Richard Cochran <richardcochran@gmail.com> Cc: Prarit Bhargava <prarit@redhat.com> Cc: Marcelo Tosatti <mtosatti@redhat.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Anton Blanchard <anton@samba.org> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Tony Luck <tony.luck@intel.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Fenghua Yu <fenghua.yu@intel.com> Signed-off-by: John Stultz <john.stultz@linaro.org> --- kernel/time/timekeeping.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4