[Xen-devel,07/17,v5] xen/arm: vpl011: Rearrange xen header includes in alphabetical order in domctl.c

Message ID 1498117132-27139-8-git-send-email-bhupinder.thakur@linaro.org
State New
Headers show
Series
  • SBSA UART emulation support in Xen
Related show

Commit Message

Bhupinder Thakur June 22, 2017, 7:38 a.m.
Rearrange xen header includes in alphabetical order in domctl.c.

Signed-off-by: Bhupinder Thakur <bhupinder.thakur@linaro.org>
---
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien.grall@arm.com>

 xen/arch/arm/domctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stefano Stabellini June 22, 2017, 10:58 p.m. | #1
On Thu, 22 Jun 2017, Bhupinder Thakur wrote:
> Rearrange xen header includes in alphabetical order in domctl.c.
> 
> Signed-off-by: Bhupinder Thakur <bhupinder.thakur@linaro.org>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

> ---
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien.grall@arm.com>
> 
>  xen/arch/arm/domctl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
> index 971caec..86fa102 100644
> --- a/xen/arch/arm/domctl.c
> +++ b/xen/arch/arm/domctl.c
> @@ -5,11 +5,11 @@
>   */
>  
>  #include <xen/types.h>
> -#include <xen/lib.h>
>  #include <xen/errno.h>
> -#include <xen/sched.h>
>  #include <xen/hypercall.h>
>  #include <xen/iocap.h>
> +#include <xen/lib.h>
> +#include <xen/sched.h>
>  #include <xsm/xsm.h>
>  #include <public/domctl.h>
>  
> -- 
> 2.7.4
>
Julien Grall June 23, 2017, 1:14 p.m. | #2
Hi,

On 22/06/17 23:58, Stefano Stabellini wrote:
> On Thu, 22 Jun 2017, Bhupinder Thakur wrote:
>> Rearrange xen header includes in alphabetical order in domctl.c.
>>
>> Signed-off-by: Bhupinder Thakur <bhupinder.thakur@linaro.org>
>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>
>> ---
>> CC: Stefano Stabellini <sstabellini@kernel.org>
>> CC: Julien Grall <julien.grall@arm.com>
>>
>>  xen/arch/arm/domctl.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
>> index 971caec..86fa102 100644
>> --- a/xen/arch/arm/domctl.c
>> +++ b/xen/arch/arm/domctl.c
>> @@ -5,11 +5,11 @@
>>   */
>>
>>  #include <xen/types.h>

The headers still not in alphabetical order. xen/types.h is not at the 
correct place. If there is any reason why it is not done, it should be 
said in the commit message.

>> -#include <xen/lib.h>
>>  #include <xen/errno.h>
>> -#include <xen/sched.h>
>>  #include <xen/hypercall.h>
>>  #include <xen/iocap.h>
>> +#include <xen/lib.h>
>> +#include <xen/sched.h>
>>  #include <xsm/xsm.h>
>>  #include <public/domctl.h>
>>
>> --
>> 2.7.4
>>

Cheers,

Patch hide | download patch | download mbox

diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
index 971caec..86fa102 100644
--- a/xen/arch/arm/domctl.c
+++ b/xen/arch/arm/domctl.c
@@ -5,11 +5,11 @@ 
  */
 
 #include <xen/types.h>
-#include <xen/lib.h>
 #include <xen/errno.h>
-#include <xen/sched.h>
 #include <xen/hypercall.h>
 #include <xen/iocap.h>
+#include <xen/lib.h>
+#include <xen/sched.h>
 #include <xsm/xsm.h>
 #include <public/domctl.h>